| Message ID | 1586949255-17234-2-git-send-email-bernard.iremonger@intel.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers | show |
| Series |
|
| Related | show |
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | fail | Compilation issues |
| ci/checkpatch | success | coding style OK |
> -----Original Message----- > From: Iremonger, Bernard <bernard.iremonger@intel.com> > Sent: Wednesday, April 15, 2020 7:14 PM > To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com>; Doherty, Declan <declan.doherty@intel.com> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Iremonger, > Bernard <bernard.iremonger@intel.com> > Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH > > add ETH_RSS_ESP and ETH_RSS_AH macros > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > --- > lib/librte_ethdev/rte_ethdev.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index d1a593a..26381a1 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -511,6 +511,9 @@ struct rte_eth_rss_conf { > #define ETH_RSS_GENEVE (1ULL << 20) > #define ETH_RSS_NVGRE (1ULL << 21) > #define ETH_RSS_GTPU (1ULL << 23) > +#define ETH_RSS_ESP (1ULL << 27) > +#define ETH_RSS_AH (1ULL << 28) > + > > /* > * We use the following macros to combine with above ETH_RSS_* for > -- > 2.7.4 Reviewed-by: Beilei Xing <beilei.xing@intel.com>
> -----Original Message----- > From: Iremonger, Bernard <bernard.iremonger@intel.com> > Sent: Wednesday, April 15, 2020 7:14 PM > To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com>; Doherty, Declan <declan.doherty@intel.com> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Iremonger, > Bernard <bernard.iremonger@intel.com> > Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH > > add ETH_RSS_ESP and ETH_RSS_AH macros > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > --- The describe is too simple, more introduces can be added in code or commit log.
On 4/16/2020 2:26 PM, Dong Zhou wrote: > >> -----Original Message----- >> From: Iremonger, Bernard <bernard.iremonger@intel.com> >> Sent: Wednesday, April 15, 2020 7:14 PM >> To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z >> <qi.z.zhang@intel.com>; Doherty, Declan <declan.doherty@intel.com> >> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Iremonger, >> Bernard <bernard.iremonger@intel.com> >> Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH >> >> add ETH_RSS_ESP and ETH_RSS_AH macros >> >> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> >> --- > > The describe is too simple, more introduces can be added in code or commit log. > Change is already simple, but if more details comes I can update them in next-net. Thanks, ferruh
On 4/16/2020 2:14 AM, Xing, Beilei wrote: > > >> -----Original Message----- >> From: Iremonger, Bernard <bernard.iremonger@intel.com> >> Sent: Wednesday, April 15, 2020 7:14 PM >> To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z >> <qi.z.zhang@intel.com>; Doherty, Declan <declan.doherty@intel.com> >> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Iremonger, >> Bernard <bernard.iremonger@intel.com> >> Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH >> >> add ETH_RSS_ESP and ETH_RSS_AH macros >> >> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> >> --- >> lib/librte_ethdev/rte_ethdev.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h >> index d1a593a..26381a1 100644 >> --- a/lib/librte_ethdev/rte_ethdev.h >> +++ b/lib/librte_ethdev/rte_ethdev.h >> @@ -511,6 +511,9 @@ struct rte_eth_rss_conf { >> #define ETH_RSS_GENEVE (1ULL << 20) >> #define ETH_RSS_NVGRE (1ULL << 21) >> #define ETH_RSS_GTPU (1ULL << 23) >> +#define ETH_RSS_ESP (1ULL << 27) >> +#define ETH_RSS_AH (1ULL << 28) >> + >> >> /* >> * We use the following macros to combine with above ETH_RSS_* for >> -- >> 2.7.4 > > Reviewed-by: Beilei Xing <beilei.xing@intel.com> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Hi Dong, > -----Original Message----- > From: Dong Zhou <dongz@mellanox.com> > Sent: Thursday, April 16, 2020 2:26 PM > To: Iremonger, Bernard <bernard.iremonger@intel.com> > Cc: Xing, Beilei <beilei.xing@intel.com>; Doherty, Declan > <declan.doherty@intel.com>; dev@dpdk.org; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4 1/3] librte_ethdev: add RSS offload types > for ESP and AH > > > > -----Original Message----- > > From: Iremonger, Bernard <bernard.iremonger@intel.com> > > Sent: Wednesday, April 15, 2020 7:14 PM > > To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z > > <qi.z.zhang@intel.com>; Doherty, Declan <declan.doherty@intel.com> > > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Iremonger, > > Bernard <bernard.iremonger@intel.com> > > Subject: [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP > > and AH > > > > add ETH_RSS_ESP and ETH_RSS_AH macros > > > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > > --- > > The describe is too simple, more introduces can be added in code or commit > log. The patch is simple, and the commit messages describes what has been changed. What extra information would you like to see? Regards, Bernard.
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index d1a593a..26381a1 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -511,6 +511,9 @@ struct rte_eth_rss_conf { #define ETH_RSS_GENEVE (1ULL << 20) #define ETH_RSS_NVGRE (1ULL << 21) #define ETH_RSS_GTPU (1ULL << 23) +#define ETH_RSS_ESP (1ULL << 27) +#define ETH_RSS_AH (1ULL << 28) + /* * We use the following macros to combine with above ETH_RSS_* for
add ETH_RSS_ESP and ETH_RSS_AH macros Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> --- lib/librte_ethdev/rte_ethdev.h | 3 +++ 1 file changed, 3 insertions(+)