| Message ID | 1585151755-15837-3-git-send-email-bernard.iremonger@intel.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | Ferruh Yigit |
| Headers | show |
| Series |
|
| Related | show |
| Context | Check | Description |
|---|---|---|
| ci/Performance-Testing | fail | build patch failure |
| ci/Intel-compilation | fail | apply issues |
| ci/checkpatch | success | coding style OK |
Hi Bernard, > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Bernard Iremonger > Sent: Wednesday, March 25, 2020 5:56 PM > To: dev@dpdk.org; beilei.xing@intel.com; qi.z.zhang@intel.com; > declan.doherty@intel.com > Cc: konstantin.ananyev@intel.com; Bernard Iremonger > <bernard.iremonger@intel.com> > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP > and AH > > parse RSS offload types ESP and AH > add printf for rss_hf > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > --- > app/test-pmd/cmdline.c | 4 +++- > app/test-pmd/config.c | 6 ++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index a037a55..997f063 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result, > i, -diag, strerror(-diag)); > } > } > - if (all_updated && !use_default) > + if (all_updated && !use_default) { > rss_hf = rss_conf.rss_hf; > + printf("rss_hf %#"PRIx64"\n", rss_hf); > + } > } > > cmdline_parse_token_string_t cmd_config_rss_port = > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 8cf84cc..df52df9 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -106,6 +106,12 @@ const struct rss_type_info rss_type_table[] = { > { "l3-dst-only", ETH_RSS_L3_DST_ONLY }, > { "l4-src-only", ETH_RSS_L4_SRC_ONLY }, > { "l4-dst-only", ETH_RSS_L4_DST_ONLY }, > + { "ipv4-esp", ETH_RSS_ESP }, > + { "ipv6-esp", ETH_RSS_ESP }, > + { "ipv4-udp-esp", ETH_RSS_ESP }, > + { "ipv6-udp-esp", ETH_RSS_ESP }, > + { "ipv4-ah", ETH_RSS_AH }, > + { "ipv6-ah", ETH_RSS_AH }, Why do you have all those variations since they don't have any affect. I think it should be just like your first patch, only esp and ah. For example the udp should look like this: flow create 0 ingress pattern eth / end actions rss queues 0 1 end types udp esp end / end Best, Ori > { NULL, 0 }, > }; > > -- > 2.7.4
Hi Ori, > -----Original Message----- > From: Ori Kam <orika@mellanox.com> > Sent: Tuesday, March 31, 2020 10:58 AM > To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org; > Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; > Doherty, Declan <declan.doherty@intel.com> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com> > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload > types ESP and AH > > Hi Bernard, > > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of Bernard Iremonger > > Sent: Wednesday, March 25, 2020 5:56 PM > > To: dev@dpdk.org; beilei.xing@intel.com; qi.z.zhang@intel.com; > > declan.doherty@intel.com > > Cc: konstantin.ananyev@intel.com; Bernard Iremonger > > <bernard.iremonger@intel.com> > > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload > > types ESP and AH > > > > parse RSS offload types ESP and AH > > add printf for rss_hf > > > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > > --- > > app/test-pmd/cmdline.c | 4 +++- > > app/test-pmd/config.c | 6 ++++++ > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > a037a55..997f063 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result, > > i, -diag, strerror(-diag)); > > } > > } > > - if (all_updated && !use_default) > > + if (all_updated && !use_default) { > > rss_hf = rss_conf.rss_hf; > > + printf("rss_hf %#"PRIx64"\n", rss_hf); > > + } > > } > > > > cmdline_parse_token_string_t cmd_config_rss_port = diff --git > > a/app/test-pmd/config.c b/app/test-pmd/config.c index 8cf84cc..df52df9 > > 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -106,6 +106,12 @@ const struct rss_type_info rss_type_table[] = { > > { "l3-dst-only", ETH_RSS_L3_DST_ONLY }, > > { "l4-src-only", ETH_RSS_L4_SRC_ONLY }, > > { "l4-dst-only", ETH_RSS_L4_DST_ONLY }, > > + { "ipv4-esp", ETH_RSS_ESP }, > > + { "ipv6-esp", ETH_RSS_ESP }, > > + { "ipv4-udp-esp", ETH_RSS_ESP }, > > + { "ipv6-udp-esp", ETH_RSS_ESP }, > > + { "ipv4-ah", ETH_RSS_AH }, > > + { "ipv6-ah", ETH_RSS_AH }, > > Why do you have all those variations since they don't have any affect. > I think it should be just like your first patch, only esp and ah. > For example the udp should look like this: > flow create 0 ingress pattern eth / end actions rss queues 0 1 end types udp > esp end / end > > Best, > Ori > I thought that it might be clearer to map the patterns to the flow. I will change to esp and ah in v3 patch. Regards, Bernard. <snip>
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index a037a55..997f063 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result, i, -diag, strerror(-diag)); } } - if (all_updated && !use_default) + if (all_updated && !use_default) { rss_hf = rss_conf.rss_hf; + printf("rss_hf %#"PRIx64"\n", rss_hf); + } } cmdline_parse_token_string_t cmd_config_rss_port = diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 8cf84cc..df52df9 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -106,6 +106,12 @@ const struct rss_type_info rss_type_table[] = { { "l3-dst-only", ETH_RSS_L3_DST_ONLY }, { "l4-src-only", ETH_RSS_L4_SRC_ONLY }, { "l4-dst-only", ETH_RSS_L4_DST_ONLY }, + { "ipv4-esp", ETH_RSS_ESP }, + { "ipv6-esp", ETH_RSS_ESP }, + { "ipv4-udp-esp", ETH_RSS_ESP }, + { "ipv6-udp-esp", ETH_RSS_ESP }, + { "ipv4-ah", ETH_RSS_AH }, + { "ipv6-ah", ETH_RSS_AH }, { NULL, 0 }, };
parse RSS offload types ESP and AH add printf for rss_hf Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> --- app/test-pmd/cmdline.c | 4 +++- app/test-pmd/config.c | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletion(-)