diff mbox series

app/testpmd: fix identifier size for port attach

Message ID 1582130850-6958-1-git-send-email-wisamm@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series app/testpmd: fix identifier size for port attach |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation fail apply issues
ci/travis-robot success Travis build: passed

Commit Message

Wisam Jaddo Feb. 19, 2020, 4:47 p.m. UTC 
  Identifier for new port may contain white list options,
and white list options will not fit into 128 from STR_TOKEN_SIZE,
instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide
better and more options

Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
Cc: mukawa@igel.co.jp
Cc: stable@dpdk.org

Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
---
 app/test-pmd/cmdline.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Iremonger, Bernard Feb. 20, 2020, 10:03 a.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wisam Jaddo
> Sent: Wednesday, February 19, 2020 4:48 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org;
> rasland@mellanox.com; matan@mellanox.com
> Cc: mukawa@igel.co.jp; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach
> 
> Identifier for new port may contain white list options, and white list options
> will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 char from
> STR_MULTI_TOKEN_SIZE will provide better and more options
> 
> Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
> Cc: mukawa@igel.co.jp
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Ferruh Yigit Feb. 20, 2020, 12:28 p.m. UTC | #2 
On 2/19/2020 4:47 PM, Wisam Jaddo wrote:
> Identifier for new port may contain white list options,
> and white list options will not fit into 128 from STR_TOKEN_SIZE,
> instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide
> better and more options

Out of curiosity, what device identifier doesn't fit to 128 chars, can you
please give a sample?

> 
> Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
> Cc: mukawa@igel.co.jp
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
> ---
>  app/test-pmd/cmdline.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 38b6d80..a037a55 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = {
>  struct cmd_operate_attach_port_result {
>  	cmdline_fixed_string_t port;
>  	cmdline_fixed_string_t keyword;
> -	cmdline_fixed_string_t identifier;
> +	cmdline_multi_string_t identifier;
>  };
>  
>  static void cmd_operate_attach_port_parsed(void *parsed_result,
> @@ -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword =
>  			keyword, "attach");
>  cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
>  	TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result,
> -			identifier, NULL);
> +			identifier, TOKEN_STRING_MULTI);
>  
>  cmdline_parse_inst_t cmd_operate_attach_port = {
>  	.f = cmd_operate_attach_port_parsed,
>
Wisam Jaddo Feb. 20, 2020, 12:32 p.m. UTC | #3 
When attaching new device, it needs to pass the white list options with the PCI,
For example if I want the following set of options with the new attach device it will fail
Due to not enough space:
port attach 0000:03:00.0,l3_vxlan_en=1,txq_inline_mpw=77,dv_xmeta_en=1,txqs_min_inline=0,dv_esw_en=1,dv_flow_en=1,txq_inline_min=28,txq_inline_max=65

-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com> 
Sent: Thursday, February 20, 2020 2:28 PM
To: Wisam Monther <wisamm@mellanox.com>; wenzhuo.lu@intel.com; dev@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; Matan Azrad <matan@mellanox.com>
Cc: mukawa@igel.co.jp; stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach

On 2/19/2020 4:47 PM, Wisam Jaddo wrote:
> Identifier for new port may contain white list options, and white list 
> options will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 
> char from STR_MULTI_TOKEN_SIZE will provide better and more options

Out of curiosity, what device identifier doesn't fit to 128 chars, can you please give a sample?

> 
> Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
> Cc: mukawa@igel.co.jp
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
> ---
>  app/test-pmd/cmdline.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 
> 38b6d80..a037a55 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = {  
> struct cmd_operate_attach_port_result {
>  	cmdline_fixed_string_t port;
>  	cmdline_fixed_string_t keyword;
> -	cmdline_fixed_string_t identifier;
> +	cmdline_multi_string_t identifier;
>  };
>  
>  static void cmd_operate_attach_port_parsed(void *parsed_result, @@ 
> -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword =
>  			keyword, "attach");
>  cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
>  	TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result,
> -			identifier, NULL);
> +			identifier, TOKEN_STRING_MULTI);
>  
>  cmdline_parse_inst_t cmd_operate_attach_port = {
>  	.f = cmd_operate_attach_port_parsed,
>
Ferruh Yigit Feb. 20, 2020, 2:18 p.m. UTC | #4 
On 2/20/2020 10:03 AM, Iremonger, Bernard wrote:
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Wisam Jaddo
>> Sent: Wednesday, February 19, 2020 4:48 PM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org;
>> rasland@mellanox.com; matan@mellanox.com
>> Cc: mukawa@igel.co.jp; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach
>>
>> Identifier for new port may contain white list options, and white list options
>> will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 char from
>> STR_MULTI_TOKEN_SIZE will provide better and more options
>>
>> Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
>> Cc: mukawa@igel.co.jp
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> 

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 38b6d80..a037a55 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1446,7 +1446,7 @@  cmdline_parse_inst_t cmd_set_port_setup_on = {
 struct cmd_operate_attach_port_result {
 	cmdline_fixed_string_t port;
 	cmdline_fixed_string_t keyword;
-	cmdline_fixed_string_t identifier;
+	cmdline_multi_string_t identifier;
 };
 
 static void cmd_operate_attach_port_parsed(void *parsed_result,
@@ -1469,7 +1469,7 @@  cmdline_parse_token_string_t cmd_operate_attach_port_keyword =
 			keyword, "attach");
 cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
 	TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result,
-			identifier, NULL);
+			identifier, TOKEN_STRING_MULTI);
 
 cmdline_parse_inst_t cmd_operate_attach_port = {
 	.f = cmd_operate_attach_port_parsed,