Message ID | 20200213202442.19674-2-dwilder@us.ibm.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DD83A0544; Thu, 13 Feb 2020 21:25:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78EF41C001; Thu, 13 Feb 2020 21:24:57 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id 13BA41BFF9 for <dev@dpdk.org>; Thu, 13 Feb 2020 21:24:55 +0100 (CET) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01DKL2xE135989; Thu, 13 Feb 2020 15:24:53 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 2y3wxunsmb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Feb 2020 15:24:53 -0500 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 01DKL3A7136048; Thu, 13 Feb 2020 15:24:53 -0500 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0b-001b2d01.pphosted.com with ESMTP id 2y3wxunsm1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Feb 2020 15:24:53 -0500 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 01DKKRgM005228; Thu, 13 Feb 2020 20:24:52 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma02dal.us.ibm.com with ESMTP id 2y5bc0h3nk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Feb 2020 20:24:52 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01DKOpJe47841566 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Feb 2020 20:24:51 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6AED6124052; Thu, 13 Feb 2020 20:24:51 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7CDCC124053; Thu, 13 Feb 2020 20:24:50 +0000 (GMT) Received: from oc8377887825.ibm.com (unknown [9.70.82.120]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 13 Feb 2020 20:24:50 +0000 (GMT) From: David Wilder <dwilder@us.ibm.com> To: aconole@redhat.com, maicolgabriel@hotmail.com, thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com Cc: dev@dpdk.org, ruifeng.wang@arm.com, david.marchand@redhat.com, drc@linux.vnet.ibm.com, wilder@us.ibm.com Date: Thu, 13 Feb 2020 12:24:41 -0800 Message-Id: <20200213202442.19674-2-dwilder@us.ibm.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213202442.19674-1-dwilder@us.ibm.com> References: <20200213202442.19674-1-dwilder@us.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-13_08:2020-02-12, 2020-02-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 suspectscore=0 mlxlogscore=682 spamscore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002130143 Subject: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
add travis ci support for ppc64le
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/iol-testing | success | Testing PASS |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/Intel-compilation | fail | apply issues |
Commit Message
David Wilder
Feb. 13, 2020, 8:24 p.m. UTC
- Memory requirements are larger for ppc64le due to a higher RTE_MAX_LCORE value. - The --no-huge option requires iova-mode=VA. On ppc64le iova-mode defaults to PA therefor VA mode must be explicitly set. Signed-off-by: David Wilder <dwilder@us.ibm.com> Reviewed-by: David Christensen <drc@linux.vnet.ibm.com> --- devtools/test-null.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
13/02/2020 21:24, David Wilder: > - The --no-huge option requires iova-mode=VA. > On ppc64le iova-mode defaults to PA therefor > VA mode must be explicitly set. Should we make VA mode automatic when using --no-huge? Should we log an error message when using --no-huge with PA mode?
On 2020-02-13 12:32, Thomas Monjalon wrote: > 13/02/2020 21:24, David Wilder: >> - The --no-huge option requires iova-mode=VA. >> On ppc64le iova-mode defaults to PA therefor >> VA mode must be explicitly set. > > Should we make VA mode automatic when using --no-huge? > Should we log an error message when using --no-huge with PA mode? Logging a messages sounds like a good idea. Ignoring the users request of iova-mode=PA (in the case of x86) and just switching modes would be bad.
13/02/2020 21:58, dwilder: > On 2020-02-13 12:32, Thomas Monjalon wrote: > > 13/02/2020 21:24, David Wilder: > >> - The --no-huge option requires iova-mode=VA. > >> On ppc64le iova-mode defaults to PA therefor > >> VA mode must be explicitly set. > > > > Should we make VA mode automatic when using --no-huge? > > Should we log an error message when using --no-huge with PA mode? > > Logging a messages sounds like a good idea. Ignoring the users request > of iova-mode=PA (in the case of x86) and just switching modes would be > bad. Yes, I mean for ppc64, if --no-huge is specified, would you like to change the default to VA mode?
On 2020-02-13 14:17, Thomas Monjalon wrote: > 13/02/2020 21:58, dwilder: >> On 2020-02-13 12:32, Thomas Monjalon wrote: >> > 13/02/2020 21:24, David Wilder: >> >> - The --no-huge option requires iova-mode=VA. >> >> On ppc64le iova-mode defaults to PA therefor >> >> VA mode must be explicitly set. >> > >> > Should we make VA mode automatic when using --no-huge? >> > Should we log an error message when using --no-huge with PA mode? >> >> Logging a messages sounds like a good idea. Ignoring the users >> request >> of iova-mode=PA (in the case of x86) and just switching modes would be >> bad. > > Yes, I mean for ppc64, if --no-huge is specified, > would you like to change the default to VA mode? OK, that would be better. I will switch to VA when --no-huge is set (ppc64 only). Add log messages if PA is selected with --no-huge (all arches).
On Fri, Feb 14, 2020 at 12:22 AM dwilder <dwilder@us.ibm.com> wrote: > > On 2020-02-13 14:17, Thomas Monjalon wrote: > > 13/02/2020 21:58, dwilder: > >> On 2020-02-13 12:32, Thomas Monjalon wrote: > >> > 13/02/2020 21:24, David Wilder: > >> >> - The --no-huge option requires iova-mode=VA. > >> >> On ppc64le iova-mode defaults to PA therefor > >> >> VA mode must be explicitly set. > >> > > >> > Should we make VA mode automatic when using --no-huge? > >> > Should we log an error message when using --no-huge with PA mode? > >> > >> Logging a messages sounds like a good idea. Ignoring the users > >> request > >> of iova-mode=PA (in the case of x86) and just switching modes would be > >> bad. > > > > Yes, I mean for ppc64, if --no-huge is specified, > > would you like to change the default to VA mode? > > OK, that would be better. > I will switch to VA when --no-huge is set (ppc64 only). With no-huge, we can't ensure the physical addresses won't change (might be different if we locked the pages in memory... but not possible and/or not handled in eal afaics). This limitation is generic, not arch specific. > Add log messages if PA is selected with --no-huge (all arches).
diff --git a/devtools/test-null.sh b/devtools/test-null.sh index 548de8113..85952d1dc 100755 --- a/devtools/test-null.sh +++ b/devtools/test-null.sh @@ -27,6 +27,6 @@ else fi (sleep 1 && echo stop) | -$testpmd -c $coremask --no-huge -m 20 \ +$testpmd -c $coremask --no-huge -m 30 --iova-mode=va \ $libs -w 0:0.0 --vdev net_null1 --vdev net_null2 $eal_options -- \ --no-mlockall --total-num-mbufs=2048 $testpmd_options -ia