diff mbox series

bpf: properly install headers in meson build

Message ID 202001272140.00RLeVmL031759@lectura.cs.arizona.edu (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series bpf: properly install headers in meson build |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance fail Performance Testing issues
ci/Intel-compilation fail apply issues

Commit Message

Junxiao Shi Jan. 27, 2020, 9:38 p.m. UTC 
  Previously, when librte_bpf is built with meson+ninja, its
headers such as bpf_def is not installed to the system.
This commit fixes this problem.

Fixes: 94972f3 ("bpf: add BPF loading and execution framework")

Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
---
 lib/librte_bpf/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson Jan. 28, 2020, 1:51 p.m. UTC | #1 
On Mon, Jan 27, 2020 at 02:38:00PM -0700, Junxiao Shi wrote:
> Previously, when librte_bpf is built with meson+ninja, its
> headers such as bpf_def is not installed to the system.
> This commit fixes this problem.
> 
> Fixes: 94972f3 ("bpf: add BPF loading and execution framework")
> 
> Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
> ---
>  lib/librte_bpf/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_bpf/meson.build b/lib/librte_bpf/meson.build
> index 13fc02d..52cfaf9 100644
> --- a/lib/librte_bpf/meson.build
> +++ b/lib/librte_bpf/meson.build
> @@ -14,7 +14,7 @@ elif dpdk_conf.has('RTE_ARCH_ARM64')
>  	sources += files('bpf_jit_arm64.c')
>  endif
>  
> -install_headers = files('bpf_def.h',
> +install_headers('bpf_def.h',
>  			'rte_bpf.h',
>  			'rte_bpf_ethdev.h')
>  
Yes, good catch.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon Feb. 6, 2020, 2:29 a.m. UTC | #2 
28/01/2020 14:51, Bruce Richardson:
> On Mon, Jan 27, 2020 at 02:38:00PM -0700, Junxiao Shi wrote:
> > Previously, when librte_bpf is built with meson+ninja, its
> > headers such as bpf_def is not installed to the system.
> > This commit fixes this problem.
> > 
> > Fixes: 94972f3 ("bpf: add BPF loading and execution framework")
> > 
> > Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
> > ---
> > -install_headers = files('bpf_def.h',
> > +install_headers('bpf_def.h',
> >  			'rte_bpf.h',
> >  			'rte_bpf_ethdev.h')
> >  
> Yes, good catch.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/lib/librte_bpf/meson.build b/lib/librte_bpf/meson.build
index 13fc02d..52cfaf9 100644
--- a/lib/librte_bpf/meson.build
+++ b/lib/librte_bpf/meson.build
@@ -14,7 +14,7 @@  elif dpdk_conf.has('RTE_ARCH_ARM64')
 	sources += files('bpf_jit_arm64.c')
 endif
 
-install_headers = files('bpf_def.h',
+install_headers('bpf_def.h',
 			'rte_bpf.h',
 			'rte_bpf_ethdev.h')