[v3,1/6] kernel/linux/kni: fix meson warning about console keyword
Checks
Commit Message
Since kni no longer includes the ethtool code and so is faster to build, we
no longer need the console parameter to have incremental screen updates as
it builds. Therefore, we drop the keyword which removes the warning.
Fixes: b78f32cff94d ("kni: support meson build")
Cc: bluca@debian.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Aaron Conole <aconole@redhat.com>
---
kernel/linux/kni/meson.build | 1 -
1 file changed, 1 deletion(-)
Comments
On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Since kni no longer includes the ethtool code and so is faster to build, we
> no longer need the console parameter to have incremental screen updates as
> it builds. Therefore, we drop the keyword which removes the warning.
>
> Fixes: b78f32cff94d ("kni: support meson build")
> Cc: bluca@debian.org
Since this is linked to kni ethtool stuff removed from 19.11, I would
go with a Cc: stable@dpdk.org.
Then stable maintainers can ignore for everything but 19.11 ?
--
David Marchand
On 09/01/2020 18:02, David Marchand wrote:
> On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
>>
>> Since kni no longer includes the ethtool code and so is faster to build, we
>> no longer need the console parameter to have incremental screen updates as
>> it builds. Therefore, we drop the keyword which removes the warning.
>>
>> Fixes: b78f32cff94d ("kni: support meson build")
>> Cc: bluca@debian.org
>
> Since this is linked to kni ethtool stuff removed from 19.11, I would
> go with a Cc: stable@dpdk.org.
> Then stable maintainers can ignore for everything but 19.11 ?
>
+1
>
> --
> David Marchand
>
@@ -23,7 +23,6 @@ custom_target('rte_kni',
' -I' + meson.current_source_dir(),
'modules'],
depends: kni_mkfile,
- console: true,
install: true,
install_dir: kernel_dir + '/extra/dpdk',
build_by_default: get_option('enable_kmods'))