diff mbox series

net/mlx5: fix use of wrong compilation directive

Message ID 054e73defb9f60739601ec5cfd965141db04552b.1572190441.git.dekelp@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx5: fix use of wrong compilation directive |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation fail Compilation issues

Commit Message

Dekel Peled Oct. 27, 2019, 3:33 p.m. UTC 
  Glue function mlx5_glue_devx_qp_query() uses wrong directive
HAVE_IBV_DEVX_ASYNC by mistake.
This patch replaces the directive to HAVE_IBV_DEVX_OBJ, as required.

Fixes: 62d6f70f30f4 ("net/mlx5: add glue for queue query via DevX")
Cc: stable@dpdk.org

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 drivers/net/mlx5/mlx5_glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Slava Ovsiienko Oct. 27, 2019, 4:04 p.m. UTC | #1 
> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Sunday, October 27, 2019 17:33
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix use of wrong compilation directive
> 
> Glue function mlx5_glue_devx_qp_query() uses wrong directive
> HAVE_IBV_DEVX_ASYNC by mistake.
> This patch replaces the directive to HAVE_IBV_DEVX_OBJ, as required.
> 
> Fixes: 62d6f70f30f4 ("net/mlx5: add glue for queue query via DevX")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

> ---
>  drivers/net/mlx5/mlx5_glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c
> index b5aab52..58c9a82 100644
> --- a/drivers/net/mlx5/mlx5_glue.c
> +++ b/drivers/net/mlx5/mlx5_glue.c
> @@ -976,7 +976,7 @@
>  			const void *in, size_t inlen,
>  			void *out, size_t outlen)
>  {
> -#ifdef HAVE_IBV_DEVX_ASYNC
> +#ifdef HAVE_IBV_DEVX_OBJ
>  	return mlx5dv_devx_qp_query(qp, in, inlen, out, outlen);  #else
>  	(void)qp;
> --
> 1.8.3.1
Matan Azrad Oct. 28, 2019, 6:57 a.m. UTC | #2 
From: Slava Ovsiienko
> > -----Original Message-----
> > From: Dekel Peled <dekelp@mellanox.com>
> > Sent: Sunday, October 27, 2019 17:33
> > To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> > <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> > Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org; stable@dpdk.org
> > Subject: [PATCH] net/mlx5: fix use of wrong compilation directive
> >
> > Glue function mlx5_glue_devx_qp_query() uses wrong directive
> > HAVE_IBV_DEVX_ASYNC by mistake.
> > This patch replaces the directive to HAVE_IBV_DEVX_OBJ, as required.
> >
> > Fixes: 62d6f70f30f4 ("net/mlx5: add glue for queue query via DevX")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
> 
> > ---
> >  drivers/net/mlx5/mlx5_glue.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_glue.c
> > b/drivers/net/mlx5/mlx5_glue.c index b5aab52..58c9a82 100644
> > --- a/drivers/net/mlx5/mlx5_glue.c
> > +++ b/drivers/net/mlx5/mlx5_glue.c
> > @@ -976,7 +976,7 @@
> >  			const void *in, size_t inlen,
> >  			void *out, size_t outlen)
> >  {
> > -#ifdef HAVE_IBV_DEVX_ASYNC
> > +#ifdef HAVE_IBV_DEVX_OBJ
> >  	return mlx5dv_devx_qp_query(qp, in, inlen, out, outlen);  #else
> >  	(void)qp;
> > --
> > 1.8.3.1
Raslan Darawsheh Oct. 29, 2019, 8:34 a.m. UTC | #3 
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Sunday, October 27, 2019 5:33 PM
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix use of wrong compilation directive
> 
> Glue function mlx5_glue_devx_qp_query() uses wrong directive
> HAVE_IBV_DEVX_ASYNC by mistake.
> This patch replaces the directive to HAVE_IBV_DEVX_OBJ, as required.
> 
> Fixes: 62d6f70f30f4 ("net/mlx5: add glue for queue query via DevX")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c
index b5aab52..58c9a82 100644
--- a/drivers/net/mlx5/mlx5_glue.c
+++ b/drivers/net/mlx5/mlx5_glue.c
@@ -976,7 +976,7 @@ 
 			const void *in, size_t inlen,
 			void *out, size_t outlen)
 {
-#ifdef HAVE_IBV_DEVX_ASYNC
+#ifdef HAVE_IBV_DEVX_OBJ
 	return mlx5dv_devx_qp_query(qp, in, inlen, out, outlen);
 #else
 	(void)qp;