diff mbox series

net/mlx: remove pedantic definition for icc

Message ID 1571819023-11692-1-git-send-email-rasland@mellanox.com (mailing list archive)
State Superseded, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx: remove pedantic definition for icc |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed

Commit Message

Raslan Darawsheh Oct. 23, 2019, 8:23 a.m. UTC 
  Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
 drivers/net/mlx4/Makefile | 5 ++++-
 drivers/net/mlx5/Makefile | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

Comments

Slava Ovsiienko Oct. 23, 2019, 8:32 a.m. UTC | #1 
> -----Original Message-----
> From: Raslan Darawsheh <rasland@mellanox.com>
> Sent: Wednesday, October 23, 2019 11:24
> To: Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/mlx: remove pedantic definition for icc
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

PS. The further considering of PEDANTIC removal at all is supposed.

> ---
>  drivers/net/mlx4/Makefile | 5 ++++-
>  drivers/net/mlx5/Makefile | 5 ++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile index
> 25d7c75..0abdc8d 100644
> --- a/drivers/net/mlx4/Makefile
> +++ b/drivers/net/mlx4/Makefile
> @@ -67,7 +67,10 @@ endif
> 
>  # User-defined CFLAGS.
>  ifeq ($(CONFIG_RTE_LIBRTE_MLX4_DEBUG),y)
> -CFLAGS += -pedantic -UNDEBUG -DPEDANTIC
> +CFLAGS += -pedantic -UNDEBUG
> +ifneq ($(CONFIG_RTE_TOOLCHAIN), "icc")
> +CFLAGS += -DPEDANTIC
> +endif
>  AUTO_CONFIG_CFLAGS += -Wno-pedantic
>  else
>  CFLAGS += -DNDEBUG -UPEDANTIC
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile index
> 04de93a..0369ee6 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -83,7 +83,10 @@ endif
> 
>  # User-defined CFLAGS.
>  ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DEBUG),y)
> -CFLAGS += -pedantic -UNDEBUG -DPEDANTIC
> +CFLAGS += -pedantic -UNDEBUGi
> +ifneq ($(CONFIG_RTE_TOOLCHAIN), "icc")
> +CFLAGS += -DPEDANTIC
> +endif
>  AUTO_CONFIG_CFLAGS += -Wno-pedantic
>  else
>  CFLAGS += -DNDEBUG -UPEDANTIC
> --
> 2.7.4
diff mbox series

Patch

diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
index 25d7c75..0abdc8d 100644
--- a/drivers/net/mlx4/Makefile
+++ b/drivers/net/mlx4/Makefile
@@ -67,7 +67,10 @@  endif
 
 # User-defined CFLAGS.
 ifeq ($(CONFIG_RTE_LIBRTE_MLX4_DEBUG),y)
-CFLAGS += -pedantic -UNDEBUG -DPEDANTIC
+CFLAGS += -pedantic -UNDEBUG
+ifneq ($(CONFIG_RTE_TOOLCHAIN), "icc")
+CFLAGS += -DPEDANTIC
+endif
 AUTO_CONFIG_CFLAGS += -Wno-pedantic
 else
 CFLAGS += -DNDEBUG -UPEDANTIC
diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
index 04de93a..0369ee6 100644
--- a/drivers/net/mlx5/Makefile
+++ b/drivers/net/mlx5/Makefile
@@ -83,7 +83,10 @@  endif
 
 # User-defined CFLAGS.
 ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DEBUG),y)
-CFLAGS += -pedantic -UNDEBUG -DPEDANTIC
+CFLAGS += -pedantic -UNDEBUGi
+ifneq ($(CONFIG_RTE_TOOLCHAIN), "icc")
+CFLAGS += -DPEDANTIC
+endif
 AUTO_CONFIG_CFLAGS += -Wno-pedantic
 else
 CFLAGS += -DNDEBUG -UPEDANTIC