[v7,10/11] vhost: add APIs to rte_vhost version map

Message ID 20190917145234.16951-11-jin.yu@intel.com
State Deferred
Headers show
Series
  • vhost: support inflight share memory protocol feature
Related show

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/checkpatch warning coding style issues

Commit Message

Jin Yu Sept. 17, 2019, 2:52 p.m.
add all the added experimental APIs which are in
the rte_vhost.h to the rte_vhost_version.map

Signed-off-by: Lin Li <lilin24@baidu.com>
Signed-off-by: Xun Ni <nixun@baidu.com>
Signed-off-by: Yu Zhang <zhangyu31@baidu.com>
Signed-off-by: Jin Yu <jin.yu@intel.com>
---
 lib/librte_vhost/rte_vhost_version.map | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Tiwei Bie Sept. 18, 2019, 6:05 a.m. | #1
On Tue, Sep 17, 2019 at 10:52:33PM +0800, JinYu wrote:
> add all the added experimental APIs which are in
> the rte_vhost.h to the rte_vhost_version.map

Symbols should be added to the .map file in the same
patch which introduces them. Otherwise that patch will
break the build.

Thanks,
Tiwei

> 
> Signed-off-by: Lin Li <lilin24@baidu.com>
> Signed-off-by: Xun Ni <nixun@baidu.com>
> Signed-off-by: Yu Zhang <zhangyu31@baidu.com>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
>  lib/librte_vhost/rte_vhost_version.map | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> index 5f1d4a75c..c8e14055b 100644
> --- a/lib/librte_vhost/rte_vhost_version.map
> +++ b/lib/librte_vhost/rte_vhost_version.map
> @@ -87,4 +87,13 @@ EXPERIMENTAL {
>  	rte_vdpa_relay_vring_used;
>  	rte_vhost_extern_callback_register;
>  	rte_vhost_driver_set_protocol_features;
> +	rte_vhost_vq_is_packed;
> +	rte_vhost_get_vhost_ring_inflight;
> +	rte_vhost_get_vring_base_from_inflight;
> +	rte_vhost_set_inflight_desc_split;
> +	rte_vhost_set_inflight_desc_packed;
> +	rte_vhost_set_last_inflight_io_split;
> +	rte_vhost_set_last_inflight_io_packed;
> +	rte_vhost_clr_inflight_desc_split;
> +	rte_vhost_clr_inflight_desc_packed;
>  };
> -- 
> 2.17.2
>
Jin Yu Sept. 18, 2019, 6:31 a.m. | #2
> -----Original Message-----
> From: Bie, Tiwei
> Sent: Wednesday, September 18, 2019 2:05 PM
> To: Yu, Jin <jin.yu@intel.com>
> Cc: dev@dpdk.org; Liu, Changpeng <changpeng.liu@intel.com>;
> maxime.coquelin@redhat.com; Wang, Zhihong <zhihong.wang@intel.com>;
> Lin Li <lilin24@baidu.com>; Xun Ni <nixun@baidu.com>; Yu Zhang
> <zhangyu31@baidu.com>
> Subject: Re: [PATCH v7 10/11] vhost: add APIs to rte_vhost version map
> 
> On Tue, Sep 17, 2019 at 10:52:33PM +0800, JinYu wrote:
> > add all the added experimental APIs which are in the rte_vhost.h to
> > the rte_vhost_version.map
> 
> Symbols should be added to the .map file in the same patch which
> introduces them. Otherwise that patch will break the build.

Ok, Thanks. I will fix it soon.

Thanks,
Jin
> 
> Thanks,
> Tiwei
> 
> >
> > Signed-off-by: Lin Li <lilin24@baidu.com>
> > Signed-off-by: Xun Ni <nixun@baidu.com>
> > Signed-off-by: Yu Zhang <zhangyu31@baidu.com>
> > Signed-off-by: Jin Yu <jin.yu@intel.com>
> > ---
> >  lib/librte_vhost/rte_vhost_version.map | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/lib/librte_vhost/rte_vhost_version.map
> > b/lib/librte_vhost/rte_vhost_version.map
> > index 5f1d4a75c..c8e14055b 100644
> > --- a/lib/librte_vhost/rte_vhost_version.map
> > +++ b/lib/librte_vhost/rte_vhost_version.map
> > @@ -87,4 +87,13 @@ EXPERIMENTAL {
> >  	rte_vdpa_relay_vring_used;
> >  	rte_vhost_extern_callback_register;
> >  	rte_vhost_driver_set_protocol_features;
> > +	rte_vhost_vq_is_packed;
> > +	rte_vhost_get_vhost_ring_inflight;
> > +	rte_vhost_get_vring_base_from_inflight;
> > +	rte_vhost_set_inflight_desc_split;
> > +	rte_vhost_set_inflight_desc_packed;
> > +	rte_vhost_set_last_inflight_io_split;
> > +	rte_vhost_set_last_inflight_io_packed;
> > +	rte_vhost_clr_inflight_desc_split;
> > +	rte_vhost_clr_inflight_desc_packed;
> >  };
> > --
> > 2.17.2
> >

Patch

diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
index 5f1d4a75c..c8e14055b 100644
--- a/lib/librte_vhost/rte_vhost_version.map
+++ b/lib/librte_vhost/rte_vhost_version.map
@@ -87,4 +87,13 @@  EXPERIMENTAL {
 	rte_vdpa_relay_vring_used;
 	rte_vhost_extern_callback_register;
 	rte_vhost_driver_set_protocol_features;
+	rte_vhost_vq_is_packed;
+	rte_vhost_get_vhost_ring_inflight;
+	rte_vhost_get_vring_base_from_inflight;
+	rte_vhost_set_inflight_desc_split;
+	rte_vhost_set_inflight_desc_packed;
+	rte_vhost_set_last_inflight_io_split;
+	rte_vhost_set_last_inflight_io_packed;
+	rte_vhost_clr_inflight_desc_split;
+	rte_vhost_clr_inflight_desc_packed;
 };