diff mbox series

config: set RTE_KNI_PREEMPT_DEFAULT in meson

Message ID 20190916100828.38199-1-iryzhov@nfware.com (mailing list archive)
State Accepted, archived
Headers
Series config: set RTE_KNI_PREEMPT_DEFAULT in meson |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-dpdk_compile_ovs success Compile Testing PASS
ci/iol-dpdk_compile success Compile Testing PASS
ci/iol-dpdk_compile_spdk success Compile Testing PASS
ci/intel-Performance success Performance Testing PASS
ci/mellanox-Performance success Performance Testing PASS

Commit Message

Igor Ryzhov Sept. 16, 2019, 10:08 a.m. UTC 
  Same behavior as in make build system.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
---
 config/rte_config.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Igor Ryzhov Sept. 17, 2019, 7:11 p.m. UTC | #1 
CCing Bruce, maintainer of the meson build system.

It's a simple patch to make meson behavior consistent with make behavior.

CONFIG_RTE_KNI_PREEMPT_DEFAULT is set to "y" in config/common_base,
so we need to set RTE_KNI_PREEMPT_DEFAULT to 1 in meson.

Best regards,
Igor

On Mon, Sep 16, 2019 at 1:08 PM Igor Ryzhov <iryzhov@nfware.com> wrote:

> Same behavior as in make build system.
>
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> ---
>  config/rte_config.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/config/rte_config.h b/config/rte_config.h
> index 0bbbe274f..e6a35a170 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -98,6 +98,9 @@
>  #define RTE_SCHED_PORT_N_GRINDERS 8
>  #undef RTE_SCHED_VECTOR
>
> +/* rte_kni defines */
> +#define RTE_KNI_PREEMPT_DEFAULT 1
> +
>  /****** driver defines ********/
>
>  /* QuickAssist device */
> --
> 2.23.0
>
>
Bruce Richardson Sept. 18, 2019, 10:32 a.m. UTC | #2 
On Tue, Sep 17, 2019 at 10:11:04PM +0300, Igor Ryzhov wrote:
>    CCing Bruce, maintainer of the meson build system.
>    It's a simple patch to make meson behavior consistent with make
>    behavior.
>    CONFIG_RTE_KNI_PREEMPT_DEFAULT is set to "y" in config/common_base,
>    so we need to set RTE_KNI_PREEMPT_DEFAULT to 1 in meson.
>    Best regards,
>    Igor
> 
No objection from me.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

>    On Mon, Sep 16, 2019 at 1:08 PM Igor Ryzhov <[1]iryzhov@nfware.com>
>    wrote:
> 
>      Same behavior as in make build system.
>      Signed-off-by: Igor Ryzhov <[2]iryzhov@nfware.com>
>      ---
>       config/rte_config.h | 3 +++
>       1 file changed, 3 insertions(+)
>      diff --git a/config/rte_config.h b/config/rte_config.h
>      index 0bbbe274f..e6a35a170 100644
>      --- a/config/rte_config.h
>      +++ b/config/rte_config.h
>      @@ -98,6 +98,9 @@
>       #define RTE_SCHED_PORT_N_GRINDERS 8
>       #undef RTE_SCHED_VECTOR
>      +/* rte_kni defines */
>      +#define RTE_KNI_PREEMPT_DEFAULT 1
>      +
>       /****** driver defines ********/
>       /* QuickAssist device */
>      --
>      2.23.0
> 
> References
> 
>    1. mailto:iryzhov@nfware.com
>    2. mailto:iryzhov@nfware.com
Thomas Monjalon Oct. 23, 2019, 11:14 p.m. UTC | #3 
18/09/2019 12:32, Bruce Richardson:
> On Tue, Sep 17, 2019 at 10:11:04PM +0300, Igor Ryzhov wrote:
> >    CCing Bruce, maintainer of the meson build system.
> >    It's a simple patch to make meson behavior consistent with make
> >    behavior.
> >    CONFIG_RTE_KNI_PREEMPT_DEFAULT is set to "y" in config/common_base,
> >    so we need to set RTE_KNI_PREEMPT_DEFAULT to 1 in meson.
> >    Best regards,
> >    Igor
> > 
> No objection from me.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/config/rte_config.h b/config/rte_config.h
index 0bbbe274f..e6a35a170 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -98,6 +98,9 @@ 
 #define RTE_SCHED_PORT_N_GRINDERS 8
 #undef RTE_SCHED_VECTOR
 
+/* rte_kni defines */
+#define RTE_KNI_PREEMPT_DEFAULT 1
+
 /****** driver defines ********/
 
 /* QuickAssist device */