Message ID | 1568306586-27831-44-git-send-email-arybchenko@solarflare.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 504A71F05F; Thu, 12 Sep 2019 18:45:11 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 7C5531EF70 for <dev@dpdk.org>; Thu, 12 Sep 2019 18:43:41 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 84F0DB00053; Thu, 12 Sep 2019 16:43:40 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Sep 2019 09:43:29 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 12 Sep 2019 09:43:28 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x8CGhRGH023794; Thu, 12 Sep 2019 17:43:27 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 8B4721613D1; Thu, 12 Sep 2019 17:43:27 +0100 (BST) From: Andrew Rybchenko <arybchenko@solarflare.com> To: Bernard Iremonger <bernard.iremonger@intel.com> CC: <dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> Date: Thu, 12 Sep 2019 17:42:54 +0100 Message-ID: <1568306586-27831-44-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1568306586-27831-1-git-send-email-arybchenko@solarflare.com> References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com> <1568306586-27831-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24906.005 X-TM-AS-Result: No-1.172400-4.000000-10 X-TMASE-MatchedRID: bPLNq/JhYEHDOgXZFRFV8+b3p4cnIXGNAPiR4btCEeZ+SLLtNOiBhlMe 5Blkpry7rdoLblq9S5qnJ7eS8LcE2drY50f51tjbsFSKfGPIprXGYnoF/CTeZZsoi2XrUn/Jn6K dMrRsL14qtq5d3cxkNVs+Qk8spjzLjmlFwLshTdzb2GqNcJwieW0PBVq1Mvr0p/RMRakFfgYQrj lWrwTB6cOgQUTVrmWv93Np+E7WwfbAyIfoBFTi4lDEPISZ/SOkOKBkFAm8GOUPoO5ncI6OuehbQ 2QpmASdyky8P5TYMPI= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--1.172400-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24906.005 X-MDID: 1568306621-W1qJqgh0hCyf Subject: [dpdk-dev] [PATCH v4 43/54] examples/flow_classify: check status of getting ethdev info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
ethdev: change rte_eth_dev_info_get() return value to int
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Andrew Rybchenko
Sept. 12, 2019, 4:42 p.m. UTC
From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/flow_classify according to its new return type. Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> --- examples/flow_classify/flow_classify.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
Comments
> -----Original Message----- > From: Andrew Rybchenko [mailto:arybchenko@solarflare.com] > Sent: Thursday, September 12, 2019 5:43 PM > To: Iremonger, Bernard <bernard.iremonger@intel.com> > Cc: dev@dpdk.org; Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> > Subject: [PATCH v4 43/54] examples/flow_classify: check status of getting > ethdev info > > From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> > > rte_eth_dev_info_get() return value was changed from void to int, so this > patch modify rte_eth_dev_info_get() usage across examples/flow_classify > according to its new return type. > > Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
diff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c index bc7f43ea9..2130c13d8 100644 --- a/examples/flow_classify/flow_classify.c +++ b/examples/flow_classify/flow_classify.c @@ -202,7 +202,13 @@ port_init(uint8_t port, struct rte_mempool *mbuf_pool) if (!rte_eth_dev_is_valid_port(port)) return -1; - rte_eth_dev_info_get(port, &dev_info); + retval = rte_eth_dev_info_get(port, &dev_info); + if (retval != 0) { + printf("Error during getting device (port %u) info: %s\n", + port, strerror(-retval)); + return retval; + } + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) port_conf.txmode.offloads |= DEV_TX_OFFLOAD_MBUF_FAST_FREE;