From patchwork Wed Aug 14 06:07:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Xiaoyun" X-Patchwork-Id: 57674 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8D2C1BE89; Wed, 14 Aug 2019 08:35:08 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3526E1BDAC; Wed, 14 Aug 2019 08:35:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 23:35:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,384,1559545200"; d="scan'208";a="327907133" Received: from dpdk-xiaoyunl.sh.intel.com ([10.67.110.193]) by orsmga004.jf.intel.com with ESMTP; 13 Aug 2019 23:35:03 -0700 From: Xiaoyun Li To: jingjing.wu@intel.com, xiaolong.ye@intel.com Cc: dev@dpdk.org, Xiaoyun Li , stable@dpdk.org Date: Wed, 14 Aug 2019 14:07:25 +0800 Message-Id: <20190814060725.43129-1-xiaoyun.li@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] examples/ntb: fix resource leaks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Resource file was not freed or pointed-to in fseek/ftell. This patch fixed this issue which is found by coverity scan. Coverity issue: 347277 Fixes: 440af660ff83 ("examples/ntb: fix error handling") Cc: stable@dpdk.org Signed-off-by: Xiaoyun Li Reviewed-by: Xiaolong Ye --- examples/ntb/ntb_fwd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index f8c970cdb..bf8a73547 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -127,11 +127,13 @@ cmd_sendfile_parsed(void *parsed_result, if (fseek(file, 0, SEEK_END) < 0) { printf("Fail to get file size.\n"); + fclose(file); return; } size = ftell(file); if (fseek(file, 0, SEEK_SET) < 0) { printf("Fail to get file size.\n"); + fclose(file); return; }