From patchwork Tue Aug 13 02:07:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiwei Bie X-Patchwork-Id: 57636 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19A4C1BE8A; Tue, 13 Aug 2019 04:09:53 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 43A441B952; Tue, 13 Aug 2019 04:09:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 19:09:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="327540045" Received: from dpdk-virtio-tbie-2.sh.intel.com ([10.67.104.71]) by orsmga004.jf.intel.com with ESMTP; 12 Aug 2019 19:09:48 -0700 From: Tiwei Bie To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org Cc: stable@dpdk.org Date: Tue, 13 Aug 2019 10:07:25 +0800 Message-Id: <20190813020730.10038-2-tiwei.bie@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190813020730.10038-1-tiwei.bie@intel.com> References: <20190813020730.10038-1-tiwei.bie@intel.com> Subject: [dpdk-dev] [PATCH 1/6] net/virtio: remove remaining simple Tx related stuff X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The simple Tx path in virtio has been removed in below commit. This patch removes an undefined function declaration of simple Tx and all related descriptions in the doc. Fixes: 57f818963d80 ("net/virtio: remove simple Tx path") Cc: stable@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- doc/guides/nics/virtio.rst | 15 ++------------- drivers/net/virtio/virtio_ethdev.h | 3 --- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 2ae875cb4..da9cd6ba6 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -201,7 +201,7 @@ The packet transmission flow is: Virtio PMD Rx/Tx Callbacks -------------------------- -Virtio driver has 4 Rx callbacks and 3 Tx callbacks. +Virtio driver has 4 Rx callbacks and 2 Tx callbacks. Rx callbacks: @@ -223,9 +223,6 @@ Tx callbacks: #. ``virtio_xmit_pkts``: Regular version. -#. ``virtio_xmit_pkts_simple``: - Vector version fixes the available ring indexes to optimize performance. - #. ``virtio_xmit_pkts_inorder``: In-order version. @@ -239,25 +236,17 @@ By default, the non-vector callbacks are used: Vector callbacks will be used when: -* ``txmode.offloads`` is set to ``0x0``, which implies: - - * Single segment is specified. - - * No offload support is needed. - * Mergeable Rx buffers is disabled. The corresponding callbacks are: * For Rx: ``virtio_recv_pkts_vec``. -* For Tx: ``virtio_xmit_pkts_simple``. - Example of using the vector version of the virtio poll mode driver in ``testpmd``:: - testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1 + testpmd -l 0-2 -n 4 -- -i --rxq=1 --txq=1 --nb-cores=1 In-order callbacks only work on simulated virtio user vdev. diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 20d331795..a10111758 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virtio_ethdev.h @@ -103,9 +103,6 @@ uint16_t virtio_xmit_pkts_inorder(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts); -uint16_t virtio_xmit_pkts_simple(void *tx_queue, struct rte_mbuf **tx_pkts, - uint16_t nb_pkts); - int eth_virtio_dev_init(struct rte_eth_dev *eth_dev); void virtio_interrupt_handler(void *param);