diff mbox series

[v2] net/e1000: fix rss_conf sizeof argument

Message ID 1565166705-4710-1-git-send-email-zhang.congwen@zte.com.cn (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series [v2] net/e1000: fix rss_conf sizeof argument |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/iol-Compile-Testing success Compile Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Congwen Zhang Aug. 7, 2019, 8:31 a.m. UTC 
  The type of rss_conf is struct igb_rte_flow_rss_conf *,
 not struct rte_eth_rss_conf *.

Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")

Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
---
 drivers/net/e1000/igb_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xiaolong Ye Oct. 24, 2019, 7:44 a.m. UTC | #1 
On 08/07, Congwen Zhang wrote:
>The type of rss_conf is struct igb_rte_flow_rss_conf *,
> not struct rte_eth_rss_conf *.
>
>Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")
>
>Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
>---
> drivers/net/e1000/igb_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c
>index 4e0b38f..0d2703d 100644
>--- a/drivers/net/e1000/igb_flow.c
>+++ b/drivers/net/e1000/igb_flow.c
>@@ -1374,7 +1374,7 @@
> 	index++;
> 	NEXT_ITEM_OF_ACTION(act, actions, index);
> 	if (act->type != RTE_FLOW_ACTION_TYPE_END) {
>-		memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
>+		memset(rss_conf, 0, sizeof(struct igb_rte_flow_rss_conf));
> 		rte_flow_error_set(error, EINVAL,
> 			RTE_FLOW_ERROR_TYPE_ACTION,
> 			act, "Not supported action.");
>-- 
>1.8.3.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel. Thanks.
diff mbox series

Patch

diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c
index 4e0b38f..0d2703d 100644
--- a/drivers/net/e1000/igb_flow.c
+++ b/drivers/net/e1000/igb_flow.c
@@ -1374,7 +1374,7 @@ 
 	index++;
 	NEXT_ITEM_OF_ACTION(act, actions, index);
 	if (act->type != RTE_FLOW_ACTION_TYPE_END) {
-		memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
+		memset(rss_conf, 0, sizeof(struct igb_rte_flow_rss_conf));
 		rte_flow_error_set(error, EINVAL,
 			RTE_FLOW_ERROR_TYPE_ACTION,
 			act, "Not supported action.");