net/memif: fix build error with gcc 9.1
Checks
Commit Message
From: Jerin Jacob <jerinj@marvell.com>
gcc-9 stricter on NULL arguments for printf.
Fix the following build error by avoiding NULL argument to printf.
In file included from drivers/net/memif/memif_socket.c:26:
In function 'memif_socket_create',
inlined from 'memif_socket_init' at net/memif/memif_socket.c:965:12:
net/memif/rte_eth_memif.h:35:2: error: '%s' directive argument is null
[-Werror=format-overflow=]
35 | rte_log(RTE_LOG_ ## level, memif_logtype, \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
36 | "%s(): " fmt "\n", __func__, ##args)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
drivers/net/memif/memif_socket.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
07/08/2019 05:11, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
>
> gcc-9 stricter on NULL arguments for printf.
> Fix the following build error by avoiding NULL argument to printf.
>
> In file included from drivers/net/memif/memif_socket.c:26:
> In function 'memif_socket_create',
> inlined from 'memif_socket_init' at net/memif/memif_socket.c:965:12:
> net/memif/rte_eth_memif.h:35:2: error: '%s' directive argument is null
> [-Werror=format-overflow=]
> 35 | rte_log(RTE_LOG_ ## level, memif_logtype, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 36 | "%s(): " fmt "\n", __func__, ##args)
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks
@@ -918,7 +918,8 @@ memif_socket_create(struct pmd_internals *pmd, char *key, uint8_t listener)
error:
MIF_LOG(ERR, "%s: Failed to setup socket %s: %s",
- rte_vdev_device_name(pmd->vdev), key, strerror(errno));
+ rte_vdev_device_name(pmd->vdev) ?
+ rte_vdev_device_name(pmd->vdev) : "NULL", key, strerror(errno));
if (sock != NULL)
rte_free(sock);
if (sockfd >= 0)