From patchwork Fri Jul 26 16:36:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 57180 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8684C1C4D8; Fri, 26 Jul 2019 18:36:27 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id C90961C4CA for ; Fri, 26 Jul 2019 18:36:23 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id i18so25027123pgl.11 for ; Fri, 26 Jul 2019 09:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nc/Qbf9MC2HHEzp1POCrmoGDiQ9qyu5rVVmOAHLT4Qw=; b=H4Gq/YodXvUfseZbPvcDObtMcvsBthpQTW4/DvVaO1/ZLuH3KAWTdDRqtJiRMSCa8G /5uh5UWJK1GJST+qSR882bqz86LZ3DOiZ10xxwcxJaGYLcIzlMBlEf22LN4pxfiasyyX TrdzDoVW4kizeCJsQHKILgX5KAXYUtLXV2j6gV8earp4GGjXeBcobBvovja0mzDPIF1M /L74KHrPcnD/KP5LvvjTaOq5NRNSMLS02/KP4Ke5S2v3E0A/cIJxGFXnOjvOWcTsbjGx 6ATu31FkRgompHGHPPFEv22lot69B5Un501KKX4LRr0G5PBnBpIwSuzOvekvDmKGWxE3 9HAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nc/Qbf9MC2HHEzp1POCrmoGDiQ9qyu5rVVmOAHLT4Qw=; b=XEh0kleSD9ElDvP7LfqCTnkk34jYRObuJ/SxLLUz/Spe89AZkksU4T8s0g48NRz5S/ sFyQuGyEPAggwlDvmSclDEmdwdwmj54Wy19fYzzpzs+vLFAbGWNsigKduOPdnxRjotRz g5ogJMgBP9oUEqlBAByKq662P1YdMMkgmYIgvQc0nDZ1fsKB7HcXTxMT6QQNNMskUK4U NTqUX5gHR9TASKBW0xJD/z2dmzPQBD7zbOfLGLOj/tkuKcdehr4TC6UHj2sa7lF4QFbQ caonr83Q8DvbpHthOc6qDAT7tBnovjLLMw27uk3sEyVuVinEYlmwsz+iMsMZU4j2VzcU KhTQ== X-Gm-Message-State: APjAAAXUSuiKxkW1hpbtTLOVKAhgRCv6bgmGlbgIwDN4qZNPVzhT83EO 7dDZVWeXARviXJdsWh6S2hzwbXF+ X-Google-Smtp-Source: APXvYqyXYnY2+I99mdaeIGlocqEN0x1+q/z15NY/vLINDyjTtuwdgWnNwcX39IiW+vu5mr2BRncleA== X-Received: by 2002:a17:90a:fa18:: with SMTP id cm24mr96436926pjb.120.1564158982653; Fri, 26 Jul 2019 09:36:22 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m101sm42691781pjb.7.2019.07.26.09.36.21 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 09:36:21 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org Date: Fri, 26 Jul 2019 09:36:17 -0700 Message-Id: <20190726163617.29701-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190726163617.29701-1-stephen@networkplumber.org> References: <20190726163617.29701-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 2/2] mk: fix missing mempool driver registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since mempool driver is now registered during constructor, the mempool driver must always be linked in during shared library build. Otherwise, application will fail because of missing default mbuf pool operations. Fixes: c6b3570f9e14 ("mk: link app with ring mempool by default") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- mk/rte.app.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 3b3156bfcf09..3e4580a2594c 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -87,7 +87,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_RAWDEV) += -lrte_rawdev _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += -lrte_mempool _LDLIBS-$(CONFIG_RTE_LIBRTE_STACK) += -lrte_stack +_LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += --no-as-needed _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -lrte_mempool_ring +_LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += --as-needed _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) += -lrte_mempool_octeontx2 _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI) += -lrte_pci