[v2,1/2] bus: fix missing pci bus with shared library build
diff mbox series

Message ID 20190726163617.29701-2-stephen@networkplumber.org
State New
Delegated to: Thomas Monjalon
Headers show
Series
  • mk: fix build with shared library
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-Compile-Testing success Compile Testing PASS

Commit Message

Stephen Hemminger July 26, 2019, 4:36 p.m. UTC 
If DPDK is built as a shared library, then any application linked
with rte.app.mk will not find any buses (including PCI devices).

This is because the linker will not call the initializers
of the bus libraries since they are not directly called by
application or EAL.

Bugzilla ID: 333
Fixes: c752998b5e2e ("pci: introduce library and driver")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 mk/rte.app.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Patch
diff mbox series 

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index a277c808ed8e..3b3156bfcf09 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -123,6 +123,10 @@  ifneq (,$(findstring y,$(MVEP-y)))
 _LDLIBS-y += -lrte_common_mvep -L$(LIBMUSDK_PATH)/lib -lmusdk
 endif
 
+# Bus devices use constructors to register and therefore
+# need to be always linked in (--whole-archive already enabled)
+_LDLIBS-y += --no-as-needed
+
 ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y)
 _LDLIBS-$(CONFIG_RTE_LIBRTE_COMMON_DPAAX)   += -lrte_common_dpaax
 endif
@@ -137,6 +141,9 @@  ifeq ($(CONFIG_RTE_EAL_VFIO),y)
 _LDLIBS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS)      += -lrte_bus_fslmc
 endif
 
+# drivers are as-needed
+_LDLIBS-y += --as-needed
+
 ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)
 # plugins (link only if static libraries)