[v3] net/mlx5: fix Rx queue release of resources

  Function rxq_release_rq_resources() releases resources of RQ object
created by DevX API.

This patch updates this function to properly clear the released
resources, to avoid repeated release of the same resource.

Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API")

---
v3: Use adequate 'Fixes' reference.
---

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
  

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Wednesday, July 24, 2019 12:05 PM
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources
> 
> Function rxq_release_rq_resources() releases resources of RQ object
> created by DevX API.
> 
> This patch updates this function to properly clear the released resources, to
> avoid repeated release of the same resource.
> 
> Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API")
> 
> ---
> v3: Use adequate 'Fixes' reference.
> ---
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_rxq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index c9df8b0..441f158 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -573,8 +573,10 @@
>  		rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes);
>  		rxq_ctrl->rxq.wqes = NULL;
>  	}
> -	if (rxq_ctrl->wq_umem)
> +	if (rxq_ctrl->wq_umem) {
>  		mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem);
> +		rxq_ctrl->wq_umem = NULL;
> +	}
>  }
> 
>  /**
> --
> 1.8.3.1

Patch applied to dpdk-next-net-mlx,

Kindest regards,
Raslan Darawsheh
  

äùâ àú Outlook òáåø Android<https://aka.ms/ghei36>



îàú: Dekel Peled
ðùìç: éåí øáéòé, 24 áéåìé, 12:05
ðåùà: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources
àì: Yongseok Koh, Slava Ovsiienko, Shahaf Shuler
òåú÷: Ori Kam, dev@dpdk.org


Function rxq_release_rq_resources() releases resources of RQ object
created by DevX API.

This patch updates this function to properly clear the released
resources, to avoid repeated release of the same resource.

Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API")

---
v3: Use adequate 'Fixes' reference.
---

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index c9df8b0..441f158 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -573,8 +573,10 @@
                 rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes);
                 rxq_ctrl->rxq.wqes = NULL;
         }
-       if (rxq_ctrl->wq_umem)
+       if (rxq_ctrl->wq_umem) {
                 mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem);
+               rxq_ctrl->wq_umem = NULL;
+       }
 }

 /**
--
1.8.3.1