[RFC] doc: deprecate legacy code path in ipsec-secgw
diff mbox series

Message ID 1562835937-24141-1-git-send-email-bernard.iremonger@intel.com
State Superseded, archived
Delegated to: akhil goyal
Headers show
Series
  • [RFC] doc: deprecate legacy code path in ipsec-secgw
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Bernard Iremonger July 11, 2019, 9:05 a.m. UTC
All the functionality of the legacy code path in now available in
the librte_ipsec library. It is planned to deprecate the legacy
code path in the 19.11 release and remove the legacy code path in
the 20.02 release.

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Ananyev, Konstantin July 19, 2019, 11:23 a.m. UTC | #1
> 
> All the functionality of the legacy code path in now available in
> the librte_ipsec library. It is planned to deprecate the legacy
> code path in the 19.11 release and remove the legacy code path in
> the 20.02 release.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index a7796f4..258fee8 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -82,3 +82,8 @@ Deprecation Notices
>    to set new power environment if power environment was already initialized.
>    In this case the function will return -1 unless the environment is unset first
>    (using ``rte_power_unset_env``). Other function usage scenarios will not change.
> +
> +* ipsec-secgw: All the ipsec-secgw legacy code path functionality is now
> +  available in the librte_ipsec library. It is planned to deprecate the legacy
> +  code path in the ipsec-secgw application in the 19.11 release and remove it
> +  in the 20.02 release.
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.7.4
Fan Zhang July 19, 2019, 2:55 p.m. UTC | #2
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger
> Sent: Thursday, July 11, 2019 6:06 PM
> To: dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> akhil.goyal@nxp.com
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: [dpdk-dev] [RFC] doc: deprecate legacy code path in ipsec-secgw
> 
> All the functionality of the legacy code path in now available in the
> librte_ipsec library. It is planned to deprecate the legacy code path in the
> 19.11 release and remove the legacy code path in the 20.02 release.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index a7796f4..258fee8 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -82,3 +82,8 @@ Deprecation Notices
>    to set new power environment if power environment was already
> initialized.
>    In this case the function will return -1 unless the environment is unset first
>    (using ``rte_power_unset_env``). Other function usage scenarios will not
> change.
> +
> +* ipsec-secgw: All the ipsec-secgw legacy code path functionality is
> +now
> +  available in the librte_ipsec library. It is planned to deprecate the
> +legacy
> +  code path in the ipsec-secgw application in the 19.11 release and
> +remove it
> +  in the 20.02 release.
> --
> 2.7.4

Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Akhil Goyal July 24, 2019, 9:47 a.m. UTC | #3
Hi Bernard,

> All the functionality of the legacy code path in now available in
> the librte_ipsec library. It is planned to deprecate the legacy
> code path in the 19.11 release and remove the legacy code path in
> the 20.02 release.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index a7796f4..258fee8 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -82,3 +82,8 @@ Deprecation Notices
>    to set new power environment if power environment was already initialized.
>    In this case the function will return -1 unless the environment is unset first
>    (using ``rte_power_unset_env``). Other function usage scenarios will not
> change.
> +
> +* ipsec-secgw: All the ipsec-secgw legacy code path functionality is now
> +  available in the librte_ipsec library. It is planned to deprecate the legacy
> +  code path in the ipsec-secgw application in the 19.11 release and remove it
> +  in the 20.02 release.
> --
Library mode path was impacting the performance on NXP platforms for lookaside mode at the time the library was introduced. Not sure what is the state today. We will evaluate the performance numbers when the actual code will be submitted for review. If the numbers are good we can remove the legacy code path. Apart from this concern,
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

This patch is an RFC patch and generally RFC patches are not merged.
Please send the patch again without the RFC tag, if this patch need to be integrated in this release.
You can take the Acks.

Regards,
Akhil

Patch
diff mbox series

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index a7796f4..258fee8 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -82,3 +82,8 @@  Deprecation Notices
   to set new power environment if power environment was already initialized.
   In this case the function will return -1 unless the environment is unset first
   (using ``rte_power_unset_env``). Other function usage scenarios will not change.
+
+* ipsec-secgw: All the ipsec-secgw legacy code path functionality is now
+  available in the librte_ipsec library. It is planned to deprecate the legacy
+  code path in the ipsec-secgw application in the 19.11 release and remove it
+  in the 20.02 release.