diff mbox series

[7/9] crypto/qat: add digest encrypted feature flag

Message ID	20190603145048.2596-8-damianx.nowak@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	akhil goyal
Headers	From: Nowak <damianx.nowak@intel.com> To: dev@dpdk.org Cc: fiona.trahe@intel.com, arkadiuszx.kusztal@intel.com, Damian Nowak <damianx.nowak@intel.com> Date: Mon, 3 Jun 2019 16:50:46 +0200 Message-Id: <20190603145048.2596-8-damianx.nowak@intel.com> In-Reply-To: <20190603145048.2596-1-damianx.nowak@intel.com> References: <20190603145048.2596-1-damianx.nowak@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 7/9] crypto/qat: add digest encrypted feature flag Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	add QAT support for digest encrypted \| [0/9] add QAT support for digest encrypted [1/9] crypto/qat: check buffer size for oop auth-cipher [2/9] test/crypto: add snow3g test cases for oop operation [3/9] test/crypto: add kasumi test cases for oop operation [4/9] test/crypto: add sgl test cases for ip and oop [5/9] cryptodev: document usage of digest-appended operations [6/9] cryptodev: add digest encrypted feature flag [7/9] crypto/qat: add digest encrypted feature flag [8/9] test/crypto: add digest encrypted feature flag check [9/9] test/crypto: return correct value if feature not supported

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	fail	Compilation issues

Commit Message

Damian Nowak June 3, 2019, 2:50 p.m. UTC

  From: Damian Nowak <damianx.nowak@intel.com>

This patch adds feature flag for QuickAssist
Technology to emphasize it's support for digest
appended auth-cipher operations.

Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
---
 drivers/crypto/qat/qat_sym_pmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Fiona Trahe June 4, 2019, 1:45 p.m. UTC | #1

Hi Damian,

> -----Original Message-----
> From: Nowak, DamianX
> Sent: Monday, June 3, 2019 3:51 PM
> To: dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Nowak,
> DamianX <damianx.nowak@intel.com>
> Subject: [PATCH 7/9] crypto/qat: add digest encrypted feature flag
> 
> From: Damian Nowak <damianx.nowak@intel.com>
> 
> This patch adds feature flag for QuickAssist
> Technology to emphasize it's support for digest
> appended auth-cipher operations.
> 
> Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
> ---
>  drivers/crypto/qat/qat_sym_pmd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c
> index af21270..71f21ce 100644
> --- a/drivers/crypto/qat/qat_sym_pmd.c
> +++ b/drivers/crypto/qat/qat_sym_pmd.c
> @@ -278,7 +278,8 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev)
>  			RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |
>  			RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
>  			RTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT |
> -			RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT;
> +			RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |
> +			RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED;
[Fiona] As this feature in QAT is currently limited to wireless algorithms you should add a line
about this limitation in the QAT sym crypto doc.
Note, we should remove the limitation - but that can be a future patch.

diff mbox series

Patch

diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c
index af21270..71f21ce 100644
--- a/drivers/crypto/qat/qat_sym_pmd.c
+++ b/drivers/crypto/qat/qat_sym_pmd.c
@@ -278,7 +278,8 @@  qat_sym_dev_create(struct qat_pci_device *qat_pci_dev)
 			RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |
 			RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
 			RTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT |
-			RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT;
+			RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |
+			RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED;
 
 	internals = cryptodev->data->dev_private;
 	internals->qat_dev = qat_pci_dev;