diff mbox series

[1/2] net/i40e: fix dropped packets statistics name

Message ID 1559550688-9290-1-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [1/2] net/i40e: fix dropped packets statistics name |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

David Marchand June 3, 2019, 8:31 a.m. UTC 
  i40e and i40evf currently use two different names for the statistic on
dropped packets on the rx and tx sides.
Let's prefer i40evf so that all statistics are suffixed with _packets.

This also avoids a statistic name conflict in OVS.

Fixes: f4a91c38b4ad ("i40e: add extended stats")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/i40e/i40e_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Eelco Chaudron June 3, 2019, 8:52 a.m. UTC | #1 
Looks good to me…

Acked-by: Eelco Chaudron <echaudro@redhat.com>

On 3 Jun 2019, at 10:31, David Marchand wrote:

> i40e and i40evf currently use two different names for the statistic on
> dropped packets on the rx and tx sides.
> Let's prefer i40evf so that all statistics are suffixed with _packets.
>
> This also avoids a statistic name conflict in OVS.
>
> Fixes: f4a91c38b4ad ("i40e: add extended stats")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c 
> b/drivers/net/i40e/i40e_ethdev.c
> index 7fa9e1b..2384d4d 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -526,13 +526,13 @@ struct rte_i40e_xstats_name_off {
>  	{"rx_unicast_packets", offsetof(struct i40e_eth_stats, rx_unicast)},
>  	{"rx_multicast_packets", offsetof(struct i40e_eth_stats, 
> rx_multicast)},
>  	{"rx_broadcast_packets", offsetof(struct i40e_eth_stats, 
> rx_broadcast)},
> -	{"rx_dropped", offsetof(struct i40e_eth_stats, rx_discards)},
> +	{"rx_dropped_packets", offsetof(struct i40e_eth_stats, 
> rx_discards)},
>  	{"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats,
>  		rx_unknown_protocol)},
>  	{"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)},
>  	{"tx_multicast_packets", offsetof(struct i40e_eth_stats, 
> tx_multicast)},
>  	{"tx_broadcast_packets", offsetof(struct i40e_eth_stats, 
> tx_broadcast)},
> -	{"tx_dropped", offsetof(struct i40e_eth_stats, tx_discards)},
> +	{"tx_dropped_packets", offsetof(struct i40e_eth_stats, 
> tx_discards)},
>  };
>
>  #define I40E_NB_ETH_XSTATS (sizeof(rte_i40e_stats_strings) / \
> -- 
> 1.8.3.1
David Marchand June 11, 2019, 11:15 a.m. UTC | #2 
Hello guys,

Can you review this patch please?

Thanks.

On Mon, Jun 3, 2019 at 10:32 AM David Marchand <david.marchand@redhat.com>
wrote:

> i40e and i40evf currently use two different names for the statistic on
> dropped packets on the rx and tx sides.
> Let's prefer i40evf so that all statistics are suffixed with _packets.
>
> This also avoids a statistic name conflict in OVS.
>
> Fixes: f4a91c38b4ad ("i40e: add extended stats")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c
> b/drivers/net/i40e/i40e_ethdev.c
> index 7fa9e1b..2384d4d 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -526,13 +526,13 @@ struct rte_i40e_xstats_name_off {
>         {"rx_unicast_packets", offsetof(struct i40e_eth_stats,
> rx_unicast)},
>         {"rx_multicast_packets", offsetof(struct i40e_eth_stats,
> rx_multicast)},
>         {"rx_broadcast_packets", offsetof(struct i40e_eth_stats,
> rx_broadcast)},
> -       {"rx_dropped", offsetof(struct i40e_eth_stats, rx_discards)},
> +       {"rx_dropped_packets", offsetof(struct i40e_eth_stats,
> rx_discards)},
>         {"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats,
>                 rx_unknown_protocol)},
>         {"tx_unicast_packets", offsetof(struct i40e_eth_stats,
> tx_unicast)},
>         {"tx_multicast_packets", offsetof(struct i40e_eth_stats,
> tx_multicast)},
>         {"tx_broadcast_packets", offsetof(struct i40e_eth_stats,
> tx_broadcast)},
> -       {"tx_dropped", offsetof(struct i40e_eth_stats, tx_discards)},
> +       {"tx_dropped_packets", offsetof(struct i40e_eth_stats,
> tx_discards)},
>  };
>
>  #define I40E_NB_ETH_XSTATS (sizeof(rte_i40e_stats_strings) / \
> --
> 1.8.3.1
>
>
Xing, Beilei June 12, 2019, 1:34 a.m. UTC | #3 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand
> Sent: Monday, June 3, 2019 4:31 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] net/i40e: fix dropped packets statistics
> name
> 
> i40e and i40evf currently use two different names for the statistic on
> dropped packets on the rx and tx sides.
> Let's prefer i40evf so that all statistics are suffixed with _packets.
> 
> This also avoids a statistic name conflict in OVS.
> 
> Fixes: f4a91c38b4ad ("i40e: add extended stats")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 7fa9e1b..2384d4d 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -526,13 +526,13 @@ struct rte_i40e_xstats_name_off {
>  	{"rx_unicast_packets", offsetof(struct i40e_eth_stats, rx_unicast)},
>  	{"rx_multicast_packets", offsetof(struct i40e_eth_stats,
> rx_multicast)},
>  	{"rx_broadcast_packets", offsetof(struct i40e_eth_stats,
> rx_broadcast)},
> -	{"rx_dropped", offsetof(struct i40e_eth_stats, rx_discards)},
> +	{"rx_dropped_packets", offsetof(struct i40e_eth_stats, rx_discards)},
>  	{"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats,
>  		rx_unknown_protocol)},
>  	{"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)},
>  	{"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_multicast)},
>  	{"tx_broadcast_packets", offsetof(struct i40e_eth_stats,
> tx_broadcast)},
> -	{"tx_dropped", offsetof(struct i40e_eth_stats, tx_discards)},
> +	{"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_discards)},
>  };
> 
>  #define I40E_NB_ETH_XSTATS (sizeof(rte_i40e_stats_strings) / \
> --
> 1.8.3.1

Acked-by: Beilei Xing <beilei.xing@intel.com>
Qi Zhang June 18, 2019, 1:59 p.m. UTC | #4 
> -----Original Message-----
> From: Xing, Beilei
> Sent: Wednesday, June 12, 2019 9:35 AM
> To: David Marchand <david.marchand@redhat.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 1/2] net/i40e: fix dropped packets statistics
> name
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand
> > Sent: Monday, June 3, 2019 4:31 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Subject: [dpdk-dev] [PATCH 1/2] net/i40e: fix dropped packets
> > statistics name
> >
> > i40e and i40evf currently use two different names for the statistic on
> > dropped packets on the rx and tx sides.
> > Let's prefer i40evf so that all statistics are suffixed with _packets.
> >
> > This also avoids a statistic name conflict in OVS.
> >
> > Fixes: f4a91c38b4ad ("i40e: add extended stats")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> 
> Acked-by: Beilei Xing <beilei.xing@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 7fa9e1b..2384d4d 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -526,13 +526,13 @@  struct rte_i40e_xstats_name_off {
 	{"rx_unicast_packets", offsetof(struct i40e_eth_stats, rx_unicast)},
 	{"rx_multicast_packets", offsetof(struct i40e_eth_stats, rx_multicast)},
 	{"rx_broadcast_packets", offsetof(struct i40e_eth_stats, rx_broadcast)},
-	{"rx_dropped", offsetof(struct i40e_eth_stats, rx_discards)},
+	{"rx_dropped_packets", offsetof(struct i40e_eth_stats, rx_discards)},
 	{"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats,
 		rx_unknown_protocol)},
 	{"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)},
 	{"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_multicast)},
 	{"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_broadcast)},
-	{"tx_dropped", offsetof(struct i40e_eth_stats, tx_discards)},
+	{"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_discards)},
 };
 
 #define I40E_NB_ETH_XSTATS (sizeof(rte_i40e_stats_strings) / \