diff mbox series

net/ixgbe/base: wait for link after copper MAC setup

Message ID 20190524093015.20025-1-ashijeet.acharya@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series net/ixgbe/base: wait for link after copper MAC setup |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Ashijeet Acharya May 24, 2019, 9:30 a.m. UTC 
  After setting up the link on x552/X557-AT 10GBASE-T NICs, sometimes the
link does not get set up properly and as a result all the subsequent
calls to ixgbe_check_link() from ixgbe_dev_link_update_share() fail.

Introduce a delay time of 1s in ixgbe_setup_mac_link_t_X550em() before
beginning to set up the external PHY link speed to ensure that the
controller can acquire the link.

Signed-off-by: Ashijeet Acharya <ashijeet.acharya@6wind.com>
---
Hello,

This patch makes changes in the base driver.
Similar patch was introduced in case of fiber link MAC setup earlier
        http://patchwork.dpdk.org/patch/43119/
Bugzilla: https://bugs.dpdk.org/show_bug.cgi?id=69

 drivers/net/ixgbe/base/ixgbe_x550.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Qi Zhang May 27, 2019, 4:45 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ashijeet Acharya
> Sent: Friday, May 24, 2019 2:30 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe/base: wait for link after copper MAC
> setup
> 
> After setting up the link on x552/X557-AT 10GBASE-T NICs, sometimes the link
> does not get set up properly and as a result all the subsequent calls to
> ixgbe_check_link() from ixgbe_dev_link_update_share() fail.
> 
> Introduce a delay time of 1s in ixgbe_setup_mac_link_t_X550em() before
> beginning to set up the external PHY link speed to ensure that the controller
> can acquire the link.
> 
> Signed-off-by: Ashijeet Acharya <ashijeet.acharya@6wind.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c
index a920a146e..930a61a20 100644
--- a/drivers/net/ixgbe/base/ixgbe_x550.c
+++ b/drivers/net/ixgbe/base/ixgbe_x550.c
@@ -4440,6 +4440,8 @@  s32 ixgbe_setup_mac_link_t_X550em(struct ixgbe_hw *hw,
 {
 	s32 status;
 	ixgbe_link_speed force_speed;
+	u32 i;
+	bool link_up = false;
 
 	DEBUGFUNC("ixgbe_setup_mac_link_t_X550em");
 
@@ -4459,6 +4461,19 @@  s32 ixgbe_setup_mac_link_t_X550em(struct ixgbe_hw *hw,
 
 		if (status != IXGBE_SUCCESS)
 			return status;
+
+		/* Wait for the controller to acquire link */
+		for (i = 0; i < 10; i++) {
+			msec_delay(100);
+
+			status = ixgbe_check_link(hw, &force_speed, &link_up,
+						  false);
+			if (status != IXGBE_SUCCESS)
+				return status;
+
+			if (link_up)
+				break;
+		}
 	}
 
 	return hw->phy.ops.setup_link_speed(hw, speed, autoneg_wait_to_complete);