From patchwork Mon Apr 1 00:12:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Eads, Gage" X-Patchwork-Id: 51960 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4618E568A; Mon, 1 Apr 2019 02:13:40 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 4FF83316B for ; Mon, 1 Apr 2019 02:13:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2019 17:13:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,294,1549958400"; d="scan'208";a="130291875" Received: from txasoft-yocto.an.intel.com ([10.123.72.192]) by orsmga008.jf.intel.com with ESMTP; 31 Mar 2019 17:13:27 -0700 From: Gage Eads To: dev@dpdk.org Cc: olivier.matz@6wind.com, arybchenko@solarflare.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, nd@arm.com, thomas@monjalon.net Date: Sun, 31 Mar 2019 19:12:37 -0500 Message-Id: <20190401001238.17625-8-gage.eads@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20190401001238.17625-1-gage.eads@intel.com> References: <20190328180015.13878-1-gage.eads@intel.com> <20190401001238.17625-1-gage.eads@intel.com> Subject: [dpdk-dev] [PATCH v5 7/8] test/stack: add lock-free stack tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- app/test/meson.build | 2 ++ app/test/test_stack.c | 41 +++++++++++++++++++++++++++-------------- app/test/test_stack_perf.c | 17 +++++++++++++++-- 3 files changed, 44 insertions(+), 16 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 02eb788a4..867cc5863 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -178,6 +178,7 @@ fast_parallel_test_names = [ 'sched_autotest', 'spinlock_autotest', 'stack_autotest', + 'stack_nb_autotest', 'string_autotest', 'table_autotest', 'tailq_autotest', @@ -243,6 +244,7 @@ perf_test_names = [ 'ring_pmd_perf_autotest', 'pmd_perf_autotest', 'stack_perf_autotest', + 'stack_nb_perf_autotest', ] # All test cases in driver_test_names list are non-parallel diff --git a/app/test/test_stack.c b/app/test/test_stack.c index 8392e4e4d..f199136aa 100644 --- a/app/test/test_stack.c +++ b/app/test/test_stack.c @@ -97,7 +97,7 @@ test_stack_push_pop(struct rte_stack *s, void **obj_table, unsigned int bulk_sz) } static int -test_stack_basic(void) +test_stack_basic(uint32_t flags) { struct rte_stack *s = NULL; void **obj_table = NULL; @@ -113,7 +113,7 @@ test_stack_basic(void) for (i = 0; i < STACK_SIZE; i++) obj_table[i] = (void *)(uintptr_t)i; - s = rte_stack_create(__func__, STACK_SIZE, rte_socket_id(), 0); + s = rte_stack_create(__func__, STACK_SIZE, rte_socket_id(), flags); if (s == NULL) { printf("[%s():%u] failed to create a stack\n", __func__, __LINE__); @@ -177,18 +177,18 @@ test_stack_basic(void) } static int -test_stack_name_reuse(void) +test_stack_name_reuse(uint32_t flags) { struct rte_stack *s[2]; - s[0] = rte_stack_create("test", STACK_SIZE, rte_socket_id(), 0); + s[0] = rte_stack_create("test", STACK_SIZE, rte_socket_id(), flags); if (s[0] == NULL) { printf("[%s():%u] Failed to create a stack\n", __func__, __LINE__); return -1; } - s[1] = rte_stack_create("test", STACK_SIZE, rte_socket_id(), 0); + s[1] = rte_stack_create("test", STACK_SIZE, rte_socket_id(), flags); if (s[1] != NULL) { printf("[%s():%u] Failed to detect re-used name\n", __func__, __LINE__); @@ -201,7 +201,7 @@ test_stack_name_reuse(void) } static int -test_stack_name_length(void) +test_stack_name_length(uint32_t flags) { char name[RTE_STACK_NAMESIZE + 1]; struct rte_stack *s; @@ -209,7 +209,7 @@ test_stack_name_length(void) memset(name, 's', sizeof(name)); name[RTE_STACK_NAMESIZE] = '\0'; - s = rte_stack_create(name, STACK_SIZE, rte_socket_id(), 0); + s = rte_stack_create(name, STACK_SIZE, rte_socket_id(), flags); if (s != NULL) { printf("[%s():%u] Failed to prevent long name\n", __func__, __LINE__); @@ -328,7 +328,7 @@ stack_thread_push_pop(void *args) } static int -test_stack_multithreaded(void) +test_stack_multithreaded(uint32_t flags) { struct test_args *args; unsigned int lcore_id; @@ -349,7 +349,7 @@ test_stack_multithreaded(void) return -1; } - s = rte_stack_create("test", STACK_SIZE, rte_socket_id(), 0); + s = rte_stack_create("test", STACK_SIZE, rte_socket_id(), flags); if (s == NULL) { printf("[%s():%u] Failed to create a stack\n", __func__, __LINE__); @@ -384,9 +384,9 @@ test_stack_multithreaded(void) } static int -test_stack(void) +__test_stack(uint32_t flags) { - if (test_stack_basic() < 0) + if (test_stack_basic(flags) < 0) return -1; if (test_lookup_null() < 0) @@ -395,16 +395,29 @@ test_stack(void) if (test_free_null() < 0) return -1; - if (test_stack_name_reuse() < 0) + if (test_stack_name_reuse(flags) < 0) return -1; - if (test_stack_name_length() < 0) + if (test_stack_name_length(flags) < 0) return -1; - if (test_stack_multithreaded() < 0) + if (test_stack_multithreaded(flags) < 0) return -1; return 0; } +static int +test_stack(void) +{ + return __test_stack(0); +} + +static int +test_lf_stack(void) +{ + return __test_stack(RTE_STACK_F_LF); +} + REGISTER_TEST_COMMAND(stack_autotest, test_stack); +REGISTER_TEST_COMMAND(stack_lf_autotest, test_lf_stack); diff --git a/app/test/test_stack_perf.c b/app/test/test_stack_perf.c index 484370d30..e09d5384c 100644 --- a/app/test/test_stack_perf.c +++ b/app/test/test_stack_perf.c @@ -297,14 +297,14 @@ test_bulk_push_pop(struct rte_stack *s) } static int -test_stack_perf(void) +__test_stack_perf(uint32_t flags) { struct lcore_pair cores; struct rte_stack *s; rte_atomic32_init(&lcore_barrier); - s = rte_stack_create(STACK_NAME, STACK_SIZE, rte_socket_id(), 0); + s = rte_stack_create(STACK_NAME, STACK_SIZE, rte_socket_id(), flags); if (s == NULL) { printf("[%s():%u] failed to create a stack\n", __func__, __LINE__); @@ -340,4 +340,17 @@ test_stack_perf(void) return 0; } +static int +test_stack_perf(void) +{ + return __test_stack_perf(0); +} + +static int +test_lf_stack_perf(void) +{ + return __test_stack_perf(RTE_STACK_F_LF); +} + REGISTER_TEST_COMMAND(stack_perf_autotest, test_stack_perf); +REGISTER_TEST_COMMAND(stack_lf_perf_autotest, test_lf_stack_perf);