diff mbox series

ethdev: fix a typo

Message ID 20190322151753.6345-1-ramirose@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series ethdev: fix a typo |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Rami Rosen March 22, 2019, 3:17 p.m. UTC 
  This patch fixes a trivial typo in rte_ethdev.h.
retieve=>retrieve

Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
Cc: stable@dpdk.org

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 lib/librte_ethdev/rte_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit March 25, 2019, 2:16 p.m. UTC | #1 
On 3/22/2019 3:17 PM, Rami Rosen wrote:
> This patch fixes a trivial typo in rte_ethdev.h.
> retieve=>retrieve
> 
> Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.


It is great to have these fixes, but I wonder if there is a way to get them
fixed as a bunch, can running a spell check utility on the DPDK and fix all
existing typos in one go help? Any idea?

cc'ed John & Thomas,
Does it make sense to run something periodical, like before each release, run
spellcheck and fix the typos for whole code?

Thanks,
ferruh
Thomas Monjalon March 25, 2019, 2:29 p.m. UTC | #2 
25/03/2019 15:16, Ferruh Yigit:
> On 3/22/2019 3:17 PM, Rami Rosen wrote:
> > This patch fixes a trivial typo in rte_ethdev.h.
> > retieve=>retrieve
> > 
> > Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Rami Rosen <ramirose@gmail.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Applied to dpdk-next-net/master, thanks.
> 
> 
> It is great to have these fixes, but I wonder if there is a way to get them
> fixed as a bunch, can running a spell check utility on the DPDK and fix all
> existing typos in one go help? Any idea?
> 
> cc'ed John & Thomas,
> Does it make sense to run something periodical, like before each release, run
> spellcheck and fix the typos for whole code?

Yes, it would make sense.

We can also add more spell checkers as part of checkpatch.
diff mbox series

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index a3c864a13..dc8d072e8 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -1135,7 +1135,7 @@  struct rte_eth_dev_info {
 
 /**
  * Ethernet device RX queue information structure.
- * Used to retieve information about configured queue.
+ * Used to retrieve information about configured queue.
  */
 struct rte_eth_rxq_info {
 	struct rte_mempool *mp;     /**< mempool used by that queue. */