From patchwork Wed Mar 13 10:09:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 51147 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 06B554C9C; Wed, 13 Mar 2019 11:09:38 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 318734C9C for ; Wed, 13 Mar 2019 11:09:36 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 5D12B38A0; Wed, 13 Mar 2019 06:09:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 13 Mar 2019 06:09:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=R41TtWliom TesYz3xo4VB5k1Q82Oae/gsyCFZv5IT5w=; b=g2XU9YoOor1fNavHeSVgR64uiF HHmb58/J/kILJLmXnNGS1oyPri0UsjDVoRN01OVqc0knr9SgzmjsHhNXsnhTzc0y +zRFjmtTJljJAmE9HM/F9D6moDGcUFxV4wtuHKpa57Sqn/432wBh1RmlTsK3e3Am zdDJNJF5Eyl69S28E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=R41TtWliomTesYz3xo4VB5k1Q82Oae/gsyCFZv5IT5w=; b=eAazyL+f pVzzD2+VFYQJTu2Ok5q4ft96CFdSsuYSCsteC+x7babRZwkAJaYBErrRrHDYDB/W +nOnkdBP+vi4XPlSz/cR1FVhsGWuvQfEfsqn9Qe2aA9UsRoMeEps0difGMZjk5U1 DP29+0I22N6zteNKQFZFbPwv4mTX9bPV6ESErU9JsfNwksCeQMUj7JC9xbKRfCBt o+h4FWQ3ns+ojvlHAsR+ZC8gGRKnOsBnmBNUt8Z5LF925+bctYWl30o2niuyCEdx 7Ynl6JC8QPL5UcGyqXZWvXadhB2izftWx1Vp2AYyURiLzMwHSoWlEoBuSyNBQiVc /qdMBz9BvbVpoA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrhedtgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtkeertd ertddtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuffhomhgrihhnpehtgihmohguvgdrmhhqnecukfhppe ejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F832E46AB for ; Wed, 13 Mar 2019 06:09:34 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Date: Wed, 13 Mar 2019 11:09:09 +0100 Message-Id: <20190313100910.31260-2-thomas@monjalon.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190313100910.31260-1-thomas@monjalon.net> References: <20190313100910.31260-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The default config is used if the setup parameter is NULL. No need to query the default config with rte_eth_dev_info_get(). The function call will be removed with another useless info. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson Reviewed-by: Rami Rosen --- examples/ethtool/ethtool-app/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c index dc93adfe3..e23d3afd2 100644 --- a/examples/ethtool/ethtool-app/main.c +++ b/examples/ethtool/ethtool-app/main.c @@ -95,7 +95,6 @@ static void setup_ports(struct app_config *app_cfg, int cnt_ports) char str_name[16]; uint16_t nb_rxd = PORT_RX_QUEUE_SIZE; uint16_t nb_txd = PORT_TX_QUEUE_SIZE; - struct rte_eth_txconf txconf; memset(&cfg_port, 0, sizeof(cfg_port)); cfg_port.txmode.mq_mode = ETH_MQ_TX_NONE; @@ -140,10 +139,9 @@ static void setup_ports(struct app_config *app_cfg, int cnt_ports) rte_exit(EXIT_FAILURE, "rte_eth_rx_queue_setup failed" ); - txconf = dev_info.default_txconf; if (rte_eth_tx_queue_setup( idx_port, 0, nb_txd, - rte_eth_dev_socket_id(idx_port), &txconf) < 0) + rte_eth_dev_socket_id(idx_port), NULL) < 0) rte_exit(EXIT_FAILURE, "rte_eth_tx_queue_setup failed" );