diff mbox series

[2/3] test: remove prefix _acpi from UT power function/test names

Message ID 20190307135950.30738-3-lukaszx.krakowiak@intel.com (mailing list archive)
State Changes Requested, archived
Delegated to: Thomas Monjalon
Headers
Series test: improve test coverage for power library |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Lukasz Krakowiak March 7, 2019, 1:59 p.m. UTC 
  This patch remove prefix _acpi from power UT function/test names.

Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
---
 app/test/autotest_data.py     |  4 ++--
 app/test/meson.build          |  2 +-
 app/test/test_power_cpufreq.c | 12 ++++++------
 3 files changed, 9 insertions(+), 9 deletions(-)

Comments

Burakov, Anatoly March 27, 2019, 3:07 p.m. UTC | #1 
On 07-Mar-19 1:59 PM, Lukasz Krakowiak wrote:
> This patch remove prefix _acpi from power UT function/test names.

Again, subject line is IMO too long. How about:

"test/power: remove _acpi prefix from test names"

?

Otherwise,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

> 
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> ---
Thomas Monjalon March 29, 2019, 10:40 p.m. UTC | #2 
27/03/2019 16:07, Burakov, Anatoly:
> On 07-Mar-19 1:59 PM, Lukasz Krakowiak wrote:
> > This patch remove prefix _acpi from power UT function/test names.

I think it can be merged with patch renaming the file.
diff mbox series

Patch

diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py
index 5f87bb94d..c80801b20 100644
--- a/app/test/autotest_data.py
+++ b/app/test/autotest_data.py
@@ -622,8 +622,8 @@ 
         "Report":      None,
     },
     {
-        "Name":       "Power ACPI cpufreq autotest",
-        "Command":    "power_acpi_cpufreq_autotest",
+        "Name":       "Power cpufreq autotest",
+        "Command":    "power_cpufreq_autotest",
         "Func":       default_autotest,
         "Report":     None,
     },
diff --git a/app/test/meson.build b/app/test/meson.build
index 4ae3dffea..a389a2b10 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -205,7 +205,7 @@  fast_non_parallel_test_names = [
         'member_autotest',
         'metrics_autotest',
         'pdump_autotest',
-        'power_acpi_cpufreq_autotest',
+        'power_cpufreq_autotest',
         'power_autotest',
         'power_kvm_vm_autotest',
         'reorder_autotest',
diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c
index 61b1da05a..d099f2f47 100644
--- a/app/test/test_power_cpufreq.c
+++ b/app/test/test_power_cpufreq.c
@@ -14,14 +14,14 @@ 
 #ifndef RTE_LIBRTE_POWER
 
 static int
-test_power_acpi_cpufreq(void)
+test_power_cpufreq(void)
 {
 	printf("Power management library not supported, skipping test\n");
 	return TEST_SKIPPED;
 }
 
 static int
-test_power_acpi_caps(void)
+test_power_caps(void)
 {
 	printf("Power management library not supported, skipping test\n");
 	return TEST_SKIPPED;
@@ -367,7 +367,7 @@  check_power_freq_min(void)
 }
 
 static int
-test_power_acpi_cpufreq(void)
+test_power_cpufreq(void)
 {
 	int ret = -1;
 	enum power_management_env env;
@@ -539,7 +539,7 @@  test_power_acpi_cpufreq(void)
 }
 
 static int
-test_power_acpi_caps(void)
+test_power_caps(void)
 {
 	struct rte_power_core_capabilities caps;
 	int ret;
@@ -568,5 +568,5 @@  test_power_acpi_caps(void)
 
 #endif
 
-REGISTER_TEST_COMMAND(power_acpi_cpufreq_autotest, test_power_acpi_cpufreq);
-REGISTER_TEST_COMMAND(power_acpi_caps_autotest, test_power_acpi_caps);
+REGISTER_TEST_COMMAND(power_cpufreq_autotest, test_power_cpufreq);
+REGISTER_TEST_COMMAND(power_caps_autotest, test_power_caps);