| Message ID | 20190227133258.8962-2-ayverma@marvell.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | akhil goyal |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3BAB5B12; Wed, 27 Feb 2019 14:33:54 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id DEFB958EC for <dev@dpdk.org>; Wed, 27 Feb 2019 14:33:52 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1RDTmba020220; Wed, 27 Feb 2019 05:33:52 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=nAB649oIYerga9rsDjMmt6DuvDFmSrAM1iuHizHA/LM=; b=uwdZwP7iI9xfk4nPJGipDPOxOoKNyy8lDMFE5h/FEK85qinu71WMAEcQRZZ6vXC2bR7t /ly+9wyUrLH8f1wQdD6dLgopEKCOO9dVH9STBl0vgjqOPtr50xFnqLom35g3XRRmePRc fVHsMAa/EDw3bpULyeta6UknTWSY34ERwrnFR4+DDPNdeLYksF++A8Nugn8psae/R4gK U97siZAZ/Y4lVI9G+Or5RNIxXCjaX+Zg4HKXeFGrhNEx8QmemGeQPYc0VQzMbHGdYvgk AfBzIjVOV57ZqiKmqNJhBZEvxTbjZgKZ3NSp6qgwDIOhjyw7FEGhUfIRSoWmYhzHQ65J iA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2qwhfgsm21-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 27 Feb 2019 05:33:51 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 27 Feb 2019 05:33:50 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.56) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 27 Feb 2019 05:33:50 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nAB649oIYerga9rsDjMmt6DuvDFmSrAM1iuHizHA/LM=; b=fWBz+TqHQFuDLxB+P5deCRCtf7UkexcHMb+V7dyiwAtwaaEz8FxKs6DJy4cx+Qlyi5DfI7GEOIqfO8SIa3XQA/NGZBK0uMlVIRPuXg8SdeGgnT7hEU6y/U/apEiv9LW2B5zjnCZ/BkvCOIOqga8QIJlPXrua+Tji6WiPtwAdeNc= Received: from MN2PR18MB2542.namprd18.prod.outlook.com (20.179.82.221) by MN2PR18MB2607.namprd18.prod.outlook.com (20.179.82.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15; Wed, 27 Feb 2019 13:33:45 +0000 Received: from MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::2cd3:8b8:fbbb:db98]) by MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::2cd3:8b8:fbbb:db98%5]) with mapi id 15.20.1643.022; Wed, 27 Feb 2019 13:33:45 +0000 From: Ayuj Verma <ayverma@marvell.com> To: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com> CC: "arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>, "fiona.trahe@intel.com" <fiona.trahe@intel.com>, Shally Verma <shallyv@marvell.com>, Sunila Sahu <ssahu@marvell.com>, "Kanaka Durga Kotamarthy" <kkotamarthy@marvell.com>, Arvind Desai <adesai@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>, Ayuj Verma <ayverma@marvell.com> Thread-Topic: [PATCH v2 1/3] lib/cryptodev: add rsa priv key feature flag Thread-Index: AQHUzqEQYnksvmeXlU+PYZpL3Wr2+Q== Date: Wed, 27 Feb 2019 13:33:45 +0000 Message-ID: <20190227133258.8962-2-ayverma@marvell.com> References: <20190227133258.8962-1-ayverma@marvell.com> In-Reply-To: <20190227133258.8962-1-ayverma@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: PN1PR01CA0109.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::25) To MN2PR18MB2542.namprd18.prod.outlook.com (2603:10b6:208:103::29) x-mailer: git-send-email 2.20.0 x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [111.93.218.67] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a287886-49e7-44d9-a136-08d69cb83269 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:MN2PR18MB2607; x-ms-traffictypediagnostic: MN2PR18MB2607: x-microsoft-exchange-diagnostics: 1; MN2PR18MB2607; 20:rGf0dBGrFL3EoSy2RLBV6ZRS5NGTfY+RiN/Dzm0CUcBJCzoJmKJzpQO/cZqSAKfT9o0wG8eW7wGAjXiCGGPtGgskbzNL4eG7BPdbGSjsZhzX8cbiyEzDslEynnoR8jajDqVzKo5F/tnnijpLZ84j7OtGVVZIgmg8UypVL/97sd8= x-microsoft-antispam-prvs: <MN2PR18MB260755BC8D0E91A098AB4A0EAD740@MN2PR18MB2607.namprd18.prod.outlook.com> x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(136003)(346002)(376002)(199004)(189003)(78486014)(99286004)(86362001)(26005)(186003)(14444005)(305945005)(7736002)(6436002)(6512007)(386003)(6506007)(5640700003)(3846002)(2906002)(446003)(486006)(6116002)(54906003)(6916009)(97736004)(11346002)(256004)(1076003)(2616005)(476003)(2501003)(5660300002)(71190400001)(71200400001)(478600001)(4326008)(14454004)(25786009)(107886003)(2351001)(8676002)(53936002)(316002)(102836004)(8936002)(6486002)(68736007)(81166006)(52116002)(81156014)(76176011)(66066001)(50226002)(105586002)(106356001)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2607; H:MN2PR18MB2542.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: M/ZnRpHSDee6a8titKm2jHltOWHoyRDqPqjQP8TeMRyc/PFzx0bGPGHSKQy+UXnPuUcWpoF3qIRqx/ajWqa8V6aC6bx3D+dC7cy9Ujk5JcmlxMIrtAiK7Zd5Ysn9+SSTuy+tKJQmbO9h7+gkEj1hFiBkrI7md9BuuWj0asRiqWdSG2+V0nN2Twy4w9vyC/gMlyuRopaBKVQLevnC0Eklplgj5wALvnC+oaHZmdlhkHgKLz8XnMO+xA4sD4J77bglXAa51Udf3J2lSIX/T95wBLX9LB3JiMcnV0gMoYKiM9M4fyT7QzIOpUsTnkKjnv2dwF09WM7FpUnigrq7ZGyB0E12DUMIBWRySXx+4iyTUnOQT0/PAy60MkedFSA3BUblEdvMALDm4AY/g7u+6Cl96Fs/QY4WSPhlnAT9/0bkroQ= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7a287886-49e7-44d9-a136-08d69cb83269 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 13:33:42.6283 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2607 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-02-27_08:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902270090 Subject: [dpdk-dev] [PATCH v2 1/3] lib/cryptodev: add rsa priv key feature flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
adding rsa priv key feature flag
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
Commit Message
Ayuj Verma
Feb. 27, 2019, 1:33 p.m. UTC
Add feature flag to reflect RSA private key operation support using quintuple (crt) or exponent type key. if PMD support both, then it should set both. App should query cryptodev feature flag to check if Sign and Decryt with CRT keys or exponent is supported, thus call operation with relevant key type. Signed-off-by: Ayuj Verma <ayverma@marvell.com> Signed-off-by: Shally Verma <shallyv@marvell.com> --- lib/librte_cryptodev/rte_cryptodev.c | 4 ++++ lib/librte_cryptodev/rte_cryptodev.h | 4 ++++ 2 files changed, 8 insertions(+)
Comments
Hi Ayuj, On 2/27/2019 7:03 PM, Ayuj Verma wrote: > Add feature flag to reflect RSA private key > operation support using quintuple (crt) or > exponent type key. if PMD support both, > then it should set both. > > App should query cryptodev feature flag to check > if Sign and Decryt with CRT keys or exponent is > supported, thus call operation with relevant > key type. > > Signed-off-by: Ayuj Verma <ayverma@marvell.com> > Signed-off-by: Shally Verma <shallyv@marvell.com> > --- > lib/librte_cryptodev/rte_cryptodev.c | 4 ++++ > lib/librte_cryptodev/rte_cryptodev.h | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c > index 700973530..bb90ac939 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -486,6 +486,10 @@ rte_cryptodev_get_feature_name(uint64_t flag) > return "CPU_ARM_CE"; > case RTE_CRYPTODEV_FF_SECURITY: > return "SECURITY_PROTOCOL"; > + case RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP: > + return "RSA_PRIV_OP_KEY_EXP"; > + case RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT: > + return "RSA_PRIV_OP_KEY_QT"; > default: > return NULL; > } > diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h > index a0bbcf932..298b35217 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -438,6 +438,10 @@ rte_cryptodev_asym_get_xform_enum(enum rte_crypto_asym_xform_type *xform_enum, > /**< Utilises ARM CPU Cryptographic Extensions */ > #define RTE_CRYPTODEV_FF_SECURITY (1ULL << 16) > /**< Support Security Protocol Processing */ > +#define RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP (1ULL << 17) > +/**< Support RSA Private Key OP with exponent */ > +#define RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT (1ULL << 18) > +/**< Support RSA Private Key OP with CRT (quintuple) Keys */ I believe these feature flags should be explained a bit in the documentation(doc/guides/cryptodevs/) > > > /**
Hi Akhil, Arek, Sure, I'll rebase the patch and will send v3 along with doc changes. Thanks and regards Ayuj Verma -----Original Message----- From: Akhil Goyal <akhil.goyal@nxp.com> Sent: Sunday, March 17, 2019 11:17 PM To: Ayuj Verma <ayverma@marvell.com> Cc: arkadiuszx.kusztal@intel.com; fiona.trahe@intel.com; Shally Verma <shallyv@marvell.com>; Sunila Sahu <ssahu@marvell.com>; Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>; Arvind Desai <adesai@marvell.com>; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/cryptodev: add rsa priv key feature flag Hi Ayuj, On 2/27/2019 7:03 PM, Ayuj Verma wrote: > Add feature flag to reflect RSA private key operation support using > quintuple (crt) or exponent type key. if PMD support both, then it > should set both. > > App should query cryptodev feature flag to check if Sign and Decryt > with CRT keys or exponent is supported, thus call operation with > relevant key type. > > Signed-off-by: Ayuj Verma <ayverma@marvell.com> > Signed-off-by: Shally Verma <shallyv@marvell.com> > --- > lib/librte_cryptodev/rte_cryptodev.c | 4 ++++ > lib/librte_cryptodev/rte_cryptodev.h | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/lib/librte_cryptodev/rte_cryptodev.c > b/lib/librte_cryptodev/rte_cryptodev.c > index 700973530..bb90ac939 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -486,6 +486,10 @@ rte_cryptodev_get_feature_name(uint64_t flag) > return "CPU_ARM_CE"; > case RTE_CRYPTODEV_FF_SECURITY: > return "SECURITY_PROTOCOL"; > + case RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP: > + return "RSA_PRIV_OP_KEY_EXP"; > + case RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT: > + return "RSA_PRIV_OP_KEY_QT"; > default: > return NULL; > } > diff --git a/lib/librte_cryptodev/rte_cryptodev.h > b/lib/librte_cryptodev/rte_cryptodev.h > index a0bbcf932..298b35217 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -438,6 +438,10 @@ rte_cryptodev_asym_get_xform_enum(enum rte_crypto_asym_xform_type *xform_enum, > /**< Utilises ARM CPU Cryptographic Extensions */ > #define RTE_CRYPTODEV_FF_SECURITY (1ULL << 16) > /**< Support Security Protocol Processing */ > +#define RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP (1ULL << 17) > +/**< Support RSA Private Key OP with exponent */ > +#define RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT (1ULL << 18) > +/**< Support RSA Private Key OP with CRT (quintuple) Keys */ I believe these feature flags should be explained a bit in the documentation(doc/guides/cryptodevs/) > > > /**
diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 700973530..bb90ac939 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -486,6 +486,10 @@ rte_cryptodev_get_feature_name(uint64_t flag) return "CPU_ARM_CE"; case RTE_CRYPTODEV_FF_SECURITY: return "SECURITY_PROTOCOL"; + case RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP: + return "RSA_PRIV_OP_KEY_EXP"; + case RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT: + return "RSA_PRIV_OP_KEY_QT"; default: return NULL; } diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index a0bbcf932..298b35217 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -438,6 +438,10 @@ rte_cryptodev_asym_get_xform_enum(enum rte_crypto_asym_xform_type *xform_enum, /**< Utilises ARM CPU Cryptographic Extensions */ #define RTE_CRYPTODEV_FF_SECURITY (1ULL << 16) /**< Support Security Protocol Processing */ +#define RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP (1ULL << 17) +/**< Support RSA Private Key OP with exponent */ +#define RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT (1ULL << 18) +/**< Support RSA Private Key OP with CRT (quintuple) Keys */ /**