[2/5] app/testpmd: add missing newline when showing statistics
Checks
Commit Message
Having the standard stats and the rx burst stats on the same line gives a
really long line and is not consistent with the rest.
Before:
RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
After:
RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0
RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
app/test-pmd/testpmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
+1
Reviewed-by: Rami Rosen <ramirose at gmail.com>
On Thu, Feb 14, 2019 at 5:43 PM David Marchand <david.marchand@redhat.com>
wrote:
> Having the standard stats and the rx burst stats on the same line gives a
> really long line and is not consistent with the rest.
>
> Before:
> RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6
> RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
> TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
>
> After:
> RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0
> RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
> TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> app/test-pmd/testpmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 98c1baa..984155a 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1459,7 +1459,7 @@ struct extmem_param {
> "TX Port=%2d/Queue=%2d %s\n",
> fwd_top_stats_border, fs->rx_port, fs->rx_queue,
> fs->tx_port, fs->tx_queue, fwd_top_stats_border);
> - printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u",
> + printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n",
> fs->rx_packets, fs->tx_packets, fs->fwd_dropped);
>
> /* if checksum mode */
> --
> 1.8.3.1
>
>
@@ -1459,7 +1459,7 @@ struct extmem_param {
"TX Port=%2d/Queue=%2d %s\n",
fwd_top_stats_border, fs->rx_port, fs->rx_queue,
fs->tx_port, fs->tx_queue, fwd_top_stats_border);
- printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u",
+ printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n",
fs->rx_packets, fs->tx_packets, fs->fwd_dropped);
/* if checksum mode */