[1/1] net/qede: fix tx_pkt_prepare for tunnel packets

Message ID 20190213175333.19993-1-shshaikh@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [1/1] net/qede: fix tx_pkt_prepare for tunnel packets |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Shahed Shaikh Feb. 13, 2019, 5:53 p.m. UTC
  This patch fixes a regression introduced by
commit 49d3978d5723("net/qede: fix Tx tunnel offload support mask")
in which qede_xmit_prep_pkts() breaks the loop for successful
check of Tunneling offload flags instead of continuing, resulting
in tx_pkt_prepare return a failure.

Fixes: 49d3978d5723 ("net/qede: fix Tx tunnel offload support mask")
Cc: stable@dpdk.org

Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
---
 drivers/net/qede/qede_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit Feb. 18, 2019, 6:12 p.m. UTC | #1
On 2/13/2019 5:53 PM, Shahed Shaikh wrote:
> This patch fixes a regression introduced by
> commit 49d3978d5723("net/qede: fix Tx tunnel offload support mask")
> in which qede_xmit_prep_pkts() breaks the loop for successful
> check of Tunneling offload flags instead of continuing, resulting
> in tx_pkt_prepare return a failure.
> 
> Fixes: 49d3978d5723 ("net/qede: fix Tx tunnel offload support mask")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
index 9bf93c2e1..01b6ffd6e 100644
--- a/drivers/net/qede/qede_rxtx.c
+++ b/drivers/net/qede/qede_rxtx.c
@@ -1970,7 +1970,7 @@  qede_xmit_prep_pkts(__rte_unused void *p_txq, struct rte_mbuf **tx_pkts,
 				    temp == PKT_TX_TUNNEL_GENEVE ||
 				    temp == PKT_TX_TUNNEL_MPLSINUDP ||
 				    temp == PKT_TX_TUNNEL_GRE)
-					break;
+					continue;
 			}
 
 			rte_errno = -ENOTSUP;