| Message ID | 20190118102930.27487-2-shshaikh@marvell.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9C822BCE; Fri, 18 Jan 2019 11:29:40 +0100 (CET) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-eopbgr810040.outbound.protection.outlook.com [40.107.81.40]) by dpdk.org (Postfix) with ESMTP id 8F8F92BAA; Fri, 18 Jan 2019 11:29:38 +0100 (CET) Received: from DM5PR07CA0105.namprd07.prod.outlook.com (2603:10b6:4:ae::34) by SN6PR07MB4383.namprd07.prod.outlook.com (2603:10b6:805:58::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.26; Fri, 18 Jan 2019 10:29:37 +0000 Received: from BY2NAM05FT020.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::205) by DM5PR07CA0105.outlook.office365.com (2603:10b6:4:ae::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1537.27 via Frontend Transport; Fri, 18 Jan 2019 10:29:36 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; dpdk.org; dkim=none (message not signed) header.d=none; dpdk.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT020.mail.protection.outlook.com (10.152.100.157) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1558.9 via Frontend Transport; Fri, 18 Jan 2019 10:29:36 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Fri, 18 Jan 2019 02:29:36 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x0IATZmf027528; Fri, 18 Jan 2019 02:29:35 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x0IATZtx027527; Fri, 18 Jan 2019 02:29:35 -0800 From: Shahed Shaikh <shshaikh@marvell.com> To: <dev@dpdk.org> CC: <ferruh.yigit@intel.com>, <stable@dpdk.org> Date: Fri, 18 Jan 2019 02:29:30 -0800 Message-ID: <20190118102930.27487-2-shshaikh@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190118102930.27487-1-shshaikh@marvell.com> References: <20190118102930.27487-1-shshaikh@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Matching-Connectors: 131922809766628892; (abac79dc-c90b-41ba-8033-08d666125e47); (abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(39860400002)(136003)(346002)(396003)(2980300002)(1110001)(1109001)(339900001)(189003)(199004)(4326008)(126002)(2906002)(85426001)(47776003)(50226002)(8936002)(106466001)(6916009)(486006)(105606002)(5660300001)(80596001)(69596002)(476003)(450100002)(2351001)(2616005)(36756003)(97736004)(1076003)(26005)(68736007)(14444005)(26826003)(86362001)(305945005)(336012)(356004)(50466002)(81166006)(11346002)(87636003)(446003)(81156014)(42186006)(76176011)(48376002)(54906003)(16586007)(498600001)(8676002)(6666004)(316002)(36906005)(51416003)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4383; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT020; 1:PwdCk6b9zk127G6icK6XbaWdnbjdqi5U7dxfWVoWgzxVMdsTdnWCBspxryEZJpTgZsYG2vl/9ajl5gi5wqpB2tXcFZy7igP5d7jv0iu4dZV8srOMIi4CEQMorRC1RIi8pEoFNN/gnshFM58BpTKzlQ== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7dd807a9-3075-4ab4-0003-08d67d2fd852 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(5600109)(711020)(2017052603328); SRVR:SN6PR07MB4383; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4383; 3:JR7ISoEkR3tcIOeswQVp5lZJZFLF8VxkFi9crFCfQttmgF0Mo2BJ0CZFdW4KWQC1GjgVR/omOfzcsh8icX8x31ltqtXpNZ5wc0+OA6lWu0rXEqAWRSdYEWpaYD8+ipFFiwM0LqL+X/EmIx8/+aYvefJMB+R9WVYVkWRtj6775MwKnZ8vIiaBF6O6zT9DREc2igQF5mlsAEvY8TPZthTeE/8jgyg15RdenHjW/wL63OgtQq240r/CMrfVBkPdK3kEuY/N/gs7G0ek83Di4BDDaRc4OcLZLrAm1Y4w120k3BgZNlE/YMttq6XyfMjYr2P62lsVFmX9NeCZF2egs7bL8JmLKu7iUE6mgcoaPw6Q9d4kkS1PRnWqRalJ3qpkeKmf; 25:JZFiTl4OWbT3MWadBgWxy2DWKThHaW37+U20fN8PkyaSsuAojxHTA+bplTBj/wqvvlBIvbFryTin7IDk2S/6XS/wNoqMGgLI/n04CyTSZELfKUifXAV9YL4FUxD0MF18O1IKv71lCpCuMK5n1RFCdQttAOn173L4E3PuTKhoZK4bp5RrhhltMHS0soHuvezFkgpPdHms5WVjo0lQ++UQvERZ7YJvxOQs1cllX45cE7m81LrLKItqcEYSBBhWIV3Z7rt3MsBhQKfuI66Cmm3XHX8BfGZEnGmk8nRFE0lfeA8qYkMa04ltUtXcq3euqKSK/OOsIAiX50kytWG1fo3tRA== X-MS-TrafficTypeDiagnostic: SN6PR07MB4383: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4383; 31:4wUlqGbeUqcvTJf7IGD09g62UmwvabZytzwsQp1hL6pXrc7XPLfdaaCXclj6Ndk9oH0PI9O4icbVOwdWCgy/+G+nPpnggibpc8yh54Ain9GyHv88hanzfnE9qgr86xzMpMSD2BOTOxw1vgA6xOw+Aj8+J94Zl2QiKwKlSSaUdURqg4D/gDC7R1psjTjebmJTBm0cjA0tarBq+7OI0TqQ3kTxSt+PDanxmTTeiR6w+wM=; 4:c7R2Ra8GLr4dF003G26DVV5xZwWkXouxEsDWbghWZmpPZB91H5TxftbNXG3ngQAUHBgbIcfocYXLkTpi7iKTe9lMtxPHmpgHoz2D+1cSsSa9CwlypF0hJKdxhl+SGSKM9A6HE+KITJPExlT11A8jZjLLT9Ln7rJvbQEv8Shn58pX8RjdnmhKqCl58xyz3CnmjFt1EyOVNePxMLuEc9guGSXlhYeJmjxBgTJB8xQ05Ol1FDeHvgFEdbE4qpPxqgER9YjI1lbiXa5gr09jZ5uSl2g22xZT7ptkjF1u7hyo4daB5Po8CJlVJkuzJCMcI6zC X-Microsoft-Antispam-PRVS: <SN6PR07MB4383E12BB76AB6ED459166E0D39C0@SN6PR07MB4383.namprd07.prod.outlook.com> X-Forefront-PRVS: 0921D55E4F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB4383; 23:7BuSQEg/1i+/lSeDx7y0QZXcW88euPZ/twgRDHn5A?= j3VqEMWH51zl25sy8FIJzCaKnSv8J9r/e6fUuVrVuGijc5IqheYiqYPNOk16C7XiavbKrDAv6zZ76XBvVcj7iTzFw6FfKq9Yz86sCSt/1e9vnzrcpANar0xVdbChzGoMH9GHvgkCZc0H+XYAMge6QDO3eHvz4d0gwdy2GrnNkJgHbGHg4T91dXwughxjHvkYLJ81a/h9wHDQrSlZldVuGjj8pZ7Mb8Kiz0LteNZGNiZ0BwDfhv+sPJSgXM8teMvggDiBYcXiDvoZrUS08mT1eRldqBCYPob3Pvf4LWAWE0O3B7+wwgqyQv1nqJP+0VaCWt36eMH6Dh+hT3lxFGmDRDjDmE/9vy4+SCW2EK+m/ymmUO+1JaBmqmvWuPAmbwcuwlO4/62x4rbNJbzFuJ0VoVVdR/FYfiIPcq3VlvHSpY4kByWEzhJ/VVGLK0IKeKJQRZCFDI4g5ovFX4f8BZ7HV3DL6AQccvTx/7GzO1ve9eb8X+IFqf5r3lc1nGjTjz5/g0PwrwL87BJJNHhZ7XkHU6DtLXlpAV71hoqnjs9UlTi6sKHXo4z34HQzSNZrqaqFDHNc9x65gbNm0UHacqdiVuOyZdeoce+JIjNmb74Lh51HagNG2bYvV1bhlFZvceuvnBVS0dAXW+O9n/ZxSIBBkA0UNjSgjAqQVfHIuGK5KKg4bPqaOP2I72TwWo01gvKuPofiCuBfzEBtAK8lzjmq9ZIOUjGIpyiURkzHAdTR/nRxDjQwIMqBohCwbiLGARR31Lqha6LRnVH9SJaBYmCb2h4U821RdglaaroRoJfJ/4cTbKVwG5YuuzqtdIih9w1/9o1LMon5FO6JOQeb936itWqCp87TqGXGl+hQPl8Qy1y3BCvK54Hk5YFHD6xxRDeF2VMIh1Otxu5Qrq8sVT9licPE7oKmdZAit3g3b7h5+ocR+a697H1wnT826wmGL9WJZyz/wbpwWnmnM4GoPPX7ZfpH76/3t80BO4TdbmG9nKYaFwNuZy1eT7j6Jz40v5qIuyOqBG73XOQ8SyP3LuFDJVM80JBd1qwIwlsALeGQva+5D8eUODr+xerODfvYhxnVjQu+Onnmqy8BdZHFGU1e8LjlGb/Cmk+CICq6GF36RRAxDKJjAVWAxqwtxhjwCOgp+CGmMf9BOgL5gAzAo+RqW2Txxa4P9te61QhhnpDOIOmvGoHLuTeeF9h38055pyS1HFhVy6w7RYvZ1vbYHWEVCiDdNUYt/ziDhMxuqT2vVLgmw== X-Microsoft-Antispam-Message-Info: 9PuLD9Mn8c7byeTTPld25ZQItQBm2OoTOVJtxFWTQUJPrKemN7IIHzTghWmU5ySGe9sGidjNK5L5lOzXdRb0/Qnmu3xhMtqQXGWONDr5Iqr7HU1A9KExZU+Yp1yJX2Vso6vks9G7E2pt+8S/9bdPkOWIaDbhzDWv59s2tK31og7OsPIdWAM4sKuOMTIYWc/xGIQlIDyVvmRfj2YgEMv74LZcGFkej2N2F6QPOGlSvqNi3SAS4Ygk5KthnU06YCa05lDU65zVBBcfJP529yaLncD5zGLZuP1k2mFBHUMhcp2Ai42Gky/KdQge/7D8weaTYxo1P/PW+Kgg7XHDRgvId8VO13saxeQOzK6gyptaBl+RY2gJftqH1ZlfC612HxHZX1y24OqFSuqGaj1YiH1F1H1hJ1gcWKuFVGnnCR6UGpE= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4383; 6:gSAPEUVMu9Sg/RrMU2lZiag0BYlYo4AyudxYs6k/ZA0uhPrDxCmdW3rattQ+9LChjFTa0n1FYvan6XrzGRZXXad6LnHNJ+tb5jlxMRPTJ4Q6YR36eWjucapcv1iIs5huZbcZmH5vsDWm7Xq/o18qCkiB4EIQoVgdxChVnepL6gzCIjFsEA6MHvbKlX1TDBrwO9nVkYHr1JziyVpSh9KLwV0PU9elPUT2iUSBSO+3jOtODiC76gH0QH4kzYzrKaGb5ZPpRcWRATIl9BbcEb4/6e4MJl8zv3sU+KmTmz/GTWo+OUqeFaZRSjE6vg6Sdv6tuAstxfGt2uZyNw9JbgaVDlpblQIcP2x72JKfzL+NZHLQpYSv8wxUfZTSGBJRSpqgAiNCm21eDU+L5m5XyQQtZGfjs4wfNdIRMIyz/V8MZ6cA5Wy5wC9HPP01RIWOTYYezrorp+lN0+iKHOPEhLTiOQ==; 5:35Ca3QFvZ396zgqbTy0tSOwFbnyuE1mtKsJ00mD0Oc12EdQtsAvE1dPDX7ftgSkrKxvMWVt795CrHBoGNmYo4q5DlIa+QkR+SkRxPkp3VN9PQvrhcLKBl1QmdYsckCUeVCz852yOfkguy9+Um3ui85pNV8/YqqJ7iCUlHlJZ40BZ6XNwIqRFfMjmsld9ktIyo8SdfM7qAGQBe1i9EfPxUQ==; 7:sCdGKvPXsLbBjRJoq8TrYnsQ/RBq/rFFsIip7AM/rZpn5mICfV6qg220Q9vKusQJsUStRb59TOUqhQPysGEXt++h8a8P5Kute0EHxXrEMMlKJy67SveuXkA9c1iD02VOukt+ubTIavtsF07fZPXWEw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2019 10:29:36.3347 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7dd807a9-3075-4ab4-0003-08d67d2fd852 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[199.233.58.38]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4383 Subject: [dpdk-dev] [PATCH 2/2] net/qede: fix prefetch from incorrect place in Tx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
[1/2] net/qede: fix performance bottleneck in Rx path
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
Commit Message
Shahed Shaikh
Jan. 18, 2019, 10:29 a.m. UTC
Incorrect placement of prefetch in Tx path is causing
a performance drop of around ~2% on AMD platform.
Fixes: 2ea6f76aff40 ("qede: add core driver")
Cc: stable@dpdk.org
Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
---
drivers/net/qede/qede_rxtx.c | 1 -
1 file changed, 1 deletion(-)
Comments
>From: dev <dev-bounces@dpdk.org> On Behalf Of Shahed Shaikh >Sent: Friday, January 18, 2019 2:30 AM > >Incorrect placement of prefetch in Tx path is causing a performance drop of >around ~2% on AMD platform. > >Fixes: 2ea6f76aff40 ("qede: add core driver") >Cc: stable@dpdk.org > >Signed-off-by: Shahed Shaikh <shshaikh@marvell.com> >--- Acked-by: Rasesh Mody <rmody@marvell.com> > drivers/net/qede/qede_rxtx.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c >index 684c4ae..eda19b2 100644 >--- a/drivers/net/qede/qede_rxtx.c >+++ b/drivers/net/qede/qede_rxtx.c >@@ -2181,7 +2181,6 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf >**tx_pkts, uint16_t nb_pkts) > > txq->nb_tx_avail -= bd1->data.nbds; > txq->sw_tx_prod++; >- rte_prefetch0(txq->sw_tx_ring[TX_PROD(txq)].mbuf); > bd_prod = > rte_cpu_to_le_16(ecore_chain_get_prod_idx(&txq->tx_pbl)); > #ifdef RTE_LIBRTE_QEDE_DEBUG_TX >-- >2.7.4
diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 684c4ae..eda19b2 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -2181,7 +2181,6 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) txq->nb_tx_avail -= bd1->data.nbds; txq->sw_tx_prod++; - rte_prefetch0(txq->sw_tx_ring[TX_PROD(txq)].mbuf); bd_prod = rte_cpu_to_le_16(ecore_chain_get_prod_idx(&txq->tx_pbl)); #ifdef RTE_LIBRTE_QEDE_DEBUG_TX