build: mention -march in pkg-config description

Message ID 20190110172806.12952-1-bluca@debian.org
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • build: mention -march in pkg-config description
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Luca Boccassi Jan. 10, 2019, 5:28 p.m.
Applications need to at least match DPDK's -march option to build
successfully due to some static inline functions in the public headers.

This might cause problems, especially in distributions, so add a note
in the pkg-config description.

Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
Cc: stable@dpdk.org

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
At the moment there are no adversely affected applications in Debian and
Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder
are stand-alone DPDK-specific binaries), but we thought that having an
explicit notice would be good.

 meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Gavin Hu (Arm Technology China) Jan. 11, 2019, 3:58 a.m. | #1
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> Sent: Friday, January 11, 2019 1:28 AM
> To: dev@dpdk.org
> Cc: bruce.richardson@intel.com; christian.ehrhardt@canonical.com; Luca
> Boccassi <bluca@debian.org>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] build: mention -march in pkg-config description
>
> Applications need to at least match DPDK's -march option to build
> successfully due to some static inline functions in the public headers.
>
> This might cause problems, especially in distributions, so add a note
> in the pkg-config description.
>
> Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> At the moment there are no adversely affected applications in Debian and
> Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder
> are stand-alone DPDK-specific binaries), but we thought that having an
> explicit notice would be good.
>
>  meson.build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index f87dc235f..35126106a 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(),
>  libraries: dpdk_libraries,
>  libraries_private: dpdk_drivers + dpdk_static_libraries +
>  ['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
> -description: 'The Data Plane Development Kit (DPDK)',
> +description: '''The Data Plane Development Kit (DPDK).
> +Note that CFLAGS might contain an -march flag higher than typical baseline.
> +This is required for a number of static inline functions in the public
From Arm's perspective, this notice is really necessary for some extensions like LSE to work for performance.
Reviewed-by: Gavin Hu <gavin.hu@arm.com>

> headers.''',
>  subdirs: [get_option('include_subdir_arch'), '.'],
>  extra_cflags: ['-include', 'rte_config.h'] + machine_args
>  )
> --
> 2.20.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Bruce Richardson Jan. 11, 2019, 9:57 a.m. | #2
On Fri, Jan 11, 2019 at 03:58:46AM +0000, Gavin Hu (Arm Technology China) wrote:
> 
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> > Sent: Friday, January 11, 2019 1:28 AM
> > To: dev@dpdk.org
> > Cc: bruce.richardson@intel.com; christian.ehrhardt@canonical.com; Luca
> > Boccassi <bluca@debian.org>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] build: mention -march in pkg-config description
> >
> > Applications need to at least match DPDK's -march option to build
> > successfully due to some static inline functions in the public headers.
> >
> > This might cause problems, especially in distributions, so add a note
> > in the pkg-config description.
> >
> > Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > At the moment there are no adversely affected applications in Debian and
> > Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder
> > are stand-alone DPDK-specific binaries), but we thought that having an
> > explicit notice would be good.
> >
> >  meson.build | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meson.build b/meson.build
> > index f87dc235f..35126106a 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(),
> >  libraries: dpdk_libraries,
> >  libraries_private: dpdk_drivers + dpdk_static_libraries +
> >  ['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
> > -description: 'The Data Plane Development Kit (DPDK)',
> > +description: '''The Data Plane Development Kit (DPDK).
> > +Note that CFLAGS might contain an -march flag higher than typical baseline.
> > +This is required for a number of static inline functions in the public
> From Arm's perspective, this notice is really necessary for some extensions like LSE to work for performance.
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> 
No objection from me for more documentation.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon Jan. 28, 2019, 12:50 a.m. | #3
> > > Applications need to at least match DPDK's -march option to build
> > > successfully due to some static inline functions in the public headers.
> > >
> > > This might cause problems, especially in distributions, so add a note
> > > in the pkg-config description.
> > >
> > > Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > ---
> > > At the moment there are no adversely affected applications in Debian and
> > > Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder
> > > are stand-alone DPDK-specific binaries), but we thought that having an
> > > explicit notice would be good.
> > >
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(),
> > >  libraries: dpdk_libraries,
> > >  libraries_private: dpdk_drivers + dpdk_static_libraries +
> > >  ['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
> > > -description: 'The Data Plane Development Kit (DPDK)',
> > > +description: '''The Data Plane Development Kit (DPDK).
> > > +Note that CFLAGS might contain an -march flag higher than typical baseline.
> > > +This is required for a number of static inline functions in the public
> > From Arm's perspective, this notice is really necessary for some extensions like LSE to work for performance.
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > 
> No objection from me for more documentation.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

Patch

diff --git a/meson.build b/meson.build
index f87dc235f..35126106a 100644
--- a/meson.build
+++ b/meson.build
@@ -83,7 +83,9 @@  pkg.generate(name: meson.project_name(),
 	libraries: dpdk_libraries,
 	libraries_private: dpdk_drivers + dpdk_static_libraries +
 			['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
-	description: 'The Data Plane Development Kit (DPDK)',
+	description: '''The Data Plane Development Kit (DPDK).
+Note that CFLAGS might contain an -march flag higher than typical baseline.
+This is required for a number of static inline functions in the public headers.''',
 	subdirs: [get_option('include_subdir_arch'), '.'],
 	extra_cflags: ['-include', 'rte_config.h'] + machine_args
 )