build: fix incorrect variable name in error message

Message ID 20190110102919.53188-1-bruce.richardson@intel.com
State Accepted
Delegated to: Thomas Monjalon
Headers show
Series
  • build: fix incorrect variable name in error message
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Bruce Richardson Jan. 10, 2019, 10:29 a.m.
The variable name in the error message had an extra '_' which caused
an actual meson error when the message would otherwise be printed to
give meaningful information about what was going wrong.

Fixes: 203b61dc5e18 ("build: improve error message for missing dependency")
CC: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luca Boccassi Jan. 10, 2019, 1:10 p.m. | #1
On Thu, 2019-01-10 at 10:29 +0000, Bruce Richardson wrote:
> The variable name in the error message had an extra '_' which caused
> an actual meson error when the message would otherwise be printed to
> give meaningful information about what was going wrong.
> 
> Fixes: 203b61dc5e18 ("build: improve error message for missing
> dependency")
> CC: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  lib/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/meson.build b/lib/meson.build
> index a2dd52e17..93d7901d4 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -79,7 +79,7 @@ foreach l:libraries
>  			foreach d:deps
>  				if not is_variable('shared_rte_' +
> d)
>  					error('Missing dependency '
> + d +
> -						' for library ' +
> lib_name)
> +						' for library ' +
> libname)
>  				endif
>  				shared_deps +=
> [get_variable('shared_rte_' + d)]
>  				static_deps +=
> [get_variable('static_rte_' + d)]

Acked-by: Luca Boccassi <bluca@debian.org>
Thomas Monjalon Jan. 14, 2019, 11:05 a.m. | #2
10/01/2019 14:10, Luca Boccassi:
> On Thu, 2019-01-10 at 10:29 +0000, Bruce Richardson wrote:
> > The variable name in the error message had an extra '_' which caused
> > an actual meson error when the message would otherwise be printed to
> > give meaningful information about what was going wrong.
> > 
> > Fixes: 203b61dc5e18 ("build: improve error message for missing
> > dependency")
> > CC: stable@dpdk.org
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Acked-by: Luca Boccassi <bluca@debian.org>

Applied, thanks

Patch

diff --git a/lib/meson.build b/lib/meson.build
index a2dd52e17..93d7901d4 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -79,7 +79,7 @@  foreach l:libraries
 			foreach d:deps
 				if not is_variable('shared_rte_' + d)
 					error('Missing dependency ' + d +
-						' for library ' + lib_name)
+						' for library ' + libname)
 				endif
 				shared_deps += [get_variable('shared_rte_' + d)]
 				static_deps += [get_variable('static_rte_' + d)]