examples/power: fix intel pstate power manager

Message ID 20190108152523.39944-1-david.hunt@intel.com
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • examples/power: fix intel pstate power manager
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

David Hunt Jan. 8, 2019, 3:25 p.m.
The vm_power_manager starts by setting the environment to acpi
using rte_power_set_env(PM_ENV_ACPI_CPUFREQ). This causes a problem
starting vm_power_manager when the system is using the intel_pstate
driver. The env should be set to none, or not called at all, because
the library now auto-detects the environment to be either acpi or
intel_pstate. This patch sets the environment to none so that the
library can successfully auto-detect.

Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 examples/vm_power_manager/power_manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Jan. 14, 2019, 11:07 p.m. | #1
08/01/2019 16:25, David Hunt:
> The vm_power_manager starts by setting the environment to acpi
> using rte_power_set_env(PM_ENV_ACPI_CPUFREQ). This causes a problem
> starting vm_power_manager when the system is using the intel_pstate
> driver. The env should be set to none, or not called at all, because
> the library now auto-detects the environment to be either acpi or
> intel_pstate. This patch sets the environment to none so that the
> library can successfully auto-detect.
> 
> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>

Applied, thanks

Patch

diff --git a/examples/vm_power_manager/power_manager.c b/examples/vm_power_manager/power_manager.c
index 21dc3a727..aef832644 100644
--- a/examples/vm_power_manager/power_manager.c
+++ b/examples/vm_power_manager/power_manager.c
@@ -83,7 +83,7 @@  power_manager_init(void)
 	struct core_info *ci;
 	unsigned int max_core_num;
 
-	rte_power_set_env(PM_ENV_ACPI_CPUFREQ);
+	rte_power_set_env(PM_ENV_NOT_SET);
 
 	ci = get_core_info();
 	if (!ci) {