test/compress: improve debug trace setup
Checks
Commit Message
This removes the magic number from the assignment of the engine variable,
which is used in the debug trace.
Signed-off-by: Lee Daly <lee.daly@intel.com>
---
test/test/test_compressdev.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
Comments
> -----Original Message-----
> From: Daly, Lee
> Sent: Monday, November 19, 2018 2:53 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>
> Cc: dev@dpdk.org; Daly, Lee <lee.daly@intel.com>
> Subject: [PATCH] test/compress: improve debug trace setup
>
> This removes the magic number from the assignment of the engine variable,
> which is used in the debug trace.
>
> Signed-off-by: Lee Daly <lee.daly@intel.com>
> ---
Acked-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
On 11/27/2018 6:54 PM, Jozwiak, TomaszX wrote:
>
>> -----Original Message-----
>> From: Daly, Lee
>> Sent: Monday, November 19, 2018 2:53 PM
>> To: Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
>> <tomaszx.jozwiak@intel.com>
>> Cc: dev@dpdk.org; Daly, Lee <lee.daly@intel.com>
>> Subject: [PATCH] test/compress: improve debug trace setup
>>
>> This removes the magic number from the assignment of the engine variable,
>> which is used in the debug trace.
>>
>> Signed-off-by: Lee Daly <lee.daly@intel.com>
>> ---
> Acked-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Applied to dpdk-next-crypto
Thanks
@@ -881,11 +881,9 @@ test_deflate_comp_decomp(const char * const test_bufs[],
&compress_xforms[xform_idx]->compress;
enum rte_comp_huffman huffman_type =
compress_xform->deflate.huffman;
- char engine[22];
- if (zlib_dir == ZLIB_COMPRESS || zlib_dir == ZLIB_ALL)
- strlcpy(engine, "zlib (direct, no pmd)", 22);
- else
- strlcpy(engine, "pmd", 22);
+ char engine[] = "zlib (directly, not PMD)";
+ if (zlib_dir != ZLIB_COMPRESS || zlib_dir != ZLIB_ALL)
+ strlcpy(engine, "PMD", sizeof(engine));
RTE_LOG(DEBUG, USER1, "Buffer %u compressed by %s from %u to"
" %u bytes (level = %d, huffman = %s)\n",
@@ -1092,11 +1090,9 @@ test_deflate_comp_decomp(const char * const test_bufs[],
for (i = 0; i < num_bufs; i++) {
priv_data = (struct priv_op_data *)(ops_processed[i] + 1);
- char engine[22];
- if (zlib_dir == ZLIB_DECOMPRESS || zlib_dir == ZLIB_ALL)
- strlcpy(engine, "zlib (direct, no pmd)", 22);
- else
- strlcpy(engine, "pmd", 22);
+ char engine[] = "zlib, (directly, no PMD)";
+ if (zlib_dir != ZLIB_DECOMPRESS || zlib_dir != ZLIB_ALL)
+ strlcpy(engine, "pmd", sizeof(engine));
RTE_LOG(DEBUG, USER1,
"Buffer %u decompressed by %s from %u to %u bytes\n",
buf_idx[priv_data->orig_idx], engine,