From patchwork Sat Oct 20 08:32:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hyong Youb Kim (hyonkim)" X-Patchwork-Id: 47095 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81ADD4CC7; Sat, 20 Oct 2018 10:33:29 +0200 (CEST) Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) by dpdk.org (Postfix) with ESMTP id B396D4CA7 for ; Sat, 20 Oct 2018 10:33:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2258; q=dns/txt; s=iport; t=1540024408; x=1541234008; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=F9DtR07CHVMSFrxNQZlVla7+KmyaxxyjaL290+fCmkc=; b=Ot6EmLoToxSzIL+Ulot4ZdFPKl+17mP3TUNtEPE688WfWHrZucmxvcAN gDCiHc0JS72Or7wqwT+2x+Fq3R3Ijmjf3/MPLJznz5vLa6FhJS5Uxb7SR uqWKip3dXaBwjb5PcL7k0c7IEEU/9NLusUG6U9zsosPBAqLZKNvfJUGTe A=; X-IronPort-AV: E=Sophos;i="5.54,403,1534809600"; d="scan'208";a="188880017" Received: from rcdn-core-1.cisco.com ([173.37.93.152]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2018 08:33:27 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by rcdn-core-1.cisco.com (8.15.2/8.15.2) with ESMTP id w9K8XR9f022622; Sat, 20 Oct 2018 08:33:27 GMT Received: by cisco.com (Postfix, from userid 508933) id 865B820F2001; Sat, 20 Oct 2018 01:33:27 -0700 (PDT) From: Hyong Youb Kim To: Ferruh Yigit Cc: dev@dpdk.org, John Daley , Hyong Youb Kim Date: Sat, 20 Oct 2018 01:32:48 -0700 Message-Id: <20181020083249.8187-3-hyonkim@cisco.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20181020083249.8187-1-hyonkim@cisco.com> References: <20181020083249.8187-1-hyonkim@cisco.com> X-Outbound-SMTP-Client: 10.193.184.48, savbu-usnic-a.cisco.com X-Outbound-Node: rcdn-core-1.cisco.com Subject: [dpdk-dev] [PATCH 2/3] net/enic: add missing Tx offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The following commit has added a number of existing offload flags such as PKT_TX_IPV4 and PKT_TX_IPV6 to PKT_TX_OFFLOAD_MASK defined in rte_mbuf.h. That change breaks the enic driver's Tx prepare handler. commit ef28cfa73822 ("mbuf: fix Tx offload mask") The enic driver keeps the supported offload flags in a local variable (tx_offload_mask), which is strictly a subset of PKT_TX_OFFLOAD_MASK. This variable is then used to compute the unsupported flags (tx_offload_notsup_mask), and the Tx prepare handler (tx_pkt_prepare) uses it to reject packets with unsupported offload flags. As is, tx_offload_notsup_mask ends up containing flags like PKT_TX_IPV4 that are actually supported by the driver, which then breaks any application that uses checksum offloads and calls the Tx prepare handler. So add the flags to tx_offload_mask that the driver supports but were missing in PKT_TX_OFFLOAD_MASK. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_main.c | 6 ++---- drivers/net/enic/enic_res.c | 2 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index b2581322d..e81c3f3b7 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -1710,11 +1710,9 @@ static int enic_dev_init(struct enic *enic) DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | DEV_TX_OFFLOAD_GENEVE_TNL_TSO | DEV_TX_OFFLOAD_VXLAN_TNL_TSO; - /* - * Do not add PKT_TX_OUTER_{IPV4,IPV6} as they are not - * 'offload' flags (i.e. not part of PKT_TX_OFFLOAD_MASK). - */ enic->tx_offload_mask |= + PKT_TX_OUTER_IPV6 | + PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IP_CKSUM | PKT_TX_TUNNEL_MASK; enic->overlay_offload = true; diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c index 28ae823f4..24b2844f3 100644 --- a/drivers/net/enic/enic_res.c +++ b/drivers/net/enic/enic_res.c @@ -202,6 +202,8 @@ int enic_get_vnic_config(struct enic *enic) DEV_RX_OFFLOAD_UDP_CKSUM | DEV_RX_OFFLOAD_TCP_CKSUM; enic->tx_offload_mask = + PKT_TX_IPV6 | + PKT_TX_IPV4 | PKT_TX_VLAN | PKT_TX_IP_CKSUM | PKT_TX_L4_MASK |