Message ID | 20180817143022.12285-1-jerin.jacob@caviumnetworks.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7467FEB; Fri, 17 Aug 2018 16:30:57 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0071.outbound.protection.outlook.com [104.47.34.71]) by dpdk.org (Postfix) with ESMTP id 0CC8DF72; Fri, 17 Aug 2018 16:30:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=52tyiGxJquOCx0eaGTd2zwDX+AHOINlpfQlSjedLN90=; b=L6ttMR/gvNuV25/pu1s8E98UDZ68ZjJGRy2gnQ6OzjmglAj08SEvP5mge99LNGLvJZSLf++7invzx1hMYdEuzS9D/A4fJyjhb1nJQeuDxmKu4x9H76uIuDu5xqJGU++WMcZiVteFh3CyoLcZIKdPBpFBU+BxQog5pMTR9pTFCIg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from localhost.localdomain (115.113.156.3) by SN6PR07MB5008.namprd07.prod.outlook.com (2603:10b6:805:ad::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.19; Fri, 17 Aug 2018 14:30:49 +0000 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: dev@dpdk.org Cc: santosh.shukla@caviumnetworks.com, ferruh.yigit@intel.com, vikas.aggarwal@caviumnetworks.com, Jerin Jacob <jerin.jacob@caviumnetworks.com>, stable@dpdk.org Date: Fri, 17 Aug 2018 20:00:22 +0530 Message-Id: <20180817143022.12285-1-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: MAXPR0101CA0043.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::29) To SN6PR07MB5008.namprd07.prod.outlook.com (2603:10b6:805:ad::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 22402702-a360-4afe-78cd-08d6044e097c X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5008; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5008; 3:rQmRiQ82on/AewVBR39PgrEAXLdyZNKg4767gqsEop6lAbWugoue0ORk3NImyVz3rSL1o0cbmFLGg8mkv2aCt7tunIUnJ4Sxl/JIXUYDtvPN4bvxPEJRK/GmbJSob/suVCMw/q/TVPZLTa41h8ouABTkwwaYE3IZUdkWBVSDzAuPh/xH+FWz9LZTga351XZEA61PqdUxDip0oQkwVjSL0Qv6xM4rNXThFgl+xLRtzbsoqGNtGh5Ch4/VRYl0HsUd; 25:WKUAeJx8EQoAwaIAHan+8pA6+Eq7rcxsZrn4CU37Gi0XXLfANtHiGnhyUAFq+5R2/POdy2Q4axOJkoqJILdFwCSqVijrKP8la5ewHJ/uxeGptGW+m99qq5Ddv9cHEIjyGlQddczUi6LnqyW04FG3Qle+XEQpF+TyWoHhEvBgl+UqgsTihfLVWNCVNxmHf8m0B3+rzI9b2Y2tG+3nrVqQnbnQOYpxiPv/I89bjg5kKtGl0YOKJD+LHa5o/pz5jvpFblX7z2KTAPm5JCwoW+EAMb7+ti/dcg+TztVNxFi/4P3976NuUpBYSh6hGyOHECFbViWfNiLZ1oNmDluK4OitKw==; 31:5WGMKGMAIdzvEByn1NBMKFSAE1uKhBEEzSP/Jbfo+QF0zp1j7OHp2locexUDG1qRM4+m0aJR0M6fhpVvCe1Un4Zh1YFwD79un9+pwM58rVfjFYmd02XSqNgJbcRqN+D8zreS8g5aDRQwHVvrtR35K+k64ezLa2Mms77NvWay7Aw9jwnuHoRKHR533QJX65KX/b2OvCfthJ2uSae+FMPk5NF7v7FA4LVnSUCJFK+GC1E= X-MS-TrafficTypeDiagnostic: SN6PR07MB5008: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5008; 20:/Spezq13zrAvjrt4O+hK2YepyfnWXx7I0ApHtQRoE68N3fAaojUBW5+Wv9nC/ucAvjYah9Px+obeyzwS/eygQLbx0i2piE0d28wfiXXf0zMfJSncLireHEcXuzxeKLOZ9pZVyzoJUi8GrxgXbzXJ5mKNKuItLKNufsDRTPpFa+jpIbALr4uR4NMIc8f9geRhlSy17uM3gCTVvhBoBAZGET424fbqa4PjOp4pCWbKG4duo4rZaLlVBf+0iNvqv8lbj8pdihFR4vuTU8eMNrF6uifggdMTl4n/Zs1SVXa+rRCrwL2ro1U0lDPia9EQedYuZawRnb1VpPTH0daSE47a5viz1Z+KNxdjhf743aXZPf1H4cnTTmoPmvARBRJgxpxHULVjFfQAxei4BJ0OGfETMHDvVix2XYD/OXKmBOcrdzCqLD8WIkph7eQMLXqWfKsJzZZ4CoqWHuHG9HZ16VK8L7Ox92w0gYCoOCAfl1XXvUMLwQxoG98BAw3Z9Yf4xEUr3HIH2nTih5Ss1b0T+7gJ9OoA6SBSx/tYQH7qk62DlePA1iliraKMbJslUY594+hHLvDaWAqndc8okPOJmMyAy96uhJo9Kb/WhYF02DqrcgU=; 4:Ifq18+6AJqjVY2oYWOTSvAgIsYbXIMRe8MsCFfT66+akmn7awpH4/pemBind6+yVVpdGikAxcH3YVhWtHHx1ELbud2v+ZXTUDvhdfZnk1r1mXRW20xRkwpy9qBiREucgaSgVcyvpsDucaqw5O6tgqagfnwebCr7YNcGv1o2OMp3+10T+HL/NIhavy01kQclMTW49gEy7gVXQ7JT55t7Ru0e7s6A1ZXmwTra4OG1VBCTIA3mXcNRl4yA+BggjVBNLPSnvH1XZlTO74f76vy5TTQ== X-Microsoft-Antispam-PRVS: <SN6PR07MB500834E7786FC2A4A40531A4E33D0@SN6PR07MB5008.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(3002001)(10201501046)(93006095)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699016); SRVR:SN6PR07MB5008; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5008; X-Forefront-PRVS: 076777155F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(366004)(376002)(136003)(39860400002)(346002)(22813001)(189003)(199004)(1076002)(2906002)(42882007)(68736007)(50466002)(48376002)(6666003)(1857600001)(47776003)(7736002)(305945005)(476003)(2351001)(2616005)(956004)(72206003)(66066001)(97736004)(8936002)(25786009)(5660300001)(6916009)(50226002)(478600001)(2361001)(36756003)(53936002)(386003)(55236004)(4326008)(52116002)(6506007)(81166006)(486006)(8676002)(26005)(81156014)(6512007)(106356001)(105586002)(44832011)(316002)(6486002)(14444005)(3846002)(16586007)(16526019)(186003)(51416003)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5008; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB5008; 23:w341qdEdX8UamgSwzq4QmxewtgC7JgFgj5IKEabk0?= YUhKCN833BwNnu3KNBtDDKzzzIcmm13uRADv3or4vNZu5X8Hi0NRe++8MnMgR/ywRruetJorTWnkD+3zqy5ziUpr56HH/4M/eSilTX/a9dWxg+FgdRp5S7WZEwNou0y1IUML0oQD5WGFgVKqeRPrey1Rhn6M6r1fJaqBWCjXDW/S2wkvGGlvN4yntv7enOUM5ch2rvTKMq7xL6Txf48Orp81umg+zA875wcxVgGKzzWHmU1eLb5HaBxSkibOoga4TTpDo9klhu3cagMSQRjwq8TSmLX6qptsxEznhPw5BdpO8/o2c0UYsaMe6271vrVfmUqs7VRrMe61HEv6L+vlHHpVS9OZrxll8kxgLksg2ba2grhJeyFRx/O3O5xk+GdutBYzN9W8b8moKI2e2B15z9+0WTZj+BWl/4t3I8SM59UntyM1X60wNRwaLsyY9YcKCVuL4ADGnJS/n8vXIlJGyxPrkYLS+RYnI2tiZ3apWO0VvbYa9m5F/jqGhVPCZGXPUNd/3zRTs7RK2q97Tm4ZfKTK8adKsm+anWMiDTM6Ns9tJKrC5rEftWKfN6XZdxAaQN/FywpLsZXFYF4g5P87ngpb/JPKIo34xalODedWLaUZA/5rRekJBcmOFJavbfx00URTWi0pp2PH1CyL0W4vKLOanqYGoxSym/K7jjF5rG6T8s7uMKYwQ4rlI6fy0hCye1yyHbHo0UhUu7lpQFEousu4XJVGMTjrcIJosk1OwRMB8+8O+uKQu+VJ5VT0LHYvC2M7C4uVUyg4H74JsPUVIb62MQa/9qe1rdQMbQYOUIGKx6tjWZZVUBUYzJErGyzPgrzVMQm/OmeaoZkAknYNkL/d4lNzpo9wITT0qPOP660ynB4pP8Z3fMzeSxvpB48Zrm5lof0ygXtvnWNSIf7jXTi16qEs2qQJLHLhg+olPb6qE2lMKhfejingdqoiI+7hkK7ZRrQD/gaAmgjvPJxk0RLww1lBNavuaXfU4AtL8L4fW0nXtuZSqcWXg8wtuXvnes8T69BYnYrTb+nIIrRhJilvhMtfSyxKaj1XpAQxVpCcVti5Vm+X78Dywjk8rXyThuPqIB8WlZKq6dCXfeRFmE+Msb9CjfUCj5gPV0jidVP6qi7m5rtNO/YTu6h5FIIC/FPTG6lqkAgpkabD7MakfJOz0HoUmoCCInnkbauS9wi1nyLNjMS02fW336ezHARn3Vpn9e+g7wTfO6RBxLk7uyLhGuUrzKP1BSdTgaLfH+pqWo/jta409FBlUnyWaEtOn0= X-Microsoft-Antispam-Message-Info: X+mXNgZcDgmU3DAvcEV3nhLEmH2a99Reb05ypHTxyWGhzH/pnusT82Q4Ekudk04EuGQnIqJTUnYyBQjMYj8eGM+j9cb950oBxTO4PJ5+rUBgkDgNR/11Yeum/AxHHgSY3jkMFVthCG6MKeeVaUGZXaQinBYdQZMw+7cTAmt5uHkfBdOBaxVGPXBvd1lw4q/OY2UV/Tyu6V5Dja725nOMYk8STNsWLIq06Zn4aRbfpX/HVIC4hjdgA11ZaqqYKkCaTFcWHM1UsMyu/a6zFHy92AsJG5BDBhmmwguxbWMv3903OiS89qe98ret7Z9qEdWvyJ+8E1X4xBE0B/w8CAige0oWWm/oUCmvY96CpWxmsvU= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5008; 6:R9YFIBlzRQDgX1kaaubs9PL3hqbuUfxMqdEdUojlimRtSVZHkpDUBKhm6fRGVcUSsXTQIhMDZBXdszImF7SYN36HTpVGYP0iKR0BNnB5im8kY9N+XUgpWByI/1E9VmMnKdVYBAMnvoR0tXa2oo8ASr1GiWntMsNM0D5sZEB0APKJev8gpo7KgTHgsagrYlLNNPHm84e54jUzEyVd21iFZzSNb8mCbFAn483NlB8RpAYGI6QE2eBaMZhokGBnl5a9DRoxXC6fEIQWVVkWPRPaT0BUHEVWNeYP1s9iKkVUema40JaKKFWMscu4NZtFlKwjgQ8N5cM6L5hSW4iwZEL4x3boCiZm5ivjCDfVeWlgBHmaoLPHrVNMFyd3jSaLn5gv00759xkEobjkvsZp8Wi88OZmAq0KGk/3iQjtJbaQK+epq6+uQMqCpVQp0NlzIi8UT6Ti8WdY2y782LwUOx7fZw==; 5:rf2HHAqCCK7f2kPDeZ3Ixzxr4p3lTvL4rQXJyTp9uDCtam0+xs5ibUDqNCV6WBkNwU93W/Tc5JPd+9+h8wXiYzzf+X4K2OTAhOltjhbNVO8AqM+Y8RTknDj7PByYhla5mZjg369kbwVVFWLkiGnfeT/4/7ye1bhINnw0e+RkcGc=; 7:MEoUl77atVdQYBbIPraIfSEsZsicOvNOsEhMzcXXXo4r+u7Plkg6WPClw85BtSdUELdxV+gBGnNrx79yLJfnwVuTwm8oDaRtvIEeEZNUgzMmHFp4+ppbiElDB4avGB/I5sMr/AisZY4GDasl3DhZuPMQDsMQ82MtPMxfGIdPTE7kdChOHX09lj0SGBHNd9lU4f010oaY/7AcKUZpOP0mR98RITySEA4HCIFVXpgcCY3OpmWyhyAelc1pDo+k4tFx SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2018 14:30:49.9803 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22402702-a360-4afe-78cd-08d6044e097c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5008 Subject: [dpdk-dev] [PATCH] net/octeontx: fix packet corruption on Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
net/octeontx: fix packet corruption on Tx
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Jerin Jacob
Aug. 17, 2018, 2:30 p.m. UTC
LMTST does not guarantee packet content get synced with L2C when
HW access the packet for transmitting.
Adding coherent IO write barrier will make sure HW sees the correct
packet if its modified.
Fixes: 9e747589bd4c ("net/octeontx: add packet transmit burst function")
Cc: stable@dpdk.org
Reported-by: Vikas Aggarwal <vikas.aggarwal@caviumnetworks.com>
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/net/octeontx/octeontx_rxtx.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Friday 17 August 2018 08:00 PM, Jerin Jacob wrote: > LMTST does not guarantee packet content get synced with L2C when > HW access the packet for transmitting. > > Adding coherent IO write barrier will make sure HW sees the correct > packet if its modified. > > Fixes: 9e747589bd4c ("net/octeontx: add packet transmit burst function") > Cc: stable@dpdk.org > > Reported-by: Vikas Aggarwal <vikas.aggarwal@caviumnetworks.com> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > --- Acked-by: Santosh Shukla <Santosh.Shukla@caviumnetworks.com>
On 8/17/2018 5:06 PM, santosh wrote: > > On Friday 17 August 2018 08:00 PM, Jerin Jacob wrote: >> LMTST does not guarantee packet content get synced with L2C when >> HW access the packet for transmitting. >> >> Adding coherent IO write barrier will make sure HW sees the correct >> packet if its modified. >> >> Fixes: 9e747589bd4c ("net/octeontx: add packet transmit burst function") >> Cc: stable@dpdk.org >> >> Reported-by: Vikas Aggarwal <vikas.aggarwal@caviumnetworks.com> >> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> >> --- > > Acked-by: Santosh Shukla <Santosh.Shukla@caviumnetworks.com> > Applied to dpdk-next-net/master, thanks.
diff --git a/drivers/net/octeontx/octeontx_rxtx.c b/drivers/net/octeontx/octeontx_rxtx.c index a9149b4e1..f861313e6 100644 --- a/drivers/net/octeontx/octeontx_rxtx.c +++ b/drivers/net/octeontx/octeontx_rxtx.c @@ -63,6 +63,7 @@ octeontx_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) count = 0; + rte_cio_wmb(); while (count < nb_pkts) { res = __octeontx_xmit_pkts(dq->lmtline_va, dq->ioreg_va, dq->fc_status_va,