doc: add cross compile part for sample applications

Message ID 1534263514-9816-1-git-send-email-gavin.hu@arm.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series doc: add cross compile part for sample applications |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Gavin Hu Aug. 14, 2018, 4:18 p.m. UTC
  Fixes: 7cacb05655 ("doc: add generic build instructions for sample apps")
Cc: stable@dpdk.org

Signed-off-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
 doc/guides/sample_app_ug/compiling.rst | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
  

Comments

Thomas Monjalon Sept. 14, 2018, 2:55 p.m. UTC | #1
14/08/2018 18:18, Gavin Hu:
> +For cross compiling the sample application(s), please append 'CC=$(CROSS_COMPILER)' to the 'make' command.

As you can see in doc/build-sdk-quick.txt, you should use CROSS=
for cross compilation.

> +For example:
> +        export CROSS_COMPILER=aarch64-linux-gnu-gcc
> +        make -C examples CC=$(CROSS_COMPILER)

It should be
	make -C examples CROSS=aarch64-linux-gnu-

Please would you like to make a patch v2 ?
  
Gavin Hu Sept. 17, 2018, 2:16 a.m. UTC | #2
Hi Thomas,

V2 was submitted, thanks for review!
http://patchwork.dpdk.org/patch/44768/

Best Regards,
Gavin

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, September 14, 2018 10:55 PM
> To: Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>
> Cc: dev@dpdk.org; Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: add cross compile part for sample
> applications
>
> 14/08/2018 18:18, Gavin Hu:
> > +For cross compiling the sample application(s), please append
> 'CC=$(CROSS_COMPILER)' to the 'make' command.
>
> As you can see in doc/build-sdk-quick.txt, you should use CROSS= for cross
> compilation.
>
> > +For example:
> > +        export CROSS_COMPILER=aarch64-linux-gnu-gcc
> > +        make -C examples CC=$(CROSS_COMPILER)
>
> It should be
> make -C examples CROSS=aarch64-linux-gnu-
>
> Please would you like to make a patch v2 ?
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
  

Patch

diff --git a/doc/guides/sample_app_ug/compiling.rst b/doc/guides/sample_app_ug/compiling.rst
index a2d75ed..c8cf1bd 100644
--- a/doc/guides/sample_app_ug/compiling.rst
+++ b/doc/guides/sample_app_ug/compiling.rst
@@ -9,7 +9,6 @@  This section explains how to compile the DPDK sample applications.
 To compile all the sample applications
 --------------------------------------
 
-
 Set the path to DPDK source code if its not set:
 
     .. code-block:: console
@@ -93,3 +92,18 @@  Build the application:
 
         export RTE_TARGET=build
         make
+
+To cross compile the sample application(s)
+------------------------------------------
+
+For cross compiling the sample application(s), please append 'CC=$(CROSS_COMPILER)' to the 'make' command.
+For example:
+
+    .. code-block:: console
+
+        export RTE_TARGET=build
+        export RTE_SDK=/path/to/rte_sdk
+        export CROSS_COMPILER=aarch64-linux-gnu-gcc
+        make -C examples CC=$(CROSS_COMPILER)
+               or
+        make CC=$(CROSS_COMPILER)