From patchwork Thu Jun 7 09:43:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 40730 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 675171B3E9; Thu, 7 Jun 2018 11:44:01 +0200 (CEST) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 773E71B3E7 for ; Thu, 7 Jun 2018 11:43:59 +0200 (CEST) Received: by mail-lf0-f65.google.com with SMTP id d24-v6so13634370lfa.8 for ; Thu, 07 Jun 2018 02:43:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FrOfw3+PIOrZ2QbcpvWeDhVbiIJpYPjUagrfULSx9lc=; b=yT4jvoyZz7iJLOsU5AAW/47iBedTh97bpanHlXUQuUHc9EBYJ/pPVXEdrrsRhSGoip Yw2oPq2Zjd96XpaUKm0Mq5rK5XxT54Blb33L899SUhraoDDtOprUIzRw3ZSv62ySA+9T mliyEr8TlcVUuDO+jFIHYAjN+uF4eKmfgFAv6w+a1eQv/kH05xGk44n6GKuYdF62knmo vn4+u6g2t5jsX+ZlIm4BDEmsdsg0KGnVpXnmHW/2Vo8q9wlH+o4F9Kz/SoVSVF5mRBCf RR4E0k2aC9NbogKVN9Urr6FyWHP09PFXWXl/+UXW3o3bSqn/GLQRLB3BIZgpYLiBCr6H a6aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FrOfw3+PIOrZ2QbcpvWeDhVbiIJpYPjUagrfULSx9lc=; b=KoL8OAaYyX44m8JyZOMJCt7PUDtc/FvLelRHJWMSN2dgDIlXbqUm6ZcaqN91qNOF5b z6D2FpcIltb6XzyiEM4iQsFJLU70iuoY5Z3y0Hm4SN6SEgomKxoAzs4LzQnl0QKifn9y wb2r6KxCCc6JOyDdp469QsNHfRMA92+fQYYFMgOkK8l6NqBpDw8X4EMj8885K+3m3m/t f8ZPpfHmKlGoyZCimvs6MQo+P+TX05v/Fv4/OZWeR9Vn34JANpWCuJcSylQAhecl+y5u YJRfnaP60sfYZ9MWKFKzWSd46cxxY82Ho3C96ws1QMIwF33rkrjerVNiAD6ImrkL7YRz ooGw== X-Gm-Message-State: APt69E2AaiUfmhkB1EuGtjybg7ytXSD2Kate+4623uUlH/WGLguXits9 /BkCkPn7yvLwqLVqjCTNHZBaNg== X-Google-Smtp-Source: ADUXVKKj5/M2GOQJlIHjEF5xbDuAA0cH27ntqcup8pT2/Pdq8vZdFzVel/jwO8/VUxcx0Y2y/WQ8iA== X-Received: by 2002:a2e:8350:: with SMTP id l16-v6mr944118ljh.7.1528364638333; Thu, 07 Jun 2018 02:43:58 -0700 (PDT) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id p28-v6sm3612368lfh.24.2018.06.07.02.43.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jun 2018 02:43:55 -0700 (PDT) From: Michal Krawczyk To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik Date: Thu, 7 Jun 2018 11:43:12 +0200 Message-Id: <20180607094322.14312-17-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180607094322.14312-1-mk@semihalf.com> References: <20180607094322.14312-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH v3 17/27] net/ena: unimplemented handler error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik Enable AENQ FATAL_ERROR and WARNING callbacks by setting flags in aenq_groups. They are handled by "unimplemented handler". If unimplemented handler is called, error is logged. Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index a88de2eca..5f4956078 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1415,7 +1415,9 @@ static int ena_device_init(struct ena_com_dev *ena_dev, aenq_groups = BIT(ENA_ADMIN_LINK_CHANGE) | BIT(ENA_ADMIN_NOTIFICATION) | - BIT(ENA_ADMIN_KEEP_ALIVE); + BIT(ENA_ADMIN_KEEP_ALIVE) | + BIT(ENA_ADMIN_FATAL_ERROR) | + BIT(ENA_ADMIN_WARNING); aenq_groups &= get_feat_ctx->aenq.supported_groups; rc = ena_com_set_aenq_config(ena_dev, aenq_groups); @@ -2196,7 +2198,8 @@ static void ena_keep_alive(void *adapter_data, static void unimplemented_aenq_handler(__rte_unused void *data, __rte_unused struct ena_admin_aenq_entry *aenq_e) { - // Unimplemented handler + RTE_LOG(ERR, PMD, "Unknown event was received or event with " + "unimplemented handler\n"); } static struct ena_aenq_handlers aenq_handlers = {