From patchwork Thu Jun 7 09:42:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 40715 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 319CB1B172; Thu, 7 Jun 2018 11:43:37 +0200 (CEST) Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by dpdk.org (Postfix) with ESMTP id 1A3E41B052 for ; Thu, 7 Jun 2018 11:43:33 +0200 (CEST) Received: by mail-lf0-f67.google.com with SMTP id i15-v6so3336620lfc.2 for ; Thu, 07 Jun 2018 02:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SKw514H8Bvh6MK508oguM3Pu0V1eoGhzBBXemJPRnmo=; b=NjKfoql1OkS+vhVQkkrXj+mrLqw+IjeZfZoQcOWJCkHyfybxZHBCpWEo+pD5DtQdys hTJbTR+addrLpGagd1invu6VlTaj5wQnScgoWlgTLRhYBnfNxtHub0JnIvsMqD5hZKi4 LMlGStJ2p9ZZAAGmuHQIvWgpEi8I8Br/ervWQZW32LR5IYs9uh4qjnkaQKRcbmUPxvhv h4pAbOOrDY1juF7TAKf0+fwEOAAZEKsGsUA2utJylEiMz3Ytogbq9T450jmSp6Aask1n 3cuf6o0akTuy4pMa7rJwC+t1bOvKCJr8Gu67SQZvh5cBbRK5ckK/XXD/GXbX0AStDbdS Cz2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SKw514H8Bvh6MK508oguM3Pu0V1eoGhzBBXemJPRnmo=; b=FztkB0Z1PkHkuydotvFeom7d2iDgNZjtne7ofRP5duB8Vh35LhMStW3OXU+J6GHUGB Osu0hk1Rsje4Wn0afs/LOZgOfGgzh/c8sQssR/tFgt6jod+ck1cBrIDCa1ZavhMZ7S/K D6o8szCRRqRryXOU/bOECkJEeZrvaKOLJVvNUiKVSpuEfE/K06zcQ6QI/iHoU2B5H7A2 5Un556Rt0mqi+jct4fF2K3iZGZi0jlT7gU+QwfNtCFJDJqDtbCnrHq/U9nc0eVeAfVlW 865zPsBI+P30e5UzBMmH9DE0zgJgm4CLUNqvvYwxskqHcKdBXOajhYJ0l+asDIBZnlv/ h/nA== X-Gm-Message-State: APt69E2JzOmjqL6eLfK3bQEwM3iYHOPDbvck/x0m6KL2AHSwiuexwdLR iPXFkzh0wOK6kx4DloF3GnStOg== X-Google-Smtp-Source: ADUXVKIp7jROScNHerhhzM+a0wGIR4glLIot6j3QBF6EYLX7TH+Me/49aZiUbckz4/sHqF8L20SCNg== X-Received: by 2002:a2e:9a44:: with SMTP id k4-v6mr961199ljj.17.1528364612273; Thu, 07 Jun 2018 02:43:32 -0700 (PDT) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id p28-v6sm3612368lfh.24.2018.06.07.02.43.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jun 2018 02:43:31 -0700 (PDT) From: Michal Krawczyk To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik Date: Thu, 7 Jun 2018 11:42:58 +0200 Message-Id: <20180607094322.14312-3-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180607094322.14312-1-mk@semihalf.com> References: <20180607094322.14312-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH v3 03/27] net/ena: remove support of legacy LLQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik The legacy LLQ should no longer be supported by the drivers, as this API is deprecated. Because of that, it was removed from the driver. Signed-off-by: Rafal Kozik Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 29 +++++------------------------ 1 file changed, 5 insertions(+), 24 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 71d6838a0..f4b137a83 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1327,16 +1327,11 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) adapter->regs = pci_dev->mem_resource[ENA_REGS_BAR].addr; adapter->dev_mem_base = pci_dev->mem_resource[ENA_MEM_BAR].addr; - /* Present ENA_MEM_BAR indicates available LLQ mode. - * Use corresponding policy - */ - if (adapter->dev_mem_base) - ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_DEV; - else if (adapter->regs) - ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; - else + if (!adapter->regs) { PMD_INIT_LOG(CRIT, "Failed to access registers BAR(%d)", ENA_REGS_BAR); + return -ENXIO; + } ena_dev->reg_bar = adapter->regs; ena_dev->dmadev = adapter->pdev; @@ -1353,22 +1348,8 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) return -1; } - if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV) { - if (get_feat_ctx.max_queues.max_llq_num == 0) { - PMD_INIT_LOG(ERR, - "Trying to use LLQ but llq_num is 0.\n" - "Fall back into regular queues."); - ena_dev->tx_mem_queue_type = - ENA_ADMIN_PLACEMENT_POLICY_HOST; - adapter->num_queues = - get_feat_ctx.max_queues.max_sq_num; - } else { - adapter->num_queues = - get_feat_ctx.max_queues.max_llq_num; - } - } else { - adapter->num_queues = get_feat_ctx.max_queues.max_sq_num; - } + ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; + adapter->num_queues = get_feat_ctx.max_queues.max_sq_num; queue_size = ena_calc_queue_size(ena_dev, &get_feat_ctx); if ((queue_size <= 0) || (adapter->num_queues <= 0))