diff mbox

[dpdk-dev] net/ark: Add missing call to probe_finish for first device

Message ID 1526930947-17227-1-git-send-email-ed.czeck@atomicrules.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ed Czeck May 21, 2018, 7:29 p.m. UTC 
  Fix on commit fbe90cdd776c ("ethdev: add probing finish function")

Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
---
 drivers/net/ark/ark_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

John Miller May 21, 2018, 7:42 p.m. UTC | #1 
> On May 21, 2018, at 3:29 PM, Ed Czeck <ed.czeck@atomicrules.com> wrote:
> 
> Fix on commit fbe90cdd776c ("ethdev: add probing finish function")
> 
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
> ---
> drivers/net/ark/ark_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index 62e4fd3..834d8a9 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -390,6 +390,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
> 		if (p == 0) {
> 			/* First port is already allocated by DPDK */
> 			eth_dev = ark->eth_dev;
> +			rte_eth_dev_probing_finish(eth_dev);
> 			continue;
> 		}
> 
> -- 
> 2.7.4
> 

Acked-by: John Miller  <john.miller@atomicrules.com <mailto:john.miller@atomicrules.com>>
Thomas Monjalon May 21, 2018, 9:26 p.m. UTC | #2 
21/05/2018 21:42, john miller:
> 
> > On May 21, 2018, at 3:29 PM, Ed Czeck <ed.czeck@atomicrules.com> wrote:
> > 
> > Fix on commit fbe90cdd776c ("ethdev: add probing finish function")

Fixes: fbe90cdd776c ("ethdev: add probing finish function")

> > Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
> 
> Acked-by: John Miller  <john.miller@atomicrules.com <mailto:john.miller@atomicrules.com>>

Reviewed-by: Thomas Monjalon <thomas@monjalon.net>

Suggested title: fix call to probing finish function for first port
Ferruh Yigit May 22, 2018, 9:52 a.m. UTC | #3 
On 5/21/2018 10:26 PM, Thomas Monjalon wrote:
> 21/05/2018 21:42, john miller:
>>
>>> On May 21, 2018, at 3:29 PM, Ed Czeck <ed.czeck@atomicrules.com> wrote:
>>>
>>> Fix on commit fbe90cdd776c ("ethdev: add probing finish function")
> 
> Fixes: fbe90cdd776c ("ethdev: add probing finish function")
> 
>>> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
>>
>> Acked-by: John Miller  <john.miller@atomicrules.com <mailto:john.miller@atomicrules.com>>
> 
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Suggested title: fix call to probing finish function for first port

Applied to dpdk-next-net/master, thanks.

(suggested title applied)
diff mbox

Patch

diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 62e4fd3..834d8a9 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -390,6 +390,7 @@  eth_ark_dev_init(struct rte_eth_dev *dev)
 		if (p == 0) {
 			/* First port is already allocated by DPDK */
 			eth_dev = ark->eth_dev;
+			rte_eth_dev_probing_finish(eth_dev);
 			continue;
 		}