[dpdk-dev] nfp: restore the unlink operation
diff mbox

Message ID 20180514144658.9671-1-aconole@redhat.com
State Not Applicable, archived
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Aaron Conole May 14, 2018, 2:46 p.m. UTC
For the stable versions of DPDK, the NFP driver's NSP user space
driver was modified to account for non-root usage.  When that
happened, commit 515933ad8385 ("nfp: allow for non-root user")
inadvertently removed the unlink() call.

Fixes: 515933ad8385 ("nfp: allow for non-root user")
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: Luca Boccassi <bluca@debian.org>
Cc: Eelco Chaudron <echaudro@redhat.com>
Cc: Yuanhan Liu <yliu@fridaylinux.org>
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 drivers/net/nfp/nfp_nfpu.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Eelco Chaudron May 14, 2018, 3:09 p.m. UTC | #1
On 14/05/18 16:46, Aaron Conole wrote:
> For the stable versions of DPDK, the NFP driver's NSP user space
> driver was modified to account for non-root usage.  When that
> happened, commit 515933ad8385 ("nfp: allow for non-root user")
> inadvertently removed the unlink() call.

Acked-by: Eelco Chaudron <echaudro@redhat.com>
Alejandro Lucero May 18, 2018, 8:45 a.m. UTC | #2
Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>

On Mon, May 14, 2018 at 4:09 PM, Eelco Chaudron <echaudro@redhat.com> wrote:

> On 14/05/18 16:46, Aaron Conole wrote:
>
>> For the stable versions of DPDK, the NFP driver's NSP user space
>> driver was modified to account for non-root usage.  When that
>> happened, commit 515933ad8385 ("nfp: allow for non-root user")
>> inadvertently removed the unlink() call.
>>
>
> Acked-by: Eelco Chaudron <echaudro@redhat.com>
>
>
Ferruh Yigit May 18, 2018, 9:48 a.m. UTC | #3
On 5/14/2018 3:46 PM, Aaron Conole wrote:
> For the stable versions of DPDK, the NFP driver's NSP user space
> driver was modified to account for non-root usage.  When that
> happened, commit 515933ad8385 ("nfp: allow for non-root user")
> inadvertently removed the unlink() call.

This patch is for stable tree.

Which stable branches are effected? Only 18.02?


And a generic stable tree question, is there a easy way to find out which stable
versions has a fix? For this example which versions get "nfp: allow for non-root
user" fix?

> 
> Fixes: 515933ad8385 ("nfp: allow for non-root user")
> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
> Cc: Luca Boccassi <bluca@debian.org>
> Cc: Eelco Chaudron <echaudro@redhat.com>
> Cc: Yuanhan Liu <yliu@fridaylinux.org>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
>  drivers/net/nfp/nfp_nfpu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
> index ae2e07220..c003640c7 100644
> --- a/drivers/net/nfp/nfp_nfpu.c
> +++ b/drivers/net/nfp/nfp_nfpu.c
> @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)
>  	close(desc->lock);
>  
>  	nspu_get_lockfile_path(lockname, sizeof(lockname), desc);
> +	unlink(lockname);
>  	return 0;
>  }
>
Aaron Conole May 18, 2018, 1:11 p.m. UTC | #4
Ferruh Yigit <ferruh.yigit@intel.com> writes:

> On 5/14/2018 3:46 PM, Aaron Conole wrote:
>> For the stable versions of DPDK, the NFP driver's NSP user space
>> driver was modified to account for non-root usage.  When that
>> happened, commit 515933ad8385 ("nfp: allow for non-root user")
>> inadvertently removed the unlink() call.
>
> This patch is for stable tree.
>
> Which stable branches are effected? Only 18.02?

At this time, just 18.02

>
> And a generic stable tree question, is there a easy way to find out which stable
> versions has a fix? For this example which versions get "nfp: allow for non-root
> user" fix?

I'm not sure if there is something in
http://dpdk.org/browse/tools/stable-scripts/ that might automatically
find the dependency?

>> 
>> Fixes: 515933ad8385 ("nfp: allow for non-root user")
>> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
>> Cc: Luca Boccassi <bluca@debian.org>
>> Cc: Eelco Chaudron <echaudro@redhat.com>
>> Cc: Yuanhan Liu <yliu@fridaylinux.org>
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
>> ---
>>  drivers/net/nfp/nfp_nfpu.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
>> index ae2e07220..c003640c7 100644
>> --- a/drivers/net/nfp/nfp_nfpu.c
>> +++ b/drivers/net/nfp/nfp_nfpu.c
>> @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)
>>  	close(desc->lock);
>>  
>>  	nspu_get_lockfile_path(lockname, sizeof(lockname), desc);
>> +	unlink(lockname);
>>  	return 0;
>>  }
>>
Luca Boccassi May 18, 2018, 1:22 p.m. UTC | #5
On Mon, 2018-05-14 at 10:46 -0400, Aaron Conole wrote:
> For the stable versions of DPDK, the NFP driver's NSP user space
> driver was modified to account for non-root usage.  When that
> happened, commit 515933ad8385 ("nfp: allow for non-root user")
> inadvertently removed the unlink() call.
> 
> Fixes: 515933ad8385 ("nfp: allow for non-root user")
> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
> Cc: Luca Boccassi <bluca@debian.org>
> Cc: Eelco Chaudron <echaudro@redhat.com>
> Cc: Yuanhan Liu <yliu@fridaylinux.org>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
>  drivers/net/nfp/nfp_nfpu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
> index ae2e07220..c003640c7 100644
> --- a/drivers/net/nfp/nfp_nfpu.c
> +++ b/drivers/net/nfp/nfp_nfpu.c
> @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)
>  	close(desc->lock);
>  
>  	nspu_get_lockfile_path(lockname, sizeof(lockname), desc);
> +	unlink(lockname);
>  	return 0;
>  }

Applied and pushed to stable/18.02

Next time, please send patches that are only for stable to stable@dpdk.
org and do not include dev@dpdk.org
Also use --subject-prefix='PATCH <branch>' so that we can understand
for which branches a patch is
Aaron Conole May 18, 2018, 3:57 p.m. UTC | #6
Luca Boccassi <bluca@debian.org> writes:

> On Mon, 2018-05-14 at 10:46 -0400, Aaron Conole wrote:
>> For the stable versions of DPDK, the NFP driver's NSP user space
>> driver was modified to account for non-root usage.  When that
>> happened, commit 515933ad8385 ("nfp: allow for non-root user")
>> inadvertently removed the unlink() call.
>> 
>> Fixes: 515933ad8385 ("nfp: allow for non-root user")
>> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
>> Cc: Luca Boccassi <bluca@debian.org>
>> Cc: Eelco Chaudron <echaudro@redhat.com>
>> Cc: Yuanhan Liu <yliu@fridaylinux.org>
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
>> ---
>>  drivers/net/nfp/nfp_nfpu.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
>> index ae2e07220..c003640c7 100644
>> --- a/drivers/net/nfp/nfp_nfpu.c
>> +++ b/drivers/net/nfp/nfp_nfpu.c
>> @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)
>>  	close(desc->lock);
>>  
>>  	nspu_get_lockfile_path(lockname, sizeof(lockname), desc);
>> +	unlink(lockname);
>>  	return 0;
>>  }
>
> Applied and pushed to stable/18.02

Thanks, Luca!

> Next time, please send patches that are only for stable to stable@dpdk.
> org and do not include dev@dpdk.org

Will do.

> Also use --subject-prefix='PATCH <branch>' so that we can understand
> for which branches a patch is

Thanks.  I'll keep this in mind.

Patch
diff mbox

diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
index ae2e07220..c003640c7 100644
--- a/drivers/net/nfp/nfp_nfpu.c
+++ b/drivers/net/nfp/nfp_nfpu.c
@@ -121,5 +121,6 @@  nfpu_close(nfpu_desc_t *desc)
 	close(desc->lock);
 
 	nspu_get_lockfile_path(lockname, sizeof(lockname), desc);
+	unlink(lockname);
 	return 0;
 }