[dpdk-dev] net/enic: fix CRC strip offload capability
diff mbox

Message ID 20180514075620.10848-1-hyonkim@cisco.com
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hyong Youb Kim (hyonkim) May 14, 2018, 7:56 a.m. UTC
The NIC always strips CRC, so advertise the CRC strip offload in
rx_offload_capa.

Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE")

Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
---
 drivers/net/enic/enic_res.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Hyong Youb Kim (hyonkim) May 14, 2018, 10:50 a.m. UTC | #1
On Mon, May 14, 2018 at 12:56:20AM -0700, Hyong Youb Kim wrote:
> The NIC always strips CRC, so advertise the CRC strip offload in
> rx_offload_capa.

Hi Ferruh,

Can you discard this patch? We are finding more offload flags are
missing. Will submit a new patch that sets them all instead of one patch
per flag. Sorry for the trouble.

Thanks..
-Hyong
Ferruh Yigit May 14, 2018, 11:02 a.m. UTC | #2
On 5/14/2018 11:50 AM, Hyong Youb Kim wrote:
> On Mon, May 14, 2018 at 12:56:20AM -0700, Hyong Youb Kim wrote:
>> The NIC always strips CRC, so advertise the CRC strip offload in
>> rx_offload_capa.
> 
> Hi Ferruh,
> 
> Can you discard this patch? We are finding more offload flags are
> missing. Will submit a new patch that sets them all instead of one patch
> per flag.

OK, please provide new version.

Patch
diff mbox

diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c
index a504de5d5..fc60d8b77 100644
--- a/drivers/net/enic/enic_res.c
+++ b/drivers/net/enic/enic_res.c
@@ -188,6 +188,7 @@  int enic_get_vnic_config(struct enic *enic)
 		DEV_TX_OFFLOAD_TCP_CKSUM |
 		DEV_TX_OFFLOAD_TCP_TSO;
 	enic->rx_offload_capa =
+		DEV_RX_OFFLOAD_CRC_STRIP |
 		DEV_RX_OFFLOAD_VLAN_STRIP |
 		DEV_RX_OFFLOAD_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_UDP_CKSUM |