diff mbox

[dpdk-dev,memnic,3/7] pmd: use helper macros

Message ID 7F861DC0615E0C47A872E6F3C5FCDDBD011A9915@BPXM14GP.gisp.nec.co.jp (mailing list archive)
State Superseded, archived
Headers

Commit Message

Hiroshi Shimamoto Sept. 11, 2014, 7:47 a.m. UTC 
  From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

Do not touch pktmbuf directly.

Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()
to access the property.

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
 pmd/pmd_memnic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon Sept. 24, 2014, 3:14 p.m. UTC | #1 
2014-09-11 07:47, Hiroshi Shimamoto:
> Do not touch pktmbuf directly.
> 
> Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()
> to access the property.

I guess this change is for compatibility with DPDK 1.8.
Does it have an impact on performance?
Hiroshi Shimamoto Sept. 25, 2014, 12:01 a.m. UTC | #2 
> Subject: Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros
> 
> 2014-09-11 07:47, Hiroshi Shimamoto:
> > Do not touch pktmbuf directly.
> >
> > Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()
> > to access the property.
> 
> I guess this change is for compatibility with DPDK 1.8.

Yep, I had the thought need to prepare upcoming code.

> Does it have an impact on performance?

No, it must not.

thanks,
Hiroshi

> 
> --
> Thomas
diff mbox

Patch

diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index bbb5380..8341da7 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -308,8 +308,8 @@  static uint16_t memnic_recv_pkts(void *rx_queue,
 
 		rte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len);
 		mb->pkt.in_port = q->port_id;
-		mb->pkt.pkt_len = p->len;
-		mb->pkt.data_len = p->len;
+		rte_pktmbuf_pkt_len(mb) = p->len;
+		rte_pktmbuf_data_len(mb) = p->len;
 		rx_pkts[nr] = mb;
 
 		pkts++;