[dpdk-dev,memnic,2/7] pmd: remove needless assignment
diff mbox

Message ID 7F861DC0615E0C47A872E6F3C5FCDDBD011A98F1@BPXM14GP.gisp.nec.co.jp
State Superseded, archived
Headers show

Commit Message

Hiroshi Shimamoto Sept. 11, 2014, 7:47 a.m. UTC
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
 pmd/pmd_memnic.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Thomas Monjalon Sept. 24, 2014, 3:13 p.m. UTC | #1
2014-09-11 07:47, Hiroshi Shimamoto:
> Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.

Is it increasing the performances?
Hiroshi Shimamoto Sept. 24, 2014, 11:58 p.m. UTC | #2
> Subject: Re: [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment
> 
> 2014-09-11 07:47, Hiroshi Shimamoto:
> > Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.
> 
> Is it increasing the performances?

I hadn't tried to test, because I don't think it can be noticed.
Just clean up, removing a few redundant instructions.

thanks,
Hiroshi

> 
> --
> Thomas

Patch
diff mbox

diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index 994ed0a..bbb5380 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -308,8 +308,6 @@  static uint16_t memnic_recv_pkts(void *rx_queue,
 
 		rte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len);
 		mb->pkt.in_port = q->port_id;
-		mb->pkt.nb_segs = 1;
-		mb->pkt.next = NULL;
 		mb->pkt.pkt_len = p->len;
 		mb->pkt.data_len = p->len;
 		rx_pkts[nr] = mb;