From patchwork Wed Oct 4 10:54:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Van Haaren, Harry" X-Patchwork-Id: 29587 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 950471B646; Wed, 4 Oct 2017 12:54:35 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 022001B629 for ; Wed, 4 Oct 2017 12:54:31 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2017 03:54:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.42,477,1500966000"; d="scan'208"; a="1226897101" Received: from silpixa00398672.ir.intel.com ([10.237.223.128]) by fmsmga002.fm.intel.com with ESMTP; 04 Oct 2017 03:54:30 -0700 From: Harry van Haaren To: dev@dpdk.org Cc: Harry van Haaren Date: Wed, 4 Oct 2017 11:54:51 +0100 Message-Id: <1507114491-144338-4-git-send-email-harry.van.haaren@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1507114491-144338-1-git-send-email-harry.van.haaren@intel.com> References: <1507114491-144338-1-git-send-email-harry.van.haaren@intel.com> Subject: [dpdk-dev] [PATCH 3/3] service: add attribute for number of invokations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit adds a new attribute to the service cores attributes API, which allows the application to retrieve the number of times that a service-core called the service to perform its action. Signed-off-by: Harry van Haaren --- lib/librte_eal/common/include/rte_service.h | 5 +++++ lib/librte_eal/common/rte_service.c | 3 +++ test/test/test_service_cores.c | 16 ++++++++++++++++ 3 files changed, 24 insertions(+) diff --git a/lib/librte_eal/common/include/rte_service.h b/lib/librte_eal/common/include/rte_service.h index bf7b50b..4684985 100644 --- a/lib/librte_eal/common/include/rte_service.h +++ b/lib/librte_eal/common/include/rte_service.h @@ -366,6 +366,11 @@ int32_t rte_service_dump(FILE *f, uint32_t id); #define RTE_SERVICE_ATTR_CYCLES 0 /** + * Returns the count of invokations of this service function + */ +#define RTE_SERVICE_ATTR_CALL_COUNT 1 + +/** * @warning * @b EXPERIMENTAL: this API may change without prior notice * diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c index 3f274f4..fe0b8cf 100644 --- a/lib/librte_eal/common/rte_service.c +++ b/lib/librte_eal/common/rte_service.c @@ -657,6 +657,9 @@ rte_service_attr_get(uint32_t id, uint32_t attr_id, uint32_t *attr_value) case RTE_SERVICE_ATTR_CYCLES: *attr_value = s->cycles_spent; return 0; + case RTE_SERVICE_ATTR_CALL_COUNT: + *attr_value = s->calls; + return 0; default: return -EINVAL; } diff --git a/test/test/test_service_cores.c b/test/test/test_service_cores.c index dd3bf75..cabf5de 100644 --- a/test/test/test_service_cores.c +++ b/test/test/test_service_cores.c @@ -306,6 +306,12 @@ service_attr_get(void) "Valid attr_get() call didn't return success"); TEST_ASSERT_EQUAL(0, attr_value, "attr_get() call didn't set correct cycles (zero)"); + /* check correct call count */ + const int attr_calls = RTE_SERVICE_ATTR_CALL_COUNT; + TEST_ASSERT_EQUAL(0, rte_service_attr_get(id, attr_calls, &attr_value), + "Valid attr_get() call didn't return success"); + TEST_ASSERT_EQUAL(0, attr_value, + "attr_get() call didn't get call count (zero)"); /* Call service to increment cycle count */ TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_id), @@ -326,6 +332,11 @@ service_attr_get(void) rte_service_lcore_stop(slcore_id); + TEST_ASSERT_EQUAL(0, rte_service_attr_get(id, attr_calls, &attr_value), + "Valid attr_get() call didn't return success"); + TEST_ASSERT_EQUAL(1, (attr_value > 0), + "attr_get() call didn't get call count (zero)"); + TEST_ASSERT_EQUAL(0, rte_service_attr_reset_all(id), "Valid attr_reset_all() return success"); @@ -333,6 +344,11 @@ service_attr_get(void) "Valid attr_get() call didn't return success"); TEST_ASSERT_EQUAL(0, attr_value, "attr_get() call didn't set correct cycles (zero)"); + /* ensure call count > zero */ + TEST_ASSERT_EQUAL(0, rte_service_attr_get(id, attr_calls, &attr_value), + "Valid attr_get() call didn't return success"); + TEST_ASSERT_EQUAL(0, (attr_value > 0), + "attr_get() call didn't get call count (zero)"); return unregister_all(); }