[dpdk-dev] testpmd: fix crash in txonly mode and when using tx_first
diff mbox

Message ID 1409567471-18978-1-git-send-email-david.marchand@6wind.com
State Accepted, archived
Headers show

Commit Message

David Marchand Sept. 1, 2014, 10:31 a.m. UTC
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>

This crash was believed fixed by commit 5886ae07d211e4b5e49806dd183812beb31c67ad,
but the actual issue is that the core ID provided to rte_lcore_to_socket_id() is
wrong. It must be looked up in fwd_lcores_cpuids[].

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 app/test-pmd/testpmd.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon Sept. 1, 2014, 10:59 a.m. UTC | #1
2014-09-01 12:31, David Marchand:
> From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> This crash was believed fixed by commit 5886ae07d211e4b5e49806dd183812beb31c67ad,
> but the actual issue is that the core ID provided to rte_lcore_to_socket_id() is
> wrong. It must be looked up in fwd_lcores_cpuids[].
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Signed-off-by: David Marchand <david.marchand@6wind.com>

Applied for version 1.7.1.

Thanks

Patch
diff mbox

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index a112559..8f5f9ad 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -614,7 +614,9 @@  init_config(void)
 	 * Records which Mbuf pool to use by each logical core, if needed.
 	 */
 	for (lc_id = 0; lc_id < nb_lcores; lc_id++) {
-		mbp = mbuf_pool_find(rte_lcore_to_socket_id(lc_id));
+		mbp = mbuf_pool_find(
+			rte_lcore_to_socket_id(fwd_lcores_cpuids[lc_id]));
+
 		if (mbp == NULL)
 			mbp = mbuf_pool_find(0);
 		fwd_lcores[lc_id]->mbp = mbp;