From patchwork Wed Jan 21 23:36:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Matz X-Patchwork-Id: 2453 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 1AE965AD7; Thu, 22 Jan 2015 00:37:15 +0100 (CET) Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 99D505A15 for ; Thu, 22 Jan 2015 00:36:59 +0100 (CET) Received: by mail-wi0-f171.google.com with SMTP id l15so29986979wiw.4 for ; Wed, 21 Jan 2015 15:36:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RHRccN9CfYRn8NJyG5RQxrxjbizJsHiBrzoQesj4884=; b=EY/Uw9lHw38HIIlpGFmxydmBRAG8Af1vSCMtlchUhRfAlqm8O3jf534wglXcZsSlVj ERtn0EopzcapMLDX9HwnfLaRZOTbPQmP0X2hUfviCXSykLz8QrYLsIfFLWlh+hMTlb+b caZ0wlrU8VeBTkIn541LrAyyvXtFFEG2+7G9XStXblWcfpXtlDLFzHngttlPmSA/P4MA n/Xw6jPvjNlTXWuvfsKppU50Orfo21/bQ5hevwlJg4gvhy8wAwVPfZyiXwPxIYImZrUh rm6lP8foZjodhSyLcnlBNrMC0mT5sNPOF+Oe2mFTx80WLB5D/oS0raCZn1xZeLYtXp8k nsKw== X-Gm-Message-State: ALoCoQm/qFR2krBYtLyAIbEBRaSs5l588Y+A9SHusTH6HyvS6BQiEgwytChknmupuO07eAuhly4D X-Received: by 10.194.234.2 with SMTP id ua2mr27685670wjc.40.1421883419497; Wed, 21 Jan 2015 15:36:59 -0800 (PST) Received: from glumotte.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id wa5sm1710761wjc.8.2015.01.21.15.36.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Jan 2015 15:36:59 -0800 (PST) From: Olivier Matz To: dev@dpdk.org Date: Thu, 22 Jan 2015 00:36:33 +0100 Message-Id: <1421883395-27235-15-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com> References: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com> Subject: [dpdk-dev] [RFC 14/16] testpmd: introduce parse_vxlan in csum fwd engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Move code parsing vxlan into a function. It will ease the support of GRE tunnels and IPIP tunnels in next commits. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 68 +++++++++++++++++++++++++++---------------------- 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 0b89d89..52af0e7 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -93,7 +93,6 @@ struct testpmd_offload_info { uint16_t l3_len; uint16_t l4_len; uint8_t l4_proto; - uint8_t l4_tun_len; uint8_t is_tunnel; uint16_t outer_ethertype; uint16_t outer_l2_len; @@ -191,6 +190,34 @@ parse_ethernet(struct ether_hdr *eth_hdr, struct testpmd_offload_info *info) } } +/* Parse a vxlan header */ +static void +parse_vxlan(struct udp_hdr *udp_hdr, struct testpmd_offload_info *info, + uint64_t mbuf_olflags) +{ + struct ether_hdr *eth_hdr; + + /* check udp destination port, 4789 is the default vxlan port + * (rfc7348) or that the rx offload flag is set (i40e only + * currently) */ + if (udp_hdr->dst_port != _htons(4789) && + (mbuf_olflags & (PKT_RX_TUNNEL_IPV4_HDR | + PKT_RX_TUNNEL_IPV6_HDR)) != 0) + return; + + info->is_tunnel = 1; + info->outer_ethertype = info->ethertype; + info->outer_l2_len = info->l2_len; + info->outer_l3_len = info->l3_len; + + eth_hdr = (struct ether_hdr *)((char *)udp_hdr + + sizeof(struct udp_hdr) + + sizeof(struct vxlan_hdr)); + + parse_ethernet(eth_hdr, info); + info->l2_len += ETHER_VXLAN_HLEN; /* add udp + vxlan */ +} + /* modify the IPv4 or IPv4 source address of a packet */ static void change_ip_addresses(void *l3_hdr, uint16_t ethertype) @@ -356,7 +383,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) struct rte_mbuf *m; struct ether_hdr *eth_hdr; void *l3_hdr = NULL, *outer_l3_hdr = NULL; /* can be IPv4 or IPv6 */ - struct udp_hdr *udp_hdr; uint16_t nb_rx; uint16_t nb_tx; uint16_t i; @@ -414,33 +440,15 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) /* check if it's a supported tunnel (only vxlan for now) */ if ((testpmd_ol_flags & TESTPMD_TX_OFFLOAD_PARSE_TUNNEL) && info.l4_proto == IPPROTO_UDP) { + struct udp_hdr *udp_hdr; udp_hdr = (struct udp_hdr *)((char *)l3_hdr + info.l3_len); + parse_vxlan(udp_hdr, &info, m->ol_flags); + } - /* check udp destination port, 4789 is the default - * vxlan port (rfc7348) */ - if (udp_hdr->dst_port == _htons(4789)) { - info.l4_tun_len = ETHER_VXLAN_HLEN; - info.is_tunnel = 1; - - /* currently, this flag is set by i40e only if the - * packet is vxlan */ - } else if (m->ol_flags & (PKT_RX_TUNNEL_IPV4_HDR | - PKT_RX_TUNNEL_IPV6_HDR)) - info.is_tunnel = 1; - - if (info.is_tunnel == 1) { - info.outer_ethertype = info.ethertype; - info.outer_l2_len = info.l2_len; - info.outer_l3_len = info.l3_len; - outer_l3_hdr = l3_hdr; - - eth_hdr = (struct ether_hdr *)((char *)udp_hdr + - sizeof(struct udp_hdr) + - sizeof(struct vxlan_hdr)); - - parse_ethernet(eth_hdr, &info); - l3_hdr = (char *)eth_hdr + info.l2_len; - } + /* update l3_hdr and outer_l3_hdr if a tunnel was parsed */ + if (info.is_tunnel) { + outer_l3_hdr = l3_hdr; + l3_hdr = (char *)l3_hdr + info.outer_l3_len + info.l2_len; } /* step 2: change all source IPs (v4 or v6) so we need @@ -472,7 +480,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) if (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_OUTER_IP_CKSUM) { m->outer_l2_len = info.outer_l2_len; m->outer_l3_len = info.outer_l3_len; - m->l2_len = info.l4_tun_len + info.l2_len; + m->l2_len = info.l2_len; m->l3_len = info.l3_len; } else { @@ -482,9 +490,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) the payload will be modified by the hardware */ m->l2_len = info.outer_l2_len + - info.outer_l3_len + - sizeof(struct udp_hdr) + - sizeof(struct vxlan_hdr) + info.l2_len; + info.outer_l3_len + info.l2_len; m->l3_len = info.l3_len; m->l4_len = info.l4_len; }