[dpdk-dev] mk: use extra cflags when linking apps with the compiler

Message ID 1493136647-14744-1-git-send-email-gage.eads@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Eads, Gage April 25, 2017, 4:10 p.m. UTC
  From: John Jacques <john.jacques@intel.com>

When using the compiler to link applications, include EXTRA_CFLAGS. This
is needed, for example, when cross-compiling, to pass --sysroot.
GCC cross-compilers built with Yocto don't use the --with-sysroot option,
making it necessary to pass --sysroot command-line option.

Signed-off-by: John Jacques <john.jacques@intel.com>
Signed-off-by: Gage Eads <gage.eads@intel.com>
---
 mk/rte.app.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Thomas Monjalon April 30, 2017, 7:52 p.m. UTC | #1
25/04/2017 18:10, Gage Eads:
> From: John Jacques <john.jacques@intel.com>
> 
> When using the compiler to link applications, include EXTRA_CFLAGS. This
> is needed, for example, when cross-compiling, to pass --sysroot.
> GCC cross-compilers built with Yocto don't use the --with-sysroot option,
> making it necessary to pass --sysroot command-line option.
> 
> Signed-off-by: John Jacques <john.jacques@intel.com>
> Signed-off-by: Gage Eads <gage.eads@intel.com>

Applied, thanks
  

Patch

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index b5215c0..bcaf1b3 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -235,7 +235,7 @@  build: _postbuild
 exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
 
 ifeq ($(LINK_USING_CC),1)
-O_TO_EXE = $(CC) -o $@ $(CFLAGS) $(OBJS-y) $(call linkerprefix, \
+O_TO_EXE = $(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $(OBJS-y) $(call linkerprefix, \
 	$(LDLIBS) $(LDFLAGS) $(LDFLAGS_$(@)) $(EXTRA_LDFLAGS) \
 	$(MAPFLAGS))
 else