diff mbox

[dpdk-dev,2/2] app/testpmd:csum fwd engine change

Message ID 1421375468-18083-3-git-send-email-jijiang.liu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Helin Zhang
Headers

Commit Message

Jijiang Liu Jan. 16, 2015, 2:31 a.m. UTC 
  change the palce of setting UDP tunneling packet offload flag.

Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
---
 app/test-pmd/csumonly.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

Comments

Olivier Matz Jan. 16, 2015, 5:29 p.m. UTC | #1 
Hi Jijiang,

On 01/16/2015 03:31 AM, Jijiang Liu wrote:
> change the palce of setting UDP tunneling packet offload flag.

typo here

> 
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> ---
>  app/test-pmd/csumonly.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
> index 41711fd..57afdfc 100644
> --- a/app/test-pmd/csumonly.c
> +++ b/app/test-pmd/csumonly.c
> @@ -256,9 +256,6 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype,
>  	struct udp_hdr *udp_hdr;
>  	uint64_t ol_flags = 0;
>  
> -	if (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM)
> -		ol_flags |= PKT_TX_UDP_TUNNEL_PKT;
> -
>  	if (outer_ethertype == _htons(ETHER_TYPE_IPv4)) {
>  		ipv4_hdr->hdr_checksum = 0;
>  
> @@ -392,6 +389,10 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
>  				tunnel = 1;
>  
>  			if (tunnel == 1) {
> +				if (testpmd_ol_flags &
> +					TESTPMD_TX_OFFLOAD_VXLAN_CKSUM)
> +					ol_flags |= PKT_TX_UDP_TUNNEL_PKT;
> +
>  				outer_ethertype = ethertype;
>  				outer_l2_len = l2_len;
>  				outer_l3_len = l3_len;
> 

Can you explain why you are moving this code?

Regards,
Olivier
diff mbox

Patch

diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index 41711fd..57afdfc 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -256,9 +256,6 @@  process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype,
 	struct udp_hdr *udp_hdr;
 	uint64_t ol_flags = 0;
 
-	if (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM)
-		ol_flags |= PKT_TX_UDP_TUNNEL_PKT;
-
 	if (outer_ethertype == _htons(ETHER_TYPE_IPv4)) {
 		ipv4_hdr->hdr_checksum = 0;
 
@@ -392,6 +389,10 @@  pkt_burst_checksum_forward(struct fwd_stream *fs)
 				tunnel = 1;
 
 			if (tunnel == 1) {
+				if (testpmd_ol_flags &
+					TESTPMD_TX_OFFLOAD_VXLAN_CKSUM)
+					ol_flags |= PKT_TX_UDP_TUNNEL_PKT;
+
 				outer_ethertype = ethertype;
 				outer_l2_len = l2_len;
 				outer_l3_len = l3_len;