[dpdk-dev] eal: deprecate rte_cpu_check_supported
Checks
Commit Message
It's likely that this function isn't used anywhere, but since it was part of
the public API, mark the function for deprecation for at least one release.
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++++++
lib/librte_eal/common/arch/x86/rte_cpuflags.c | 1 +
lib/librte_eal/common/arch/x86/rte_spinlock.c | 1 +
lib/librte_eal/common/include/generic/rte_cpuflags.h | 3 ++-
lib/librte_eal/linuxapp/eal/rte_eal_version.map | 7 +++++++
5 files changed, 18 insertions(+), 1 deletion(-)
Comments
On Fri, Mar 31, 2017 at 02:31:22PM -0400, Aaron Conole wrote:
> It's likely that this function isn't used anywhere, but since it was part of
> the public API, mark the function for deprecation for at least one release.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
2017-03-31 14:31, Aaron Conole:
> It's likely that this function isn't used anywhere, but since it was part of
> the public API, mark the function for deprecation for at least one release.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
[...]
> --- a/lib/librte_eal/common/arch/x86/rte_spinlock.c
> +++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c
> @@ -33,6 +33,7 @@
>
> #include <stdint.h>
>
> +#include "rte_common.h"
> #include "rte_cpuflags.h"
This include should be added in rte_cpuflags.h.
There are other C files which could need rte_common.h,
example: test/test/test_cpuflags.c
[...]
> --- a/lib/librte_eal/common/include/generic/rte_cpuflags.h
> +++ b/lib/librte_eal/common/include/generic/rte_cpuflags.h
> @@ -78,9 +78,10 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature);
> * This function checks that the currently used CPU supports the CPU features
> * that were specified at compile time. It is called automatically within the
> * EAL, so does not need to be used by applications.
> + * This version is replaced by rte_cpu_is_supported
> */
> void
> -rte_cpu_check_supported(void);
> +rte_cpu_check_supported(void) __rte_deprecated;
The deprecated flag must be moved before the function declaration.
Otherwise clangs throws an error.
[...]
> +DPDK_17.05 {
> + global;
> +
> + rte_cpu_is_supported;
> +
> +} DPDK_17.02;
Should not it be a separate patch?
Hi Thomas,
Thomas Monjalon <thomas.monjalon@6wind.com> writes:
> 2017-03-31 14:31, Aaron Conole:
>> It's likely that this function isn't used anywhere, but since it was part of
>> the public API, mark the function for deprecation for at least one release.
>>
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
Thanks so much for the review! I'll make sure to fix these with v2.
> [...]
>> +DPDK_17.05 {
>> + global;
>> +
>> + rte_cpu_is_supported;
>> +
>> +} DPDK_17.02;
>
> Should not it be a separate patch?
I thought it made sense to keep it rolled in with this patch, but if you
prefer it separate, I will do that. Expect it as 1/2 in v2, unless you
say otherwise.
-Aaron
2017-04-04 09:39, Aaron Conole:
> Hi Thomas,
>
> Thomas Monjalon <thomas.monjalon@6wind.com> writes:
>
> > 2017-03-31 14:31, Aaron Conole:
> >> It's likely that this function isn't used anywhere, but since it was part of
> >> the public API, mark the function for deprecation for at least one release.
> >>
> >> Signed-off-by: Aaron Conole <aconole@redhat.com>
>
> Thanks so much for the review! I'll make sure to fix these with v2.
>
> > [...]
> >> +DPDK_17.05 {
> >> + global;
> >> +
> >> + rte_cpu_is_supported;
> >> +
> >> +} DPDK_17.02;
> >
> > Should not it be a separate patch?
>
> I thought it made sense to keep it rolled in with this patch, but if you
> prefer it separate, I will do that. Expect it as 1/2 in v2, unless you
> say otherwise.
Yes 2 patches in v2. Thanks
@@ -182,3 +182,10 @@ DPDK_17.02 {
rte_bus_unregister;
} DPDK_16.11;
+
+DPDK_17.05 {
+ global;
+
+ rte_cpu_is_supported;
+
+} DPDK_17.02;
@@ -31,6 +31,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+#include "rte_common.h"
#include "rte_cpuflags.h"
#include <stdio.h>
@@ -33,6 +33,7 @@
#include <stdint.h>
+#include "rte_common.h"
#include "rte_cpuflags.h"
uint8_t rte_rtm_supported; /* cache the flag to avoid the overhead
@@ -78,9 +78,10 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature);
* This function checks that the currently used CPU supports the CPU features
* that were specified at compile time. It is called automatically within the
* EAL, so does not need to be used by applications.
+ * This version is replaced by rte_cpu_is_supported
*/
void
-rte_cpu_check_supported(void);
+rte_cpu_check_supported(void) __rte_deprecated;
/**
* This function checks that the currently used CPU supports the CPU features
@@ -186,3 +186,10 @@ DPDK_17.02 {
rte_bus_unregister;
} DPDK_16.11;
+
+DPDK_17.05 {
+ global;
+
+ rte_cpu_is_supported;
+
+} DPDK_17.02;